Fix issue with pullrequests in Azure DevOps #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@enriqueraso can you update the tests to cover the additional prefixes you added? |
|
@arturcic Indeed, I will update it. :) |
|
@arturcic additional prefixes were added as well a new unit test. |
|
@enriqueraso, I think if you want to have this included in the next release, better rebase this PR on support/5.x branch. Please include only your commits on top |
asbjornu
requested changes
Aug 29, 2022
enriqueraso
force-pushed
the
bug/inherit-fail-on-azure-pullrequest
branch
from
0d0d0c4
to
5ab3420
Compare
added 3 commits
August 30, 2022 09:45
… and Remotes not well replaced.
enriqueraso
force-pushed
the
bug/inherit-fail-on-azure-pullrequest
branch
from
100b53d
to
4b18753
Compare
arturcic
approved these changes
Aug 30, 2022
|
Thank you @enriqueraso for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with PullRequests in Azure DevOps. PullRequest not well detected and Remotes not well replaced.
Description
It detects correctly when a reference name is a PullRequest and also remove Remotes properly on a PullRequest.
Helps on Azure DevOps PullRequest completion. Otherwise it doesn't inherit semver calculated on source branch.
Related Issue
Fix #3180
Motivation and Context
I want to use GitVersion in Azure DevOps with the gitversion.yml described in the bug.
How Has This Been Tested?
I tested it on Azure DevOps adding binaries to the repo and change yml file.
Screenshots:
Checklist: