-
Notifications
You must be signed in to change notification settings - Fork 664
(deps): Bump Buildalyzer from 3.2.2 to 3.2.6 #2947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| <PackageReference Include="Microsoft.Build" Version="16.11.0" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition=" '$(TargetFramework)' != 'netcoreapp3.1' or '$(TargetFramework)' != 'net5.0' "> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use some config for all targetFrameworks?
What do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some unit tests failed on my local machine, which environment is Windows 10 and Visual Studio 2022. The reason is the Buildalyzer 3.2.5 reference to Microsoft.Build.dll version 16. So the project references to Microsoft.Build.dll version 16 and Microsoft.Build.Framework.dll version 17. But I'm confused why the CI is success.


I don't know why you use different package versions for .net core 3.1 and net5.0 in commit bb243bc
But I founded that the failed unit tests run success by replacing
<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp3.1' ">
<PackageReference Include="Buildalyzer" Version="3.2.2" />
<PackageReference Include="MSBuild.ProjectCreation" Version="6.3.3" />
<PackageReference Include="Microsoft.Build" Version="16.9.0" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net5.0' ">
<PackageReference Include="Buildalyzer" Version="3.2.5" />
<PackageReference Include="MSBuild.ProjectCreation" Version="6.3.3" />
<PackageReference Include="Microsoft.Build" Version="16.11.0" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' != 'netcoreapp3.1' or '$(TargetFramework)' != 'net5.0' ">
<PackageReference Include="Buildalyzer" Version="3.2.5" />
<PackageReference Include="MSBuild.ProjectCreation" Version="6.3.3" />
<PackageReference Include="Microsoft.Build" Version="17.0.0" />
</ItemGroup>
with
<ItemGroup>
<PackageReference Include="Buildalyzer" Version="3.2.5" />
<PackageReference Include="MSBuild.ProjectCreation" Version="6.3.3" />
<PackageReference Include="Microsoft.Build" Version="17.0.0" />
<PackageReference Include="Microsoft.Build.Framework" Version="17.0.0" />
</ItemGroup>
.
<PackageReference Include="Microsoft.Build.Framework" Version="17.0.0" />
is added to fix the version conflict of Microsoft.Build.Framework.dll and Microsoft.Build.
7f51101 to
07a6828
Compare
f4a422a to
833026f
Compare
Bumps [Buildalyzer](https://github.com/daveaglick/Buildalyzer) from 3.2.2 to 3.2.6. - [Release notes](https://github.com/daveaglick/Buildalyzer/releases) - [Changelog](https://github.com/daveaglick/Buildalyzer/blob/main/ReleaseNotes.md) - [Commits](Buildalyzer/Buildalyzer@v3.2.2...v3.2.6) --- updated-dependencies: - dependency-name: Buildalyzer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
833026f to
d2a6d9d
Compare
|
Superseded by #2965. |
Bumps Buildalyzer from 3.2.2 to 3.2.6.
Release notes
Sourced from Buildalyzer's releases.
Changelog
Sourced from Buildalyzer's changelog.
Commits
325949aSets an encoding for workspace source text (#128)ba22694Fixing up some small bugs including support for .NET 5/6 dotnet --info calls5ebe40fIgnore case when looking in _cscCommandLineArguments14e6a8cRemove submodules487bcdbAdd PreprocessorSymbols to analyserResultfd3d5f0UseAppHost = false78f4427added hello-world test case for net 6.0 projectse30d447Updating StructuredLogger to fix type duplication problemsa219748Version bump93e2dc0Added tests for different binlog versionsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)