Create the auth "vertical" #714
Merged
+98
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify code and format dates as Grammarly says they should be formatted: https://www.grammarly.com/blog/how-to-write-dates/
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #714 +/- ##
=======================================
Coverage 92.20% 92.21%
=======================================
Files 135 136 +1
Lines 5839 5841 +2
=======================================
+ Hits 5384 5386 +2
Misses 455 455
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intro
This PR introduces an
auth"vertical". It's not a real vertical but it provides the same support as otherggshield.verticalspackages to theggshield.cmdpackages.What has been done
I initially considered moving part of cmd.login and cmd.logout there but it would require more refactoring to make the code less tied to the CLI parsing and output. It is not worth the move without these refactoring IMHO and I do not want to spend time on it for now.
Instead I just moved OAuthClient and its related code there, and moved an helper date formatting function to core.textutils.
While I was at it, I simplified said helper date and made it output a more correctly formatted string.
Ref
Part of #521.