Isolate functional tests from user Git config #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow to debug functional tests more easily.
agateau-gg
requested changes
Aug 21, 2023
scripts/run-functional-tests
Outdated
| } | ||
|
|
||
| isolate() { | ||
| export GIT_CONFIG_GLOBAL='' | ||
| export GIT_CONFIG_SYSTEM='' |
There was a problem hiding this comment.
I just found out we already hit that issue once in the past, but it was only fixed for the unittest Makefile target. I think we should unify this and add an autouse fixture to unset the variables in tests/conftest.py instead. This way the fix is also applied when one runs pytest directly.
There was a problem hiding this comment.
Yes, this is a better way to fix that problem. I have updated the PR.
fbochu
force-pushed
the
fbochu/git-isolate-functest
branch
from
266b5e2 to
b984b46
Compare
fbochu
force-pushed
the
fbochu/git-isolate-functest
branch
2 times, most recently
from
d1089b6 to
3a9d9d9
Compare
Some users could have hooks defined in their Git template directory. The content of this directory is copied every time a repository is cloned or created. We have to isolate our functional tests to avoid the user Git config interferes with our tests.
fbochu
force-pushed
the
fbochu/git-isolate-functest
branch
from
3a9d9d9 to
f104968
Compare
agateau-gg
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users could have hooks defined in their Git template directory. The content of this directory is copied every time a repository is cloned or created. We have to isolate our functional tests to avoid the user Git config interferes with our tests.