Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unbreak perfbench step #701

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

agateau-gg
Copy link
Collaborator

@agateau-gg agateau-gg commented Aug 21, 2023

Pin pipenv to a version which still supports the --skip-lock option, like we do in the ci.yml workflow.

This fixes https://github.com/GitGuardian/ggshield/actions/runs/5924686760/job/16062675817?pr=700

Successfully installed certifi-2023.7.22 distlib-0.3.7 filelock-3.12.2 pipenv-2023.8.20 platformdirs-3.10.0 setuptools-68.1.2 virtualenv-20.24.3
The flag --skip-lock has been functionally removed.  Without running the lock 
resolver it is not possible to manage multiple package indexes.  Additionally it
bypassed the build consistency guarantees provided by maintaining a lock file.
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.12/x64/bin/pipenv", line 8, in <module>
    sys.exit(cli())
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/pipenv/cli/options.py", line 58, in main
    return super().main(*args, **kwargs, windows_expand_args=False)
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 1655, in invoke
    sub_ctx = cmd.make_context(cmd_name, args, parent=ctx)
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 920, in make_context
    self.parse_args(ctx, args)
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 1378, in parse_args
    value, args = param.handle_parse_result(ctx, opts, args)
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 2360, in handle_parse_result
    value = self.process_value(ctx, value)
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/pipenv/vendor/click/core.py", line 2322, in process_value
    value = self.callback(ctx, self, value)
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/pipenv/cli/options.py", line 497, in callback
    raise ValueError("The flag --skip-lock flag has been removed.")
ValueError: The flag --skip-lock flag has been removed.
Error: Process completed with exit code 1.

Pin pipenv to a version which still supports the --skip-lock option,
like we do in the ci.yml workflow.
@codecov-commenter
Copy link

Codecov Report

Merging #701 (71547ad) into main (74299bf) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #701   +/-   ##
=======================================
  Coverage   92.33%   92.33%           
=======================================
  Files         135      135           
  Lines        5831     5831           
=======================================
  Hits         5384     5384           
  Misses        447      447           
Flag Coverage Δ
unittests 92.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@agateau-gg agateau-gg merged commit b084f89 into main Aug 21, 2023
@agateau-gg agateau-gg deleted the agateau/unbreak-perf-benchmark branch August 21, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants