Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mmillet/spi 515 add all secrets option to ggshield secret scans #1024

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Mmillet/spi 515 add all secrets option to ggshield secret scans #1024

wants to merge 5 commits into from

Commits on Nov 29, 2024

  1. chore(scanner): prepare for all_secrets option 

    - remove `ignore_known_secrets=True`, which didn't make sense
- add `all_secrets=True`, to get all secrets found by the backend

Notes:
- Since we add `all_secrets=True`, we also need to filter-out secrets                                                                                                          [13:30:5         excluded by the backend
- Since we changed the query params, all secret-related cassettes
  have been rewritten
    @gg-mmill
    gg-mmill committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    7883f7b View commit details
    Browse the repository at this point in the history

  2. feat(secret_scan): track options usage

    @gg-mmill
    gg-mmill committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    7a963df View commit details
    Browse the repository at this point in the history

  3. feat(secret_scan): add all_result option

    @gg-mmill
    gg-mmill committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    c6b96ce View commit details
    Browse the repository at this point in the history

  4. chore: add factory-boy to dev dependencies

    @gg-mmill
    gg-mmill committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    c198bb0 View commit details
    Browse the repository at this point in the history

  5. chore: add tests, with factories !

    @gg-mmill
    gg-mmill committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    2eba569 View commit details
    Browse the repository at this point in the history