Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing doc generation #2037

Conversation

kevinmessiaen
Copy link
Member

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)

@alexcombessie
Copy link
Member

alexcombessie commented Oct 10, 2024

FYI @ebursztein this is linked to the issue you spotted earlier on https://docs.giskard.ai/en/stable/reference/rag-toolset/question_generation.html

kevinmessiaen and others added 5 commits October 15, 2024 08:34
…tion-for-the-rag-evaluation-toolkit-be-completed' into 2032-when-will-the-api-documentation-for-the-rag-evaluation-toolkit-be-completed
@kevinmessiaen kevinmessiaen changed the title WIP: Fixing doc generation Fixing doc generation Oct 15, 2024
@kevinmessiaen kevinmessiaen marked this pull request as ready for review October 15, 2024 11:48
This reverts commit eed06f6.
Copy link

sonarcloud bot commented Oct 15, 2024

@kevinmessiaen kevinmessiaen merged commit b3d877c into main Oct 15, 2024
17 checks passed
@kevinmessiaen kevinmessiaen deleted the 2032-when-will-the-api-documentation-for-the-rag-evaluation-toolkit-be-completed branch October 15, 2024 12:14
@henchaves
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants