[WIP] Fixes for julia 0.7 deprecations #279
Conversation
|
i was going to let femtocleaner take the first pass just after we merge GiovineItalia/Gadfly.jl#1090. dropping support for 0.5 will automatically trigger a femto cleaner PR. |
|
We can still run femtocleaner on this PR, right?. There's still plenty of cruft from previous julia version bumps that it can clean up. |
|
yes, but, it would caught everything you did so far. no need to put manual sweat into it. let's wait to merge this until after we tag a release, just right before dataframes merges. |
| # Bounding box relative to the parent's coordinates | ||
| box::BoundingBox | ||
|
|
||
| # Context coordinates used for children | ||
| units::Nullable{UnitBox} | ||
| @compat units::Union{UnitBox, Nothing} |
There was a problem hiding this comment.
i had to revert this and similar changes as they causes tests to fail. was this for 0.7?
There was a problem hiding this comment.
This change was needed for v0.7, but I hadn't verified that my solution worked on v0.6. See JuliaLang/julia#23642
this is a follow up to #279 temp hack for missing load_cache_path on 0.7 See JuliaLang/Compat.jl#527 for details replace more voids that slipped past the first round more deprecation fixes prelim work on adding optional runtime backend loading use Compat's @info so we don't break v0.6
It looks like upstream packages are finally building on the nightlies so it's time to get Compose working as well.