Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain macro indirection #73

Merged
merged 1 commit into from
May 19, 2023
Merged

Conversation

Gilnaa
Copy link
Owner

@Gilnaa Gilnaa commented May 19, 2023

offset_of! implementation was moved to an internal macro _memoffset__offset_of_impl! in
PR #72.

This was done in order to have a single top-level macro that doc-comments can be attached to.

`offset_of!` implementation was moved to an internal macro
`_memoffset__offset_of_impl!` in
[PR #72](#72).

This was done in order to have a single top-level macro that
doc-comments can be attached to.
Copy link
Collaborator

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@Gilnaa Gilnaa merged commit 6afc606 into master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants