Skip to content

fix(docker): npm config + fail-loud build validation (follow-up to #31) #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
songkuan-zheng merged 1 commit into from
May 29, 2026
Merged

fix(docker): npm config + fail-loud build validation (follow-up to #31) #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,5 @@ STABILIZATION_TODO.md
litellm/proxy/_experimental/out/
ui/litellm-dashboard/out/
ui/litellm-dashboard/.next/
ui/litellm-dashboard/node_modules/
ui/litellm-dashboard/node_modules/
.gstack/
25 changes: 17 additions & 8 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,23 @@ COPY . .
# layer slim. The committed bundle (now .gitignored) is treated as a
# "seed for fresh clones that don't run docker build" only — it is
# always overwritten by this step in any image that actually ships.
RUN cd ui/litellm-dashboard && \
npm ci --no-audit --no-fund --prefer-offline && \
npm run build && \
rm -rf /app/litellm/proxy/_experimental/out && \
cp -r out /app/litellm/proxy/_experimental/out && \
cd /app && \
rm -rf ui/litellm-dashboard/node_modules ui/litellm-dashboard/out && \
npm cache clean --force 2>/dev/null || true
RUN set -eux; \
cd ui/litellm-dashboard; \
# Builder image's npm doesn't recognize min-release-age (npm 11+
# config in the project's .npmrc for local-dev supply-chain
# hardening) and treats it as a fatal `npm ci` config error. The
# .npmrc comment notes "npm ci ignores this" — true for newer
# npm, not for the builder's older one. Override to 0 just for
# this RUN so the lockfile install still works.
NPM_CONFIG_MIN_RELEASE_AGE=0 npm ci --no-audit --no-fund --prefer-offline; \
npm run build; \
test -f out/index.html || { echo "FATAL: next build did not produce out/index.html"; ls -la out/ 2>/dev/null; exit 1; }; \
rm -rf /app/litellm/proxy/_experimental/out; \
cp -r out /app/litellm/proxy/_experimental/out; \
cd /app; \
rm -rf ui/litellm-dashboard/node_modules ui/litellm-dashboard/out; \
{ npm cache clean --force 2>/dev/null || true; }; \
test -f /app/litellm/proxy/_experimental/out/index.html || { echo "FATAL: copy did not land the bundle"; exit 1; }

# Preserved upstream hook: enterprise customizations can still override
# the bundle via the canonical build_admin_ui.sh path. Default is no-op.
Expand Down