fix(ui/navbar): strip upstream version-tag decorations - #15
Merged
Conversation
Removes three upstream UI flourishes that are noise for internal-fork
operators and produced visible glitches against our injected
`LITELLM_BUILD_TAG`:
- bouncing 🌑 emoji (and its companion `useDisableBouncingIcon`
per-browser localStorage toggle) — pure decoration, no signal value
- `<a href="docs.litellm.ai/release_notes">` wrapping the version Tag —
internal users have no reason to click their build number out to
upstream marketing docs
- `<Tooltip>` showing `Upstream base / Build sha` on hover — the same
info is one curl away at `/health/readiness`, and the tooltip
silently rendered empty when `buildSha` was missing (looks broken)
- hard-coded "v" prefix on the rendered version (`v{version}`) —
collides with the leading "v" we inject via `LITELLM_BUILD_TAG`,
producing `vv1.83.10-internal.4` in the navbar
The companion "Hide Bouncing Icon" Switch in UserDropdown becomes a
dead control once the emoji is gone, so it goes too. `useDisableBouncingIcon.ts`
is left on disk (no remaining importers) — keeping it minimises rebase
churn against upstream and the dead file has zero runtime cost.
After this change the navbar shows a single static Tag rendering
whatever `/health/readiness` returns in `litellm_version` — i.e.
`v1.83.10-internal.4` on our builds, `1.83.10` on a vanilla local
run with no build tag injected.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up three upstream UI flourishes around the navbar version Tag that are noise for internal operators and one of which actively renders broken under our internal build pipeline.
Removed:
useDisableBouncingIconper-browser toggle (and the matching "Hide Bouncing Icon" Switch in UserDropdown that becomes a dead control)<a href="docs.litellm.ai/release_notes">link wrapping the version Tag — internal users have no reason to click their build number out to upstream marketing docs<Tooltip>showingUpstream base / Build shaon hover — same data is one curl away at/health/readiness, and the tooltip silently rendered empty whenbuildShawasn't injected (looked broken)"v"prefix on the rendered version. We injectLITELLM_BUILD_TAG=v1.83.10-internal.N(with the leadingv), sov{version}producedvv1.83.10-internal.4in the navbar — observed live onmaasllm.corp.anispark.aiAfter: a single static Tag rendering
litellm_versionverbatim —v1.83.10-internal.4on our builds,1.83.10on vanilla local runs withoutLITELLM_BUILD_TAG.The dead hook file
useDisableBouncingIcon.tsis intentionally left on disk — no remaining importers, zero runtime cost, and keeping it minimises rebase churn against upstream.Test plan
npm run devagainst e2e proxy on:4011— version Tag is plain, no emoji, no hover Tooltip, no click navigationv1.83.10-internal.N(singlev)