Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For propagation of red pixels, the current impl is actually using red pixels (supposed to be black) for the V-shaped comparison.
For e.g.
left_near
, let's assume center pixel is red.Current Impl -
int pointTemp = left_near - (1 + i) - i * width;
Here
left_near
is pixel on the left of center pixel, so it is black pixel.then for
i==0
,pointTemp
resolves toleft_near - 1
, which is again red, same as center pixel.This is fixed in this PR.
Now, for
i==0
,pointTemp
resolves toleft_near - 1 - width
, this is one pixel on diagonally up-left of left_near, which is what we want.