Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v shaped propagation #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix v shaped propagation #16

wants to merge 1 commit into from

Conversation

sanskar107
Copy link

For propagation of red pixels, the current impl is actually using red pixels (supposed to be black) for the V-shaped comparison.

For e.g. left_near, let's assume center pixel is red.
Current Impl - int pointTemp = left_near - (1 + i) - i * width;
Here left_near is pixel on the left of center pixel, so it is black pixel.
then for i==0, pointTemp resolves to left_near - 1, which is again red, same as center pixel.

This is fixed in this PR.
Now, for i==0, pointTemp resolves to left_near - 1 - width, this is one pixel on diagonally up-left of left_near, which is what we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant