proof(audit): retroactive truth-gate for PRs #136-#178 + PR-body conventions (W8-6) - #187
Merged
Ghenghis merged 2 commits intoMay 10, 2026
Conversation
Closes audit findings F-149-01 (P0), F-CI-EMPTY-01 (P1), F-CI-CRBOT-01 (P2). PR #149's recovery_controller.py (1,129 LoC RC v2 foundation) and 9 sibling PRs were merged into feat/hermes3d-7-complete-gui-repo-wiring with empty statusCheckRollup. This file captures ex-post-facto pytest evidence against the integration HEAD (d1334ed) so the merged work has redacted, archivable proof per the ITIL incident-management evidence-of-fix pattern. Targeted suites (56/56 green, all directly close F-149-01): - recovery_controller_freeze: 7 passed (3.34s) - agent_checkout + v012/v013 pins: 27 passed (3.47s) - canary_dirt_filter: 22 passed (0.13s) Wider unit scan: 1146 passed / 11 failed / 5 skipped (98.6% pass rate). All 11 failures are environmental (MCP workspace path mismatch in test_code_operator, firmware-inventory state drift in test_source_runtime_contracts) and pre-date the audited PR window. Verdict: PARTIAL - honest gap documented per the persistence rule. Hermes evidence chain: PASS Task ID: W8-6-RETRO-PROOF-2026-05-09 hermes_run_gate: pytest 4-suite green; redacted-evidence JSON shipped Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adopts two cosmetic-but-recurring PR-body conventions surfaced by W7-1's audit, so future reviewers don't have to guess file-vs-case counts or which branch a stacked PR was rebased onto. - Tests-added: write "N file(s), M cases - all green" (closes F-DRIFT-143-01). - Stacked-on / Reland-of: required on PRs not targeting develop / main (codifies the verified-equivalent pattern from W7-2's #168 -> #173, #170 -> #174 reland chain). Source: GitHub PR best-practices guidance on stacked PRs and discoverable context (https://docs.github.com/en/pull-requests). Hermes evidence chain: PASS Task ID: W8-6-RETRO-PROOF-2026-05-09 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Ghenghis
merged commit May 10, 2026
32b3a9e
into
feat/hermes3d-7-complete-gui-repo-wiring
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes 3 audit findings surfaced by W7-1 by capturing ex-post-facto pytest evidence against the integration HEAD, and codifies two PR-body conventions for future reviewers.
recovery_controller.py1,129 LoC RC v2 foundation) merged with emptystatusCheckRollup. Closed bytest_recovery_controller_freeze.py7/7 green.statusCheckRollup. Closed by wider unit scan (1146/1162 = 98.6% pass; remaining 11 are environmental, not regressions).Stacked-on:
feat/hermes3d-7-complete-gui-repo-wiringHermes evidence chain: PASS
W8-6-RETRO-PROOF-2026-05-0904_proof/AUD-W7-1-2026-05-09-CI-RETRO.json(10 KB, well under 50 KB cap)AUD-W7-1-RETRO-2026-05-09-d1334ed1d1334ed1a4d0e9243f4cd3686be1a19204e3cfa6Test plan
Targeted suites (56/56 cases - all green):
test_recovery_controller_freeze.py- 7 passed (3.34s) - directly closes F-149-01test_agent_checkout_resolver.py+test_v012_fallback_regression_pin.py+test_v013_default_regression_pin.py- 27 passed (3.47s) - cross-version pinstest_canary_dirt_filter.py- 22 passed (0.13s) - pins W6-1 work04_testing/pytest/unit/- 1146 passed / 11 failed / 5 skipped (274.90s)Tests added (1 file, 0 cases - evidence-only PR; the JSON is the test artifact, not a new pytest file).
Verdict: PARTIAL (honest gap documented)
Targeted suites are fully PASS; wider scan has 11 environmental failures (MCP workspace path mismatch in
test_code_operator, firmware-inventory state drift intest_source_runtime_contracts) that pre-date the audited PR window. Per the persistence rule, these are documented in the JSON'sremaining_followups_after_this_proofrather than silently skipped.Sources cited
Stacked-on:/Reland-of:tags and tests-added phrasing now inCONTRIBUTING.md.Commits
07eb207proof(audit): retroactive truth-gate for PRs fix(agent-updates): harden staged-update pytest gate (Audit PR #135 follow-up) #136-fix(W6-1): canary dirt filter + PR #175 cleanup #178 (W7-1 follow-up)9829186docs(contributing): PR-body conventions for tests-added + re-target tag🤖 Generated with Claude Code