fix(W8-8): firmware source-inventory probe regression (5 tests, surgical)

[Ghenghis]

Summary

• Restores kind="source_inventory" and path="" on the 6 BUILTIN_RUNTIME_PROBES firmware rows (firmware_klipper, marlin, prusa_firmware, reprapfirmware, repetier_firmware, smoothieware); these were silently flipped by PR feat(I7): firmware source inventory probes — read-only git describe, source_reference_only contract #120 to firmware_source_inventory/hardcoded absolute paths, causing _safe_runtime_probe to fall through and return status="blocked" for all 5 parametrized firmware tests.
• W7-3 hypothesised a PR chore(observability): expose 7 silent broad-except fallbacks (Wave Agent 7) #150 (broad-except) interaction; on read, PR chore(observability): expose 7 silent broad-except fallbacks (Wave Agent 7) #150 only edited _private_runtime_env and is innocent. PR chore(observability): expose 7 silent broad-except fallbacks (Wave Agent 7) #150's broad-except cleanup is intact — not reverted.
• Adds test_firmware_probe_returns_ready_when_files_exist_and_verifier_index_empty regression-pin in test_source_runtime_contracts.py. Inline comments on the BUILTIN entries mark kind/path as load-bearing for _runner_status mapping. PR feat(I7): firmware source inventory probes — read-only git describe, source_reference_only contract #120's new probe_firmware_source_inventory() function and FIRMWARE_SOURCE_PATHS registry are unchanged.

Test plan

• python -m pytest 04_testing/pytest/unit/test_source_runtime_contracts.py -k test_firmware_source_inventory — 5/5 PASS (was 0/5)
• python -m pytest 04_testing/pytest/unit/test_source_runtime_contracts.py -k firmware_probe_returns_ready — 1/1 PASS (new pin)
• python -m pytest 04_testing/pytest/unit/test_source_runtime_contracts.py 04_testing/pytest/unit/test_module_runtime.py 04_testing/pytest/unit/test_firmware_farm_probes.py — 166 PASS / 0 regressions

Hermes evidence chain: PASS
Task ID: H3D-CLAUDE-W8-8-FIRMWARE-PROBE
hermes_run_gate: tests.unit
Lock owner: claude-w8-8-firmware-probe
Hermes locks released after merge

Doc: 03_implementation/docs/handoffs/W8-8_FIRMWARE_PROBE_REGRESSION_2026-05-09.md

Sources

• PEP 8 Programming Recommendations (broad-except guidance): https://peps.python.org/pep-0008/#programming-recommendations
• PR chore(observability): expose 7 silent broad-except fallbacks (Wave Agent 7) #150 description (ba4194d): explicitly observability-only; "Zero behavior change"

🤖 Generated with Claude Code

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d49de885-1094-46ad-af4a-acedf3ba3cec

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/w8-8-firmware-probe-regression

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}