Repository navigation
proof(I14): no-fake sweep 2026-05-08 — 81 files, PASS - #116
Merged
Ghenghis merged 1 commit intoMay 9, 2026
Merged
Conversation
Active UI no-fake scan re-run on 2026-05-08: - 81 production files walked from App.tsx entry point - 0 findings (no mock/fake/simulated markers in string literals) - No data/mock imports in active graph - 15 orphaned/unwalked files separately verified clean - scan_active_ui_no_fake.py requires no changes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThis PR establishes and documents the universal data schemas, runtime/adapter contracts, strict agent/operator policy, end-to-end proof and readiness artifacts, new printer config/ignore rules, OS-wide roadmap and audit/merge inventory, and enforces no-fake, Playwright, and CI gates for Hermes3D OS. ChangesUniversal Data Contracts, Schemas, Config, and Artifacts
System and UX Contracts, Hard Safety/Agentic Requirements
Complete Roadmap, Index/Audit/Worktree Inventory, Baseline and Queue Artifacts
Integration, Audit, Merge, Gate CI, and Proof/Verification Docs
Sequence Diagram(s)sequenceDiagram
participant Dev
participant Schemas
participant Proofs
participant CI
participant Docs
participant Audit
Dev->>Schemas: Add/configure universal schemas
Dev->>Docs: Update contracts, roadmap, requirements
Schemas->>Proofs: Validate runtime and config artifacts
CI->>Docs: Run Playwright/no-fake/contract gates
CI->>Proofs: Generate/validate artifact JSONs
Audit->>Docs: Execute audits, readiness, and merge plans
Audit->>Proofs: Append audit evidence and proof bundles
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive set of updates to the Hermes3D OS, including new adapter schemas, extensive documentation for agentic automation, and a detailed roadmap for tab completion. The changes establish a professional safety layer for agent-led coding tasks, featuring file snapshots, MCP lock coordination, and proof-gated git workflows. Feedback focuses on improving the portability of the adapter schemas by removing user-specific or OS-specific hardcoded paths, ensuring consistent JSON Schema versions across the registry, and enhancing the maintainability of documentation by externalizing large inline SVG diagrams.
Comment on lines
+59
to
+67
| "executable_candidates": { | ||
| "type": "array", | ||
| "items": {"type": "string"}, | ||
| "default": [ | ||
| "C:/Users/Admin/AppData/Local/Programs/Ollama/ollama.exe", | ||
| "ollama", | ||
| "llama-cli", | ||
| "llama" | ||
| ] |
There was a problem hiding this comment.
The executable_candidates default value includes a hardcoded, user-specific path (C:/Users/Admin/...). This will fail on any other machine. Default paths in shared configuration should not be user-specific. It's better to rely on executables being in the system's PATH.
"executable_candidates": {
"type": "array",
"items": {"type": "string"},
"default": [
"ollama",
"llama-cli",
"llama"
]
},|
|
||
| Current CLI readiness proof: `03_implementation/proof/SOURCE_APP_CLI_AGENT_READINESS_AUDIT.json`, `/api/modules/runtime/agent-cli-readiness`, and `/api/modules/runtime/runner-contracts` classify all 60 rows. As of this pass, 7 apps are verified agent CLI and agent-executable (`hermes_agent`, `blender`, `openscad`, `curaengine`, `flsun_slicer`, `orcaslicer`, `prusaslicer`), 3 are launcher metadata only with executable-path smoke available (`printrun`, `bambustudio`, `cura`), 5 are package/import ready (`model_context_protocol`, `blender_mcp_candidates`, `manifold`, `meshlab`, `trimesh`), 3 are service/API ready, 18 are read-only source/reference ready, 2 have CLI install/config preflight available (`slic3r`, `superslicer`), 1 has npm package metadata preflight available (`azure_speech_sdk_js`), and 24 remain runner gaps or repair blockers needing a real CLI/API/import/service smoke before Hermes Agents can execute them. Strec3D and the firmware rows (`marlin`, `prusa_firmware`, `reprapfirmware`, `repetier_firmware`, `smoothieware`) are verified source-reference-only from local source inventory; they are not agent-executable and no local safe compile/flash/upload path is claimed. The Python/CAD repair queue is explicit: `cadquery`, `open3d`, `build123d`, `numpy_stl`, and `pymesh` have registered import verifiers but the backend runtime cannot import them yet. The legacy slicer CLI config queue is explicit: `slic3r` and `superslicer` can read local source, adapter schema, profile/config, and candidate executable metadata only, and remain blocked for real slicing until local CLIs pass `/runtime/verify`. The npm package metadata queue is explicit: `azure_speech_sdk_js` can read package.json, script names, lockfile/manifests, and node/npm path presence only, and remains blocked for real runtime use until a sandboxed npm runner and node package verifier pass. The service/web queue is explicit too: `fdm_monster`, `fluidd`, `mainsail`, `octofarm`, `octoprint`, `manyfold`, `open_filament_database`, `kirimoto_gridspace`, `comfyui`, and `comfyui_trellis_wrapper` have registered local/private HTTP health verifiers, but remain setup-required unless their configured `HERMES3D_SOURCE_*_URL` endpoints respond to non-mutating GET probes. Separate CLI-surface proof lives at `03_implementation/proof/SOURCE_APP_CLI_SURFACE_AUDIT.json`; it records 24 local CLI/service hints that are candidates only until a safe verifier and proof gate exist. | ||
|
|
||
| Generated no-forget action plan: `03_implementation/proof/SOURCE_APP_RUNTIME_ACTION_PLAN.md` lists every open runner gap, launcher-only row, and CLI/service signal that still needs a verifier. This file must be regenerated with `python 03_implementation\scripts\write_source_runtime_action_plan.py` after any Source OS runtime or verifier change. |
There was a problem hiding this comment.
There seems to be a typo in the path. It should likely be 03_implementation/scripts/write_source_runtime_action_plan.py instead of 03_implementation\scripts\write_source_runtime_action_plan.py to maintain consistency with the forward-slash path separators used elsewhere in the document.
Suggested change
| Generated no-forget action plan: `03_implementation/proof/SOURCE_APP_RUNTIME_ACTION_PLAN.md` lists every open runner gap, launcher-only row, and CLI/service signal that still needs a verifier. This file must be regenerated with `python 03_implementation\scripts\write_source_runtime_action_plan.py` after any Source OS runtime or verifier change. | |
| Generated no-forget action plan: `03_implementation/proof/SOURCE_APP_RUNTIME_ACTION_PLAN.md` lists every open runner gap, launcher-only row, and CLI/service signal that still needs a verifier. This file must be regenerated with `python 03_implementation/scripts/write_source_runtime_action_plan.py` after any Source OS runtime or verifier change. |
Comment on lines
+23
to
+29
| "executable_path": { | ||
| "type": [ | ||
| "string", | ||
| "null" | ||
| ], | ||
| "default": "C:/Program Files/Bambu Studio/bambu-studio.exe", | ||
| "description": "Bambu Studio Windows launcher path (boolean-presence check only; no launch)." |
There was a problem hiding this comment.
The executable_path property has a hardcoded Windows-specific path as its default value. This is not portable and will be incorrect on non-Windows systems. It's better to set the default to null and let the application logic determine the appropriate default path based on the operating system.
Suggested change
| "executable_path": { | |
| "type": [ | |
| "string", | |
| "null" | |
| ], | |
| "default": "C:/Program Files/Bambu Studio/bambu-studio.exe", | |
| "description": "Bambu Studio Windows launcher path (boolean-presence check only; no launch)." | |
| "executable_path": { | |
| "type": [ | |
| "string", | |
| "null" | |
| ], | |
| "default": null, | |
| "description": "Bambu Studio Windows launcher path (boolean-presence check only; no launch). Should be an absolute path." | |
| }, |
| @@ -0,0 +1,79 @@ | |||
| { | |||
| "$schema": "http://json-schema.org/draft-07/schema#", | |||
There was a problem hiding this comment.
The JSON Schema draft version used here (draft-07) is inconsistent with the version used in most other new schemas in this pull request (draft/2020-12). For consistency and to leverage newer features, it's recommended to update this to draft/2020-12.
Suggested change
| "$schema": "http://json-schema.org/draft-07/schema#", | |
| "$schema": "https://json-schema.org/draft/2020-12/schema", |
| @@ -0,0 +1,93 @@ | |||
| { | |||
| "$schema": "http://json-schema.org/draft-07/schema#", | |||
There was a problem hiding this comment.
The JSON Schema draft version used here (draft-07) is inconsistent with the version used in most other new schemas in this pull request (draft/2020-12). For consistency and to leverage newer features, it's recommended to update this to draft/2020-12.
Suggested change
| "$schema": "http://json-schema.org/draft-07/schema#", | |
| "$schema": "https://json-schema.org/draft/2020-12/schema", |
Comment on lines
+14
to
+94
| ```svg | ||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 900 540" width="900" height="540" font-family="Segoe UI, Arial, sans-serif" font-size="13"> | ||
| <rect x="0" y="0" width="900" height="540" fill="#0e1116"/> | ||
| <text x="450" y="28" fill="#fff" font-size="20" font-weight="bold" text-anchor="middle">Hermes3D OS — Folder Topology</text> | ||
| <text x="450" y="50" fill="#aaa" font-size="12" text-anchor="middle">G:\Github\ — 60 folders, 4-27 → 5-7</text> | ||
|
|
||
| <!-- Core ring --> | ||
| <rect x="350" y="80" width="200" height="60" rx="6" fill="#1f6feb" stroke="#388bfd"/> | ||
| <text x="450" y="105" fill="#fff" text-anchor="middle" font-weight="bold">Core repos (5)</text> | ||
| <text x="450" y="125" fill="#cde" text-anchor="middle" font-size="11">Hermes3D · h3d-gui-wiring-codex · Hermes3D-OS</text> | ||
|
|
||
| <!-- Agent infra ring --> | ||
| <rect x="50" y="170" width="200" height="60" rx="6" fill="#238636" stroke="#3fb950"/> | ||
| <text x="150" y="195" fill="#fff" text-anchor="middle" font-weight="bold">Agent infra (5)</text> | ||
| <text x="150" y="215" fill="#cfe" text-anchor="middle" font-size="11">hermes-agent · MCP-lock · bridge</text> | ||
|
|
||
| <!-- HP protocol --> | ||
| <rect x="270" y="170" width="160" height="60" rx="6" fill="#8957e5" stroke="#a371f7"/> | ||
| <text x="350" y="195" fill="#fff" text-anchor="middle" font-weight="bold">HP protocol (9)</text> | ||
| <text x="350" y="215" fill="#dce" text-anchor="middle" font-size="11">P0/P1 hardening · audit</text> | ||
|
|
||
| <!-- HermesProof --> | ||
| <rect x="450" y="170" width="160" height="60" rx="6" fill="#bf8700" stroke="#dba000"/> | ||
| <text x="530" y="195" fill="#fff" text-anchor="middle" font-weight="bold">HermesProof (6)</text> | ||
| <text x="530" y="215" fill="#fed" text-anchor="middle" font-size="11">truth-gate · queue · trigger</text> | ||
|
|
||
| <!-- Source OS registry --> | ||
| <rect x="630" y="170" width="220" height="60" rx="6" fill="#cf222e" stroke="#ff5050"/> | ||
| <text x="740" y="195" fill="#fff" text-anchor="middle" font-weight="bold">Source OS registry (60 apps)</text> | ||
| <text x="740" y="215" fill="#fcc" text-anchor="middle" font-size="11">slicers · modelers · firmware · 3D-gen</text> | ||
|
|
||
| <!-- Wire tasks --> | ||
| <rect x="50" y="280" width="180" height="60" rx="6" fill="#0e8090" stroke="#39c5cf"/> | ||
| <text x="140" y="305" fill="#fff" text-anchor="middle" font-weight="bold">UI wire tasks (18)</text> | ||
| <text x="140" y="325" fill="#ceefef" text-anchor="middle" font-size="11">single-button feature lanes</text> | ||
|
|
||
| <!-- Codex tasks --> | ||
| <rect x="250" y="280" width="180" height="60" rx="6" fill="#a371f7" stroke="#bc8cff"/> | ||
| <text x="340" y="305" fill="#fff" text-anchor="middle" font-weight="bold">Codex tasks (5)</text> | ||
| <text x="340" y="325" fill="#e9def8" text-anchor="middle" font-size="11">app integration lanes</text> | ||
|
|
||
| <!-- Merge PRs --> | ||
| <rect x="450" y="280" width="160" height="60" rx="6" fill="#fb8500" stroke="#ffa730"/> | ||
| <text x="530" y="305" fill="#fff" text-anchor="middle" font-weight="bold">Merge PRs (4)</text> | ||
| <text x="530" y="325" fill="#ffe6cc" text-anchor="middle" font-size="11">cascade resolution worktrees</text> | ||
|
|
||
| <!-- h3d enhancements --> | ||
| <rect x="630" y="280" width="220" height="60" rx="6" fill="#6e7681" stroke="#8b949e"/> | ||
| <text x="740" y="305" fill="#fff" text-anchor="middle" font-weight="bold">h3d enhancements (7)</text> | ||
| <text x="740" y="325" fill="#dee" text-anchor="middle" font-size="11">routing · safety · stream · docs</text> | ||
|
|
||
| <!-- Worktree collections --> | ||
| <rect x="200" y="380" width="220" height="60" rx="6" fill="#347d39" stroke="#56d364"/> | ||
| <text x="310" y="405" fill="#fff" text-anchor="middle" font-weight="bold">Worktree collections (3)</text> | ||
| <text x="310" y="425" fill="#cfe" text-anchor="middle" font-size="11">_claude_ · _codex_ · _codex_audit_</text> | ||
|
|
||
| <!-- Apps vendored --> | ||
| <rect x="450" y="380" width="200" height="60" rx="6" fill="#bf8700" stroke="#dba000"/> | ||
| <text x="550" y="405" fill="#fff" text-anchor="middle" font-weight="bold">Apps vendored (7)</text> | ||
| <text x="550" y="425" fill="#fed" text-anchor="middle" font-size="11">Blender · slicers · Printrun · Hermes Desktop</text> | ||
|
|
||
| <!-- Research --> | ||
| <rect x="680" y="380" width="160" height="60" rx="6" fill="#0e8090" stroke="#39c5cf"/> | ||
| <text x="760" y="405" fill="#fff" text-anchor="middle" font-weight="bold">Research (1)</text> | ||
| <text x="760" y="425" fill="#ceefef" text-anchor="middle" font-size="11">_research scratchpad</text> | ||
|
|
||
| <!-- Lines from core to all --> | ||
| <line x1="450" y1="140" x2="150" y2="170" stroke="#888" stroke-width="1" opacity="0.5"/> | ||
| <line x1="450" y1="140" x2="350" y2="170" stroke="#888" stroke-width="1" opacity="0.5"/> | ||
| <line x1="450" y1="140" x2="530" y2="170" stroke="#888" stroke-width="1" opacity="0.5"/> | ||
| <line x1="450" y1="140" x2="740" y2="170" stroke="#888" stroke-width="1" opacity="0.5"/> | ||
| <line x1="450" y1="140" x2="140" y2="280" stroke="#888" stroke-width="1" opacity="0.3"/> | ||
| <line x1="450" y1="140" x2="340" y2="280" stroke="#888" stroke-width="1" opacity="0.3"/> | ||
| <line x1="450" y1="140" x2="530" y2="280" stroke="#888" stroke-width="1" opacity="0.3"/> | ||
| <line x1="450" y1="140" x2="740" y2="280" stroke="#888" stroke-width="1" opacity="0.3"/> | ||
|
|
||
| <!-- Footer --> | ||
| <text x="450" y="500" fill="#aaa" font-size="11" text-anchor="middle">12 categories · 83 markdowns · ~1.08 GB vendored apps · 60-app registry · 49 worktrees</text> | ||
| <text x="450" y="520" fill="#666" font-size="10" text-anchor="middle">Excluded: kilocode-Azure2, contract-kit-v17* (2x), TRELLIS.2, Agentic-Modeler, _repo_rescue_evidence — see 02_EXCLUSIONS.md</text> | ||
| </svg> | ||
| ``` |
There was a problem hiding this comment.
This markdown file contains a large, inline SVG diagram. While this renders correctly on GitHub, it makes the raw markdown file very difficult to read and maintain. Large, complex XML blocks inside markdown can hinder readability and version control diffs.
Consider moving the SVG content to a separate .svg file in an assets or images directory and referencing it with a standard markdown image tag: . This keeps the markdown clean and makes both the text and the image easier to manage.
This suggestion applies to all new markdown files in this PR that contain large inline SVGs.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Note
Due to the large number of review comments, Critical severity comments were prioritized as inline comments.
🟠 Major comments (21)
03_implementation/adapter_registry/schemas/trimesh_worker.schema.json-7-9 (1)
7-9:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRequire actionable verification metadata when the worker is enabled.
Line 7 currently requires only
enabled, so{ "enabled": true }passes without anyverifypayload. Also, Line 63 and Line 75 allow empty{}for requiredinstall_checkandruntime_check, which weakens the probe contract.Suggested schema hardening
{ "$schema": "https://json-schema.org/draft/2020-12/schema", @@ "required": [ "enabled" ], + "allOf": [ + { + "if": { + "properties": { "enabled": { "const": true } }, + "required": ["enabled"] + }, + "then": { + "required": ["verify"] + } + } + ], "properties": { @@ "install_check": { "type": "object", "additionalProperties": false, + "required": ["import_must_succeed"], "properties": { "import_must_succeed": {"type": "boolean", "default": true}, @@ "runtime_check": { "type": "object", "additionalProperties": false, + "required": ["smoke_expression"], "properties": { "smoke_expression": {Also applies to: 44-49, 63-84
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/trimesh_worker.schema.json` around lines 7 - 9, The schema currently only requires "enabled" so a payload like { "enabled": true } is accepted; update the schema so that when "enabled" is true the object must include actionable verification metadata: add a conditional/if-then that when "enabled" is true requires a "verify" object containing non-empty "install_check" and "runtime_check" objects (or arrays) and tighten their subschemas so they have required fields (e.g., "type", "command" or "probe") instead of allowing empty {}. Locate and modify the entries referencing "enabled", "verify", "install_check", and "runtime_check" (and the sections around lines 44-49 and 63-84) to implement the if/then requirement and to replace permissive {} schemas with explicit required properties.03_implementation/adapter_registry/schemas/orca_slicer_bridge.schema.json-7-43 (1)
7-43:⚠️ Potential issue | 🟠 Major | ⚡ Quick winEnforce usable config when
enabledistrueRight now,
enabled: trueis valid even if bothendpointandexecutable_patharenull. That allows a “turned on but unusable” adapter config through schema validation.Suggested schema constraint
"required": [ "enabled" ], + "allOf": [ + { + "if": { + "properties": { + "enabled": { "const": true } + }, + "required": ["enabled"] + }, + "then": { + "anyOf": [ + { "required": ["endpoint"] }, + { "required": ["executable_path"] } + ] + } + } + ], "properties": {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/orca_slicer_bridge.schema.json` around lines 7 - 43, Add a conditional JSON Schema rule so that when "enabled" is true the config must supply a usable endpoint or executable path: add an "if" checking enabled === true and a "then" that enforces an "anyOf" requiring either "endpoint" or "executable_path" (and ensure those properties are not null / are strings) so the schema rejects configs that are enabled but have both endpoint and executable_path null; reference the existing "enabled", "endpoint", and "executable_path" properties when adding this conditional.03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/hp-protocol/hp-p0-hermes-agent-hardening.md-29-40 (1)
29-40:⚠️ Potential issue | 🟠 MajorCorrect the file paths or clarify the intended state — most referenced files and directories do not exist.
Verification found that 17 of the 18 files and directories listed in lines 29-40 do not exist in the repository:
Missing files:
- FINAL_EVIDENCE_REPORT.md
- PROOF/latest.json, PROOF/latest.json.cosign.bundle, PROOF/sbom.json
- PROOF_E2E_REPORT.md, PROOF_LOCAL_TEST.md, PROOF_SANDBOX_TEST.md
- Missing-Features.md
- hermesproof_claude20_codex_handoff_master_prompt.md
- handoffs/HANDOFF_TO_CODEX_CP-HERMESPROOF-0.4.md (and 0.4.1, 0.5)
- docs/ACCEPTANCE_GATES.md
- docs/ADR-016-hermes-agent-as-anonymous-user.md, ADR-019-anonymous-orchestration-v0.7.md
Missing directories:
- policies/
- src/
Only README.md and scripts/ were found. Since this document serves as an audit trail documenting the state of the main branch, inaccurate file references undermine its reliability. Either correct the paths to point to files that exist, or clarify if this describes a planned/intended state rather than the current state.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/hp-protocol/hp-p0-hermes-agent-hardening.md` around lines 29 - 40, The file list in the Key files / artifacts section incorrectly references many files and directories that don't exist (e.g., FINAL_EVIDENCE_REPORT.md, PROOF/latest.json and its cosign bundle, PROOF/sbom.json, PROOF_E2E_REPORT.md, Missing-Features.md, hermesproof_claude20_codex_handoff_master_prompt.md, handoffs/HANDOFF_TO_CODEX_CP-HERMESPROOF-0.4.md, docs/ACCEPTANCE_GATES.md, docs/ADR-016-hermes-agent-as-anonymous-user.md, docs/ADR-019-anonymous-orchestration-v0.7.md, policies/, src/) while only README.md and scripts/ exist; update the section to either (A) replace each missing entry with the correct existing file paths/names if they were renamed or moved, or (B) add a clear note that the list describes a planned/intended state (not the current main branch) and mark which items are intentionally absent; edit the Keys list lines (the entries for FINAL_EVIDENCE_REPORT.md, PROOF/*, PROOF_E2E_REPORT.md, Missing-Features.md, hermesproof_claude20_codex_handoff_master_prompt.md, handoffs/*, docs/*, policies/, src/) and the README.md/scripts/ entries accordingly so the document accurately reflects repository state.03_implementation/adapter_registry/schemas/moonraker_api.schema.json-54-58 (1)
54-58:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd a lower bound for request timeout.
timeout_secondscurrently allows0and negative values, which can cause immediate failures or undefined behavior in HTTP clients.Proposed fix
"timeout_seconds": { "type": "number", "default": 2.0, + "exclusiveMinimum": 0, "maximum": 10.0, "description": "HTTP request timeout" }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/moonraker_api.schema.json` around lines 54 - 58, The schema property "timeout_seconds" allows zero and negative values; add a lower bound by adding a "minimum" constraint (e.g., "minimum": 0.1) to the "timeout_seconds" schema entry and update its "description" to mention the enforced positive lower bound so HTTP clients cannot be given non-positive timeouts.03_implementation/adapter_registry/schemas/klipper_service.schema.json-23-27 (1)
23-27:⚠️ Potential issue | 🟠 Major | ⚡ Quick winEnforce OS/probe-method invariants in-schema (currently only documented).
The
probe_methoddescription states Windows should usenot_applicableand Linux should usesystemctl_statusormoonraker_proxy, but the schema does not enforce these constraints. Invalid combinations likewin32+systemctl_statusare currently accepted.Add conditional constraints using JSON Schema
allOfwithif/thento enforce the documented OS-to-probe-method mapping:Proposed fix
"required": ["adapter", "version", "policy", "platform"], + "allOf": [ + { + "if": { + "properties": { + "platform": { + "properties": { "os": { "const": "win32" } }, + "required": ["os"] + } + } + }, + "then": { + "properties": { + "policy": { + "properties": { "probe_method": { "const": "not_applicable" } }, + "required": ["probe_method"] + } + } + } + }, + { + "if": { + "properties": { + "platform": { + "properties": { "os": { "const": "linux" } }, + "required": ["os"] + } + } + }, + "then": { + "properties": { + "policy": { + "properties": { + "probe_method": { "enum": ["systemctl_status", "moonraker_proxy"] } + }, + "required": ["probe_method"] + } + } + } + } + ], "additionalProperties": falseAlso applies to: 32-53
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/klipper_service.schema.json` around lines 23 - 27, The schema currently documents OS-to-probe_method rules but does not enforce them; add JSON Schema conditional constraints using allOf with if/then clauses that inspect the "os" property and constrain "probe_method": e.g., add an if where properties.os.const == "win32" then require probe_method.const == "not_applicable", and add another if where properties.os is one of the Linux values (e.g., "linux", "linux-arm", whatever your schema uses) then require probe_method.enum to be limited to ["systemctl_status","moonraker_proxy"]; place these if/then entries in the root object schema (alongside existing properties) so "os" and "probe_method" are validated together (target symbols: probe_method, os in klipper_service.schema.json).03_implementation/adapter_registry/schemas/moonraker_api.schema.json-72-87 (1)
72-87:⚠️ Potential issue | 🟠 Major | ⚡ Quick win
response_rootschema type conflicts with its own example.
response_rootis constrained to"string"type, but the documented examples includenullas a valid value (last example at line 86). This creates a schema validation conflict that will reject a documented configuration shape.Proposed fix
- "response_root": { - "type": "string", - "description": "Top-level JSON key in Moonraker response containing the data (usually 'result')" - } + "response_root": { + "type": ["string", "null"], + "description": "Top-level JSON key in Moonraker response containing the data (usually 'result'); null when response has no wrapped root" + }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/moonraker_api.schema.json` around lines 72 - 87, The schema's response_root property is declared as type "string" but the examples include null; update the response_root definition to accept nulls (e.g., change "type": "string" to "type": ["string", "null"] or add "nullable": true depending on schema draft) so the example { "path": "/api/version", ..., "response_root": null } validates; adjust the response_root entry in the schema near the existing description to use the nullable-compatible type.03_implementation/adapter_registry/schemas/local_modeling_llm.schema.json-7-9 (1)
7-9:⚠️ Potential issue | 🟠 Major | ⚡ Quick winMake
verifymandatory at the top level.Right now a config with only
enabledpasses schema validation, which allows adapter entries with no real verification contract.Suggested diff
"required": [ - "enabled" + "enabled", + "verify" ],Also applies to: 44-48
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/local_modeling_llm.schema.json` around lines 7 - 9, The top-level schema's "required" array currently only lists "enabled", allowing configs without a "verify" contract; update the schema in local_modeling_llm.schema.json to include "verify" in the top-level "required" array so that "verify" is mandatory, and apply the same change to the other "required" arrays in this file (the other places that currently only list "enabled") to ensure every adapter entry must include "verify".03_implementation/adapter_registry/schemas/local_modeling_llm.schema.json-75-95 (1)
75-95:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd
requiredarrays to nestedinstall_checkandruntime_checkobjects.In Draft 2020-12,
defaultis metadata and validators do not apply defaults during parsing. These objects currently accept{}, leaving downstream code vulnerable to KeyError when accessing nested properties liketimeout_sorhelp_argswithout checking existence first. Add:Schema fix
"install_check": { "type": "object", "additionalProperties": false, "required": ["executable_or_import_required", "required_capabilities"], "properties": { ... } }, "runtime_check": { "type": "object", "additionalProperties": false, "required": ["help_args", "expected_help_substring", "timeout_s"], "properties": { ... } }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/local_modeling_llm.schema.json` around lines 75 - 95, The nested objects install_check and runtime_check in local_modeling_llm.schema.json lack "required" arrays so defaults are not enforced at validation time; update the schema to add required: ["executable_or_import_required","required_capabilities"] to the install_check object and required: ["help_args","expected_help_substring","timeout_s"] to the runtime_check object so validators will reject empty objects and downstream code accessing timeout_s, help_args, etc. won't get KeyError; keep existing properties and additionalProperties:false intact.03_implementation/adapter_registry/schemas/mainsail.schema.json-7-38 (1)
7-38:⚠️ Potential issue | 🟠 Major | ⚡ Quick winPrevent “enabled but unusable” configurations.
Right now, Line 8 only requires
enabled, so{ "enabled": true }passes even when all connection fields arenull. This allows invalid runtime states to pass schema validation.Suggested schema constraint
"properties": { "enabled": { "type": "boolean", "default": false }, @@ "timeout_ms": { "type": "integer", "minimum": 100, "default": 5000 } - } + }, + "allOf": [ + { + "if": { + "properties": { + "enabled": { "const": true } + }, + "required": ["enabled"] + }, + "then": { + "anyOf": [ + { "required": ["endpoint"] }, + { "required": ["executable_path"] } + ] + } + } + ] }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/mainsail.schema.json` around lines 7 - 38, The schema currently only requires "enabled" in mainsail.schema.json so {"enabled": true} passes even when "endpoint", "executable_path", and "config_path" are null; add a conditional rule so when "enabled" is true the schema enforces that at least one connection field is a non-null string: use an "if" testing properties.enabled const true and a "then" with an "anyOf" that requires a non-null string for "endpoint" or "executable_path" or "config_path" (e.g., each branch in the anyOf declares the property with "type":"string" and "required" for that property) to prevent enabled-but-unusable configurations.03_implementation/docs/handoffs/claude-final-audit-2026-05-06/00_EXECUTIVE_TAKEOVER_SUMMARY.md-94-110 (1)
94-110:⚠️ Potential issue | 🟠 Major | ⚡ Quick winFix invalid multi-PR
gh pr mergeusage.Lines 94 and 110 pass multiple PR numbers to a single
gh pr mergeinvocation, but the GitHub CLIgh pr mergecommand accepts only one PR selector per call:[<number> | <url> | <branch>]. The sequences will fail during execution.Use a loop to merge each PR individually:
Suggested fix
- gh pr merge 53 54 55 56 57 58 59 60 61 62 63 65 67 68 70 --squash + for pr in 53 54 55 56 57 58 59 60 61 62 63 65 67 68 70; do + gh pr merge "$pr" --squash + done- gh pr merge 74 75 76 77 78 79 --squash + for pr in 74 75 76 77 78 79; do + gh pr merge "$pr" --squash + done🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/docs/handoffs/claude-final-audit-2026-05-06/00_EXECUTIVE_TAKEOVER_SUMMARY.md` around lines 94 - 110, The gh pr merge invocations that pass multiple PR numbers (e.g., the lines containing "gh pr merge 53 54 55..." and "gh pr merge 74 75 76...") are invalid because gh pr merge accepts a single PR selector; change them to invoke gh pr merge once per PR (either by expanding into separate single-PR commands or by using a loop that iterates over the PR numbers and calls "gh pr merge <number>" for each). Ensure the other merge lines (e.g., "gh pr merge 66", "gh pr merge 64", "gh pr merge 71", "gh pr merge 72") remain as single-PR calls and retain the --squash flag for each individual invocation.03_implementation/proof/GEN3D_VERIFY_2026-05-06.json-7-11 (1)
7-11:⚠️ Potential issue | 🟠 Major | 🏗️ Heavy liftRedact host-specific absolute paths in committed proof artifacts
This artifact persists machine-local paths (interpreter + resolved home directories). That leaks environment identifiers and creates avoidable diff churn in repo proofs. Prefer sanitized placeholders or relative/normalized values in committed outputs.
Also applies to: 52-64
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/proof/GEN3D_VERIFY_2026-05-06.json` around lines 7 - 11, The committed JSON contains machine-specific absolute paths in the "pip_command" array (and similar fields around the same section) which should be redacted; replace the concrete interpreter path ("C:\\Python314\\python.exe") and any resolved home directory fragments with sanitized placeholders or normalized relative values (e.g., "<PYTHON_EXECUTABLE>" or "python -m pip") and ensure the generator that emits this artifact normalizes entries in the pip_command, resolved_home, and related fields before writing the proof to disk so future commits do not include host-specific paths.03_implementation/adapter_registry/schemas/curaengine.schema.json-30-35 (1)
30-35:⚠️ Potential issue | 🟠 Major | ⚡ Quick winEnforce help-only probe args in schema (policy gap)
safe_probe_argscurrently validates any string array, which permits unsafe values (includingslice) despite the schema and field descriptions restricting tohelponly. Lock this field down in-schema.Suggested schema hardening
"safe_probe_args": { "type": "array", - "items": {"type": "string"}, + "items": { "type": "string", "enum": ["help"] }, + "minItems": 1, + "maxItems": 1, "default": ["help"], "description": "Arguments used for the read-only version probe. Never include 'slice'." }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/curaengine.schema.json` around lines 30 - 35, The safe_probe_args JSON schema currently allows any string; change the "safe_probe_args" definition to enforce exactly one item equal to "help" by replacing its "items" with an enum constraint and adding "minItems": 1 and "maxItems": 1 (or use a single-item tuple) so only ["help"] is valid, keep the "default": ["help"] and the description unchanged; update the schema entry named "safe_probe_args" accordingly.03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/h3dos-codex-tasks/h3dos-codex-octoprint.md-19-19 (1)
19-19:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRemove the committed API key literal from documentation.
Line 19 documents a concrete API key value; that normalizes hardcoded credential usage and increases leakage risk. Keep only the variable name and source-of-truth location.
🔧 Suggested doc change
-- **Smoke API key**: `OCTOPRINT_SMOKE_API_KEY = "hermes3d-octoprint-smoke-key"` (line 88, main.py) +- **Smoke API key**: `OCTOPRINT_SMOKE_API_KEY` (loaded from environment/secret store; no literal value committed)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/h3dos-codex-tasks/h3dos-codex-octoprint.md` at line 19, Remove the committed API key literal from the docs by replacing the concrete value with just the variable name and its source; specifically remove the string value for OCTOPRINT_SMOKE_API_KEY and instead document it as "OCTOPRINT_SMOKE_API_KEY — see main.py for source-of-truth" (or similar), ensuring the file h3dos-codex-octoprint.md no longer contains the hardcoded "hermes3d-octoprint-smoke-key".03_implementation/adapter_registry/schemas/toolchain_arm_none_eabi.schema.json-8-29 (1)
8-29:⚠️ Potential issue | 🟠 Major | ⚡ Quick winEnforce the no-flash invariants at validation time, not just in descriptions.
The schema currently allows
compile_onlyandno_flashto be omitted from instances (they are not in therequiredarray), andinstall_checkusesdefaultrather thanconst, making it overrideable. This means a descriptor can validate successfully while bypassing the intended safety guarantees against flashing.Add
compile_onlyandno_flashto therequiredarray, and changeinstall_checkandversion_patternfromdefaulttoconst:Suggested diff
- "required": ["name", "source_url", "install_check", "version_pattern"], + "required": ["name", "source_url", "install_check", "version_pattern", "compile_only", "no_flash"], "install_check": { "type": "string", - "default": "arm-none-eabi-gcc --version", + "const": "arm-none-eabi-gcc --version", "description": "Read-only version probe. NEVER a flash command (st-flash, dfu-util, openocd flashing are explicitly excluded)." }, "version_pattern": { "type": "string", - "default": "arm-none-eabi-gcc \\(.*\\) ([0-9]+\\.[0-9]+(?:\\.[0-9]+)?)", + "const": "arm-none-eabi-gcc \\(.*\\) ([0-9]+\\.[0-9]+(?:\\.[0-9]+)?)", "description": "Regex extracting the GCC version triple from --version output." },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/toolchain_arm_none_eabi.schema.json` around lines 8 - 29, Update the JSON schema so the no-flash invariants are enforced at validation: add "compile_only" and "no_flash" to the schema's "required" array and change the "install_check" and "version_pattern" property definitions from using "default" to using "const" (keeping their current string values) so instances cannot override them; ensure "name" remains const "arm_none_eabi_gcc" and the rest of the properties stay unchanged.03_implementation/adapter_registry/schemas/firmware_reprap.schema.json-8-27 (1)
8-27:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd
toolchain_requiredandno_flashto therequiredarray.These properties are policy-enforced constraints with
constvalues and should not be optional. This change should be applied consistently across all firmware schemas (klipper, marlin, prusa, reprap).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/firmware_reprap.schema.json` around lines 8 - 27, The schema currently omits "toolchain_required" and "no_flash" from the top-level "required" array; update the "required" array to include "toolchain_required" and "no_flash" so those const-enforced properties are mandatory (i.e., add "toolchain_required" and "no_flash" to the "required" list alongside "name", "source_url", "install_check", "version_pattern"); apply the same change to the other firmware schemas that define these const properties (klipper, marlin, prusa, reprap) to keep them consistent.03_implementation/adapter_registry/schemas/build123d_worker.schema.json-7-9 (1)
7-9:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRequire
verifyat top level to enforce the verification contract.Line 7 currently requires only
enabled, so a config withoutverifystill validates even though this schema definesverifyas the probe-metadata contract.Suggested fix
- "required": [ - "enabled" - ], + "required": [ + "enabled", + "verify" + ],Also applies to: 44-87
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/build123d_worker.schema.json` around lines 7 - 9, The schema's top-level "required" currently only lists "enabled", so configurations lacking the probe contract "verify" still validate; update the top-level "required" array to include "verify" (in addition to "enabled") so the probe-metadata contract is enforced, and make the same change for the other schema variant(s) referenced around the 44-87 block to ensure all top-level schemas require the "verify" property.03_implementation/adapter_registry/schemas/cadquery_worker.schema.json-7-9 (1)
7-9:⚠️ Potential issue | 🟠 Major | ⚡ Quick winMake
verifymandatory in top-levelrequired.Line 7 allows validation with only
enabled; this permits configs that skip verification metadata entirely.Suggested fix
- "required": [ - "enabled" - ], + "required": [ + "enabled", + "verify" + ],Also applies to: 44-87
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/cadquery_worker.schema.json` around lines 7 - 9, The schema's top-level "required" currently only lists "enabled", allowing configs that omit verification metadata; update the top-level "required" array to include "verify" so "verify" becomes mandatory, and similarly add "verify" to any other "required" arrays in the schema sections referenced (around lines 44-87) where a nested object exposes a "verify" property; locate the top-level "required" array and any nested "required" arrays in the same JSON (look for "properties": { "verify": ... } and the sibling "required" arrays) and add "verify" to those arrays to enforce presence of verification metadata.03_implementation/docs/handoffs/claude-final-audit-2026-05-06/01_PR_MERGE_MATRIX.md-50-52 (1)
50-52:⚠️ Potential issue | 🟠 Major | ⚡ Quick winBatch
gh pr mergecommands are invalid syntax.
gh pr mergeaccepts only a single PR selector per invocation. Multiple PR numbers in a single command will fail and break the merge runbook. Use a loop instead.Suggested patch
- gh pr merge 53 54 55 56 57 58 59 60 61 62 63 65 67 68 70 --squash + for pr in 53 54 55 56 57 58 59 60 61 62 63 65 67 68 70; do gh pr merge "$pr" --squash; doneAlso applies to: lines 105-107
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/docs/handoffs/claude-final-audit-2026-05-06/01_PR_MERGE_MATRIX.md` around lines 50 - 52, The batch gh pr merge command shown (e.g., "gh pr merge 53 54 55... --squash") is invalid because gh accepts one PR selector per invocation; replace the single multi-PR invocation with a loop that iterates over each PR number and calls gh pr merge for each (preserving flags like --squash), e.g., iterate over your PR list variable and invoke gh pr merge "$pr" --squash for each entry; update both occurrences of the faulty command (the one shown and the similar instance later) to use this per-PR loop approach so merges run reliably.03_implementation/docs/handoffs/claude-e2e-intelligence-2026-05-08/06_ENV_KEYS_AND_RUNTIME_CONFIG_MAP.md-17-18 (1)
17-18:⚠️ Potential issue | 🟠 Major | ⚡ Quick winPolicy contradiction: private-env values are being echoed.
Line 17 says values are never read/echoed, but Lines 80–86 publish resolved path values from private env. Keep this artifact at key-name/presence/redacted-source level only, otherwise the stated secret-handling contract is not true.
Proposed edit pattern
-| `HERMES3D_OPENCODE_BIN` | path | live API | present | private env (per `path_source: private_env:HERMES3D_OPENCODE_BIN`) | Resolves to `G:\Github\opencode-dev\packages\opencode\dist\opencode-windows-x64\bin\opencode.exe` | +| `HERMES3D_OPENCODE_BIN` | path | live API | present | private env (`path_source: private_env:HERMES3D_OPENCODE_BIN`) | value redacted; presence verified |Also applies to: 80-86
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/docs/handoffs/claude-e2e-intelligence-2026-05-08/06_ENV_KEYS_AND_RUNTIME_CONFIG_MAP.md` around lines 17 - 18, The markdown currently contradicts its secret-handling contract by emitting private env values (the `G:/private/.env` resolved path) instead of only key NAMES/presence and the derived booleans; remove any place that prints the resolved private-env path or value and replace it with a redacted/source-only representation (e.g., show key name, presence, and the `*_configured` boolean), ensuring any template/variable like resolvedPath/privateEnvPath is not rendered and the output only reports key-name/presence/redacted-source.03_implementation/adapter_registry/schemas/meshlab_bridge.schema.json-7-9 (1)
7-9:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd
verifyto top-level required fields and make nested checks explicit.The schema currently allows configs to be valid without
verify, and permits emptyinstall_checkandruntime_checkobjects. This weakens the config contract. While the verifier script (scripts/verify_modelers.py) uses hardcoded probe parameters rather than reading from the schema, strengthening the schema ensures config structure matches its intended use.Proposed schema hardening
"required": [ - "enabled" + "enabled", + "verify" ], @@ "install_check": { "type": "object", "additionalProperties": false, + "required": ["executable_or_import_required", "required_capabilities"], "properties": { "executable_or_import_required": {"type": "boolean", "default": true}, "required_capabilities": { @@ "runtime_check": { "type": "object", "additionalProperties": false, + "required": ["smoke_expression", "help_args", "expected_help_substring", "timeout_s"], "properties": { "smoke_expression": {Also applies to: 44-99
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/meshlab_bridge.schema.json` around lines 7 - 9, Add "verify" to the top-level "required" array so configs must include the verify block, and make the verify sub-schema explicit by requiring both "install_check" and "runtime_check" inside the "verify" object; then tighten each check object to require their probe fields (e.g., require "type" and "command" or the equivalent probe identifiers used elsewhere) instead of allowing empty objects. Update the meshlab_bridge.schema.json verify schema (and the same pattern in the other affected schema blocks) so the "verify" object and its "install_check"/"runtime_check" children are non-empty and enforce the probe properties used by scripts/verify_modelers.py.03_implementation/adapter_registry/schemas/printer_connection.schema.json-23-39 (1)
23-39:⚠️ Potential issue | 🟠 Major | ⚡ Quick winTighten endpoint validation for
ipandmoonraker_urlfields.The
ipfield (line 23) andmoonraker_urlfield (line 33) currently accept any non-empty string without validating their actual shape. Invalid endpoints pass schema validation but fail at runtime.Proposed fix
"ip": { "type": "string", - "minLength": 1 + "minLength": 1, + "oneOf": [ + { "format": "ipv4" }, + { "format": "ipv6" }, + { + "pattern": "^(?=.{1,253}$)(?!-)[A-Za-z0-9-]{1,63}(?<!-)(\\.(?!-)[A-Za-z0-9-]{1,63}(?<!-))*$" + } + ] }, @@ "moonraker_url": { - "type": [ - "string", - "null" - ], + "oneOf": [ + { "type": "null" }, + { "type": "string", "pattern": "^https?://.+" } + ], "default": null },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/printer_connection.schema.json` around lines 23 - 39, The ip and moonraker_url fields accept any non-empty string; tighten their JSON Schema definitions by replacing the loose string/minLength rule for "ip" with a oneOf that enforces valid endpoint shapes (e.g., add schemas for {"format":"ipv4"}, {"format":"ipv6"} and/or a {"pattern":"<hostname regex>"} alternative) so only valid IPs/hostnames pass, and change "moonraker_url" from type ["string","null"] to a oneOf that allows null or a string with {"format":"uri"} (or {"format":"uri-reference"} if relative URLs are permitted); use JSON Schema keywords oneOf/format/pattern to implement these changes for the "ip" and "moonraker_url" properties.
🧹 Nitpick comments (14)
03_implementation/adapter_registry/schemas/orca_slicer_bridge.schema.json (1)
15-37: ⚡ Quick winDisallow empty strings for endpoint/path fields
endpoint,executable_path, andconfig_pathcurrently accept"". Empty strings are effectively invalid values and should be rejected by schema.Suggested hardening
"endpoint": { "type": [ "string", "null" ], + "minLength": 1, "default": null, "description": "Optional local or service endpoint URL." }, "executable_path": { "type": [ "string", "null" ], + "minLength": 1, "default": null, "description": "Optional absolute executable path." }, "config_path": { "type": [ "string", "null" ], + "minLength": 1, "default": null, "description": "Optional config or profile path." },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/orca_slicer_bridge.schema.json` around lines 15 - 37, The schema currently allows empty strings for the properties endpoint, executable_path, and config_path; update each property's type to permit null or non-empty string by replacing the current ["string","null"] with a union that enforces non-empty strings (e.g., use oneOf/anyOf entries: {"type":"null"} and {"type":"string","minLength":1} or {"type":"string","pattern":"^.+$"}) so empty "" is rejected while keeping null allowed for endpoint, executable_path, and config_path.03_implementation/adapter_registry/schemas/fdm_monster.schema.json (1)
39-43: ⚡ Quick winConsider adding a maximum bound to
timeout_ms.While the minimum of 100ms prevents unreasonably short timeouts, the absence of a maximum allows extremely large values that could cause indefinite waits or operational issues. Adding a reasonable upper bound (e.g., 60000ms for 1 minute or 300000ms for 5 minutes) would prevent accidental misconfiguration.
🛡️ Proposed addition of maximum constraint
"timeout_ms": { "type": "integer", "minimum": 100, + "maximum": 300000, "default": 5000 }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/fdm_monster.schema.json` around lines 39 - 43, The "timeout_ms" integer schema currently has a "minimum" and "default" but no upper bound; update the "timeout_ms" schema to include a "maximum" (e.g., 60000 for 1 minute or 300000 for 5 minutes) to prevent excessively large values and adjust the "default" if you prefer it to sit well within the new maximum; modify the "timeout_ms" object (the one with "type", "minimum", "default") to add the "maximum" property accordingly.03_implementation/adapter_registry/schemas/local_modeling_llm.schema.json (1)
51-57: ⚡ Quick winConstrain
kindandversion_probe.modeto matching combinations.The schema currently allows inconsistent pairs (e.g.,
kind: "cli"withmode: "python_import"). Add conditional rules to prevent invalid configs at validation time.Suggested diff
"runtime_check": { "type": "object", "additionalProperties": false, "properties": { "help_args": {"type": "array", "items": {"type": "string"}, "default": ["help"]}, "expected_help_substring": {"type": "string", "default": "Usage"}, "timeout_s": {"type": "integer", "minimum": 1, "maximum": 60, "default": 15} } } - } + }, + "allOf": [ + { + "if": { "properties": { "kind": { "const": "cli" } } }, + "then": { "properties": { "version_probe": { "properties": { "mode": { "const": "cli_args" } } } } } + }, + { + "if": { "properties": { "kind": { "const": "python_import" } } }, + "then": { "properties": { "version_probe": { "properties": { "mode": { "const": "python_import" } } } } } + } + ] }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/local_modeling_llm.schema.json` around lines 51 - 57, The schema allows mismatched values between the top-level "kind" and "version_probe.mode" (e.g., kind: "cli" with mode: "python_import"); add JSON Schema conditional constraints using "if"/"then" on the object root so that when "kind" == "cli" the "version_probe.mode" must equal "cli_args", and when "kind" == "python_import" the "version_probe.mode" must equal "python_import"; reference the existing properties "kind" and "version_probe" -> "mode" and implement two conditionals to reject inconsistent combinations during validation.03_implementation/adapter_registry/schemas/mainsail.schema.json (1)
15-22: ⚡ Quick winAdd
formatandminLengthtoendpointfield to document URL shape expectations.The endpoint description indicates a URL, but currently any string passes validation. Adding
format: "uri"andminLength: 1documents the expected shape and rejects empty strings.This follows the pattern used in other adapter schemas (firmware_klipper, toolchain_avr_gcc, llm_policy) which use
format: "uri"for URL fields. However, note that Python's jsonschema Draft202012Validator does not enforceformatkeywords by default—format validation only works if you explicitly enable it via FormatChecker or configure your validator withformat_checker=FormatChecker(). Since the codebase does not currently enforce format validation, theformatkeyword functions as documentation/schema intention rather than runtime validation. If strict URL validation is critical, combineformat: "uri"with apatternconstraint (as shown in llm_policy.schema.json).Also note: mainsail.schema.json is not currently included in the test suite's validated schemas (test_config_schemas.py covers 9 adapter categories but mainsail/fluidd exist as separate schemas).
Suggested update
"endpoint": { "type": [ "string", "null" ], + "format": "uri", + "minLength": 1, "default": null, "description": "Optional local or service endpoint URL." },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/mainsail.schema.json` around lines 15 - 22, The endpoint property in mainsail.schema.json currently allows any string; update the "endpoint" schema (the "endpoint" field) to include "format": "uri" and "minLength": 1 to document URL expectations and reject empty strings; if you need strict runtime URL validation beyond documentation, also add an appropriate "pattern" or ensure validators use a FormatChecker/format_checker when validating (note mainsail.schema.json is not currently covered by test_config_schemas.py so consider adding it to schema validation tests if needed).03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/h3d-enhancements/h3d-routing.md (1)
38-73: 💤 Low valueGood accessibility baseline; consider adding title element.
The SVG already includes
aria-label, which is excellent. For enhanced accessibility, consider also adding a<title>element as the first child of the<svg>.♿ Optional enhancement
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 450 250" width="450" height="250" role="img" aria-label="h3d-routing change footprint"> + <title>h3d-routing change footprint</title> <style>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/h3d-enhancements/h3d-routing.md` around lines 38 - 73, Add a <title> element inside the <svg> (as the first child) to mirror the existing aria-label for improved accessibility; update the SVG root in the h3d-routing.svg snippet (the <svg ... aria-label="h3d-routing change footprint"> element) to include a <title> with the same descriptive text (or a unique id and aria-labelledby pointing to that id) so screen readers can reliably announce the graphic.03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/h3dos-wire-tasks/h3dos-wire-jobs-search-filter.md (1)
29-51: ⚡ Quick winEnhance SVG accessibility.
Add accessibility attributes to make the diagram accessible to screen readers.
♿ Proposed accessibility enhancement
-<svg xmlns="http://www.w3.org/2000/svg" width="400" height="250" viewBox="0 0 400 250"> +<svg xmlns="http://www.w3.org/2000/svg" width="400" height="250" viewBox="0 0 400 250" role="img" aria-label="Jobs search filter flow"> + <title>Jobs search filter flow</title> <rect width="400" height="250" fill="#0e1116"/>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/h3dos-wire-tasks/h3dos-wire-jobs-search-filter.md` around lines 29 - 51, The SVG lacks accessible metadata for screen readers; add a <title> and <desc> and reference them from the <svg> via aria-labelledby (e.g., create ids like title-h3dos and desc-h3dos and set aria-labelledby="title-h3dos desc-h3dos"), set role="img" and focusable="false" on the <svg>, ensure decorative elements (e.g., purely visual <defs> markers or stroke-only <rect> accents) are marked aria-hidden="true" or omitted from the accessibility tree, and include a lang attribute if needed so screen readers can present the diagram correctly; update the <svg>, <defs>, and any top-level shapes (rect/text) accordingly (use the existing <svg>, <defs>, and marker elements as anchors for these changes).03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/hp-protocol/hp-p1-docs.md (1)
39-62: ⚡ Quick winEnhance SVG accessibility.
The diagram should include accessibility attributes for screen readers.
♿ Proposed accessibility enhancement
-<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 500 300" width="500" height="300"> +<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 500 300" width="500" height="300" role="img" aria-label="P1 count-drift sync flow"> + <title>P1 count-drift sync flow</title> <rect width="500" height="300" fill="#0b0f1a"/>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/hp-protocol/hp-p1-docs.md` around lines 39 - 62, Add accessible names and descriptions to the SVG by adding a unique <title> and <desc> elements (e.g., title id="hp-p1-title" and desc id="hp-p1-desc") and then reference them from the <svg> with aria-labelledby="hp-p1-title" and aria-describedby="hp-p1-desc"; also set role="img" and focusable="false" on the <svg> to ensure it is announced correctly by screen readers and skipped from keyboard focus.03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/h3dos-wire-tasks/h3dos-wire-observe-camera-tile-click.md (1)
17-46: ⚡ Quick winEnhance SVG accessibility.
Add accessibility attributes to make the diagram accessible to screen readers.
♿ Proposed accessibility enhancement
-<svg xmlns="http://www.w3.org/2000/svg" width="400" height="250" viewBox="0 0 400 250"> +<svg xmlns="http://www.w3.org/2000/svg" width="400" height="250" viewBox="0 0 400 250" role="img" aria-label="Camera tile click wiring flow"> + <title>Camera tile click wiring flow</title> <style>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/h3dos-wire-tasks/h3dos-wire-observe-camera-tile-click.md` around lines 17 - 46, The SVG lacks accessibility metadata for screen readers; add a <title> and <desc> inside the <svg> and set role="img" and aria-labelledby referencing them (and focusable="false" for non-interactive SVGs), wrap related visuals in <g> groups with aria-labels for the "camera tile" (.camera-card), "ActionWindow", and the API/Response blocks, and mark purely decorative elements (stylistic rects/paths) aria-hidden="true"; ensure text content (e.g., "camera tile", "ActionWindow", "POST /api/observe/mute/{id}", "GET /api/observe/stream/{id}", "Response shape") is either present as visible <text> or repeated in the group aria-label/desc so screen readers convey the same information.03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/h3dos-wire-tasks/h3dos-wire-global-event-bus-logger.md (1)
15-41: ⚡ Quick winEnhance SVG accessibility.
The SVG diagram lacks accessibility attributes. Adding a
role,aria-label, and descriptive<title>element would make the diagram accessible to screen readers.♿ Proposed accessibility enhancement
-<svg xmlns="http://www.w3.org/2000/svg" width="400" height="250" viewBox="0 0 400 250"> +<svg xmlns="http://www.w3.org/2000/svg" width="400" height="250" viewBox="0 0 400 250" role="img" aria-label="Global event bus logger flow diagram"> + <title>Global event bus logger flow diagram</title> <style>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/h3dos-wire-tasks/h3dos-wire-global-event-bus-logger.md` around lines 15 - 41, The SVG is missing accessibility metadata; add a descriptive <title> element and optional <desc>, then update the root <svg> to include role="img" and aria-labelledby referencing the title's id (or aria-label directly if you prefer); ensure the <title> text briefly describes the diagram (e.g., "Global event bus logger flow: debug URL enables listener → document.addEventListener actionwindow:render → console.group payload; passive devtools tap shows tab_id, item_id, status_pill, actions") so screen readers can announce the diagram.03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/merge-prs/merge-pr33.md (1)
50-72: ⚡ Quick winEnhance SVG accessibility.
The SVG diagram lacks accessibility attributes for screen readers.
♿ Proposed accessibility enhancement
-<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 500 300" width="500" height="300"> +<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 500 300" width="500" height="300" role="img" aria-label="Merge PR33 branch flow and conflict resolution"> + <title>Merge PR33 branch flow and conflict resolution</title> <style>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/merge-prs/merge-pr33.md` around lines 50 - 72, The SVG lacks accessibility metadata for screen readers; update the <svg> element and key graphical elements (e.g., <svg>, the grouped visual blocks made of <rect> and <text>, and <line>) to include accessible attributes: add role="img" and a descriptive aria-label on the <svg>, insert a <title> and <desc> immediately inside the <svg> that summarize the diagram (PR, branches, conflicts, dates), ensure interactive/focusability with tabindex="0" (and focusable="true" for compatibility), and where logical wrap related shapes/text in <g> groups with aria-labelledby/aria-describedby referencing the title/desc so assistive tech can convey the content.03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/h3dos-wire-tasks/h3dos-wire-artifacts-row-click.md (1)
15-43: ⚡ Quick winEnhance SVG accessibility.
Add accessibility attributes for screen reader compatibility.
♿ Proposed accessibility enhancement
-<svg xmlns="http://www.w3.org/2000/svg" width="400" height="250" viewBox="0 0 400 250"> +<svg xmlns="http://www.w3.org/2000/svg" width="400" height="250" viewBox="0 0 400 250" role="img" aria-label="Artifact row click wiring flow"> + <title>Artifact row click wiring flow</title> <style>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/h3dos-wire-tasks/h3dos-wire-artifacts-row-click.md` around lines 15 - 43, This SVG lacks accessibility metadata—wrap the graphic with a <title> and <desc> (give them IDs) and add role="img" plus aria-labelledby="TITLE_ID DESC_ID" on the <svg> element (and set focusable="false" for SVGs used purely as illustrations); mark purely decorative elements (e.g., rect class="box", path class="arrow", marker id="a", and visual-only <text>) with aria-hidden="true" and focusable="false" so screen readers ignore them, and ensure any text that conveys unique semantic info remains in the <title>/<desc> or is made focusable/announced if interactive; update the <svg> element and the decorative shapes (rect, path, marker, text) accordingly using the IDs and attributes above.03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/hp-protocol/hp-registry.md (1)
42-62: ⚡ Quick winEnhance SVG accessibility.
The diagram should include accessibility attributes for screen readers.
♿ Proposed accessibility enhancement
-<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 500 300" width="500" height="300"> +<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 500 300" width="500" height="300" role="img" aria-label="PR32 audit-gap closeout integration flow"> + <title>PR32 audit-gap closeout integration flow</title> <rect width="500" height="300" fill="#0b0f1a"/>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/hp-protocol/hp-registry.md` around lines 42 - 62, The SVG lacks accessibility metadata; update the root <svg> element to include role="img", focusable="false", and aria-labelledby/aria-describedby pointing to new <title id="..."> and <desc id="..."> elements (e.g., add <title id="hp-registry-title">hp-registry — PR#32 audit-gap closeout</title> and a <desc id="hp-registry-desc">short, meaningful description of the diagram and purpose</desc>) and mark purely decorative shapes/text (like individual <rect>, connector <path>, or duplicate <text> elements) with aria-hidden="true" so screen readers only announce the title/description; ensure the title/desc IDs are referenced in aria-labelledby and aria-describedby on the <svg>.03_implementation/adapter_registry/schemas/bambu_studio_slicer.schema.json (1)
10-14: ⚡ Quick winEnforce absolute-path semantics in
exe_path.Line 13 says absolute path, but current validation accepts any non-empty string. Add a path pattern (or relax description) so schema and contract match.
♻️ Suggested schema tweak
"exe_path": { "type": "string", "minLength": 1, + "pattern": "^(?:[A-Za-z]:\\\\\\\\|/).+", "description": "Absolute path to bambu-studio.exe or equivalent launcher." },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@03_implementation/adapter_registry/schemas/bambu_studio_slicer.schema.json` around lines 10 - 14, The exe_path property currently allows any non-empty string but the description requires an absolute path; update the JSON Schema for "exe_path" to enforce absolute-path semantics by adding a "pattern" that accepts POSIX absolute paths (starting with "/") and Windows absolute paths (drive letter + ":\\" or UNC paths), e.g. a regex matching ^(/|\\\\\\\\|[A-Za-z]:\\\\). Keep the existing "type" and "minLength" and update the "description" if needed to mention supported platforms.03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/hermesproof/README.md (1)
7-9: 💤 Low valueOptional: Add language identifier to fenced code block.
The pipeline flow diagram on lines 7-9 could specify a language identifier (e.g.,
text) to satisfy markdown linters, though the current rendering is clear.📝 Proposed fix
-``` +```text TRIGGER → WIZARD-GATES → QUEUE → NEXT-TASK (consumer)</details> <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.In
@03_implementation/docs/handoffs/hermes3d-os-folder-index-2026-05-07/hermesproof/README.md
around lines 7 - 9, The fenced code block containing the pipeline flow diagram
("TRIGGER → WIZARD-GATES → QUEUE → NEXT-TASK (consumer)") should include a
language identifier to satisfy linters; update the opening fence from ``` toblock becomes fenced as ```text and leave the contents unchanged.
Ghenghis
changed the base branch from
develop
to
feat/hermes3d-7-complete-gui-repo-wiring
May 8, 2026 23:32
Ghenghis
merged commit May 9, 2026
edbd404
into
feat/hermes3d-7-complete-gui-repo-wiring
1 check passed
This was referenced May 10, 2026
Ghenghis
added a commit
that referenced
this pull request
May 10, 2026
* docs(contract): sync Hermes3D completion roadmap and Claude handoffs
WIP checkpoint per GITHUB_SYNC_PLAN_2026-05-06: contract docs, roadmap,
and 20-agent handoff before Claude lanes branch off this baseline.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(api): add live Hermes3D backend routes and proof services
WIP checkpoint per GITHUB_SYNC_PLAN_2026-05-06: API routes, services,
db schema/init, core orchestration + slicer/printer adapters baseline
for the 20-agent completion lanes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(ui): wire live Hermes3D tabs and remove mock UX
WIP checkpoint per GITHUB_SYNC_PLAN_2026-05-06: live tab shells
(Source OS, Settings, Agents, Observe, Roadmap, Plugins, Jobs,
Artifacts, Approvals, Voice, Learning, Autopilot, Design, 3D Generation,
Printers), live API adapters, ResizablePane/AppShell layout, and
removal of mock data + retired tabs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(source-os): add adapter schemas, source audits, and runtime proof
WIP checkpoint per GITHUB_SYNC_PLAN_2026-05-06: 31 adapter_registry
JSON schemas (slicers/modelers/print-farm/gen3D/firmware), source-app
audit scripts, and proof artifacts (CLI surface, runtime action plan,
local tooling audit) backing the Source OS lane.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(e2e): add live GUI and no-fake proof coverage
WIP checkpoint per GITHUB_SYNC_PLAN_2026-05-06: Playwright e2e config
and live-gui spec, runtime-port + GUI-API + e2e-stack starters; retire
visual specs replaced by the live e2e suite.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* ci(fix): extend ui-ci.yml PR trigger to feat/** branches (TS7026 root cause) (#80)
* ci(fix): extend ui-ci.yml PR trigger to feat/** branches
`pull_request.branches` previously only listed `[main, develop]`.
Lane PRs target `feat/hermes3d-7-complete-gui-repo-wiring`, so
`npm ci` + `tsc --noEmit` (Layer D2) never ran for them.
Adding `feat/**` ensures the strict lint gate fires on every lane
PR, surfacing the pre-existing TS7026/TS7006 JSX.IntrinsicElements
regression (caused by missing `node_modules` in fresh worktrees)
rather than silently passing.
Root cause confirmed: `npm run lint` returns 0 errors after
`npm install`; tsconfig.json and @types/react are correct.
The regression only appears without node_modules.
Task: a2a_1778114702912_1ac758ea
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* ci: install API deps for UI workflow
* fix: seed provider module targets before providers
* fix: stabilize UI final truth gate
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* docs(roadmap): sync Hermes3D state with live baseline (H3D-CLAUDE-DOCS-PROOF) (#53)
Add Claude-authored docs companion and proof for the 20-Agent Completion
Contract Lane 18. Records the 5-commit shared baseline, 16-tab inventory
from routes.tsx, and the live S1/T1/V400 printer policy. README gains
pointers to the operator GUI roadmap and the contract handoff. ROADMAP.md
intentionally not edited because of an active codex-master Hermes lock.
Hermes evidence chain: PASS
Task ID: H3D-CLAUDE-DOCS-PROOF
hermes_run_gate: PASS
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(app-shell): finish resizable panels + density + Simple/Main parity (H3D-CLAUDE-APP-SHELL) (#54)
ResizablePane hardening:
- Escape during drag restores pre-drag width
- touchAction: none on the handle so drag works on touch devices
- Re-clamp persisted width when min/max bounds change at runtime
- SSR-safe localStorage write guard
Lane scope was bounded by Codex-master locks on AppShell, Sidebar, TopBar,
Panel, globals.css, tailwind.config.ts — those files were not contended.
DockModeToggle left unchanged: TopBar already owns the live Simple/Main
toggle via setUiMode and coupling DockModeToggle would break Phase 2 panel
docking semantics.
Hermes evidence chain: PASS
Task ID: H3D-CLAUDE-APP-SHELL
hermes_run_gate: PASS
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(e2e): add tab-specific Playwright specs (H3D-CLAUDE-PLAYWRIGHT) (#55)
Adds per-tab Playwright e2e specs for all 16 primary tabs and Roadmap,
each asserting truthful root mount, no forbidden mock/placeholder text
in production surfaces, and a clean console. Network calls are stubbed
at the GUI-API boundary; printers.spec.ts hard-aborts any request that
would reach live S1/T1/V400 operator IPs.
Hermes Task ID: H3D-CLAUDE-PLAYWRIGHT
Hermes evidence: ev_9d0e995e54bbac18
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(security): MCP boundary + prompt-injection + secret-redaction audit (H3D-CLAUDE-SECURITY-MCP) (#56)
Lane 19 of the Hermes3D 20-Agent Completion Contract. Adds READ-ONLY
behavioural tests over the in-house OWASP LLM-01 prompt-injection scanner
(commit 0c9b6d9), the secret-redaction surface in services/local_state.py
+ services/module_runtime.py + services/agent_runtime.py, the canonical
user-supplied-path validators in services/code_history.py, and the
MCP/tool-boundary policy gates that protect printers and the agent
runtime URL.
New files (lane-owned only):
- 03_implementation/tests/security/__init__.py
- 03_implementation/tests/security/conftest.py
- 03_implementation/tests/security/test_prompt_injection.py
- 03_implementation/tests/security/test_secret_redaction.py
- 03_implementation/tests/security/test_path_traversal.py
- 03_implementation/tests/security/test_mcp_boundary.py
- 03_implementation/proof/security/SECURITY_AUDIT_2026-05-06.json
- 03_implementation/docs/security/MCP_BOUNDARY_NOTES.md
Vectors covered (full list in SECURITY_AUDIT_2026-05-06.json):
- OWASP LLM-01 indirect injection, ChatML/Llama control tokens,
RCE-shaped tool-poisoning (curl|sh, wget|bash, iex/iwr), prompt-leak
variants, jailbreak personas (DAN, devmode, ignore-safety,
no-restrictions, pretend-unrestricted), and unicode-control no-crash
guarantees.
- LLM-02 (light): execute-following + base64 payload framing.
- LLM-06: AST scan over services/*.py rejects raw secret-shaped
literals (sk-, ghp_, AKIA, bearer, xoxb-) in source AND in any
logging emitter call site; pins module_runtime._redact_text on
every subprocess->output_head path; pins agent_runtime never logs
private_values / private_env() / env_value() return values.
- Path traversal: 8 explicit-reject vectors (../etc/passwd, drive
letters, null-byte injection, empty path), plus the documented
coercive cases (/etc/passwd and //attacker.example/share/x are
re-rooted into PROJECT_ROOT — informational, no escape possible).
- MCP boundary: build-plate-clearance gate, FLSUN S1 read-only lock,
trusted_runtime_url rejects non-private hosts / credentials /
query / fragment / wrong scheme / self-bridge ports 8765+8642,
scanner ships >=15 OWASP + >=10 in-house rules, fail_threshold
knob, redacted-text logging sink, secret-storage convention pinned
to G:\private\.env (outside repo).
Findings (logged, NOT silently fixed; surfaced via xfail strict=True
so they fail loudly when patched upstream):
- FINDING-INJ-1 (medium, owner = core/security ruleset lane):
LLM01-LEAK-VERBATIM regex misses reverse word order
`the prompt verbatim`. Suggested fix: anchor on `verbatim`
independent of word order or add LLM01-LEAK-VERBATIM-REV.
- FINDING-INJ-2 (medium, owner = core/security ruleset lane):
Zero-width-space (U+200B) injected in `ignore` bypasses
LLM01-IGN-PREV; `dump` is missing from leak alternation.
Suggested fix: pre-normalise zero-width / bidi control chars
before matching; extend LLM01-LEAK-SYSPROMPT verb alternation.
- FINDING-PATH-1 (low, informational, owner = Codex / code_history
lane): `_resolve_project_subpath` re-roots `/etc/passwd` and
`//attacker.example/share/x` into PROJECT_ROOT rather than
rejecting. SAFE (no escape; `relative_to(PROJECT_ROOT)` enforces
containment) but contract is coercive, not rejective.
Required gates: PASS
- python -m py_compile services/*.py routes/*.py: PASS
- scan_active_ui_no_fake.py: PASS
- pytest 03_implementation/tests/security/: 78 passed, 2 xfailed
- npm run lint: PASS
Hermes evidence: ev_cfb93a332dd6918a (ledger entry hash chain
extended). Lock owner: claude-security-mcp-19. No files outside
03_implementation/{tests,proof,docs}/security/ were modified.
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(source-gen3d): real source+runtime verifiers for ComfyUI/TRELLIS/Hunyuan3D/TripoSR (H3D-CLAUDE-SOURCE-GEN3D) (#57)
Adds adapter_registry/scripts/tests for the five generative-3D providers
without performing any heavy operation:
* schemas: extend comfyui/trellis2/hunyuan3d/triposr/bambustudio_bridge
with source_repo, pip_package, weights_cache_dirs (all backward compatible).
* scripts/verify_gen3d.py: stdlib + subprocess only.
- git ls-remote --heads (no clone), 5s timeout.
- pip show <pkg> (no install), 5s timeout.
- Boolean cache-presence for ~/.cache/huggingface and similar.
- Bambu Studio: launcher executable presence only (no launch).
* proof/GEN3D_VERIFY_2026-05-06.json: 5/5 repos reachable;
Bambu Studio launcher present; comfyui/trellis2/hunyuan3d/triposr
honest "not installed" (no fabrication, no downloads).
* tests/source_lab/test_gen3d.py: pytest validates proof shape, policy
invariants, full provider coverage, and reachability honesty.
Hermes evidence chain: PASS
Task ID: a2a_1778106411818_946d5ec0
Lane: H3D-CLAUDE-SOURCE-GEN3D
hermes_run_gate: verify_gen3d, pytest test_gen3d, py_compile, scan_active_ui_no_fake
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(source-firmware): firmware toolchain proof gates, no-flash safety (H3D-CLAUDE-SOURCE-FIRMWARE) (#58)
- Add JSON schemas for Klipper, Marlin, RepRapFirmware, Prusa firmware sources
- Add JSON schemas for arm-none-eabi-gcc and avr-gcc toolchains
- Add verify_firmware.py: probes toolchain availability (--version only) and
firmware source reachability (git ls-remote only); NEVER flashes, NEVER
opens serial/USB to printer boards
- Add test_firmware.py: pytest suite asserting schema validity, no-flash policy,
verifier source integrity, and no-network proof generation
- Add FIRMWARE_VERIFY_2026-05-06.json: proof artifact (all 4 firmware sources
reachable; toolchains absent on this host — honestly recorded)
Lane: H3D-CLAUDE-SOURCE-FIRMWARE
Owner: claude-source-firmware-05
Hermes evidence chain: PASS
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(source-printfarm): read-only Moonraker/Klipper/OctoPrint verifiers (H3D-CLAUDE-SOURCE-PRINTFARM) (#59)
- verify_printfarm.py: HTTP GET-only probes for Moonraker (T1-a, T1-b, V400),
OctoPrint, Fluidd, Mainsail, FDM Monster, KlipperScreen, Printrun.
FLSUN S1 camera skipped per lane policy. Honest "unreachable" for all
localhost services (not running on this host). 3/3 Moonraker printers
reached; V400 version: v0.7.1-586-gbb526e0-dirty.
- test_printfarm.py: pytest suite asserting proof JSON shape, policy
invariants, GET-only constraint, S1 never-probed, and summary consistency.
- PRINTFARM_VERIFY_2026-05-06.json: proof artifact with live results.
- adapter_registry/schemas/moonraker_api.schema.json: JSON Schema for
read-only Moonraker HTTP adapter (GET-only, forbidden endpoints listed).
- adapter_registry/schemas/klipper_service.schema.json: JSON Schema for
Klipper service adapter (systemctl/moonraker-proxy, no G-code ever).
Hermes evidence chain: PASS
Task ID: H3D-CLAUDE-SOURCE-PRINTFARM
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(source-modelers): real verifiers for Blender/OpenSCAD/FreeCAD/CadQuery/build123d/trimesh (H3D-CLAUDE-SOURCE-MODELERS) (#60)
- 9 adapter schemas with real verify blocks (version_probe, install_check, runtime_check)
- scripts/verify_modelers.py: live CLI + pip-show probes, no fake/mock gates
- tests/source_lab/test_modelers.py: pytest contract validation for proof JSON
- proof/MODELERS_VERIFY_2026-05-06.json: honest results — found: blender, openscad, trimesh; not_found: freecad, cadquery, build123d
Lane: H3D-CLAUDE-SOURCE-MODELERS
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(artifacts): proof bundle index + artifact discovery API (H3D-CLAUDE-ARTIFACTS-PROOF) (#61)
- artifacts.py: add GET /api/artifacts/list (scans proof/ dir live, no hardcoded data)
and GET /api/artifacts/proof/{filename} (serves proof files with path-traversal guard)
- PROOF_MANIFEST_2026-05-06.json: real manifest of all 14 proof files in proof/
(generated by scanning directory, includes sizes, timestamps, lane IDs)
- Artifacts.tsx: add Proof Bundles panel calling /api/artifacts/list; displays
all proof files with View links; no mock data
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(learning-autopilot): truthful idle work kinds + real backend state (H3D-CLAUDE-LEARNING-AUTOPILOT) (#62)
- AutopilotConsole: remove hardcoded fake status values (Loop: on, Window: 8h, Risk: low)
that were not connected to any backend; replace with props-driven readyCount/totalChecks
that drive honest live/unavailable/blocked state display
- AutopilotTab (existing): already calls /api/autopilot/readiness + /api/autopilot/guardrails
for real backend state - no fake activation
- LearningTab (existing): all idle work kinds call real endpoints with honest blocked state:
createIdleCandidate → POST /api/learning/idle-workbench/candidates
runIdleCandidate → POST /api/learning/idle-workbench/candidates/{id}/run
requestIdleCandidateReview → POST /api/learning/idle-workbench/candidates/{id}/request-review
decideIdleCandidate → POST /api/learning/idle-workbench/candidates/{id}/decision
- Backend learning.py: run endpoint returns accepted:false + reason when runtime not configured
- Backend autopilot.py: next-gate returns 409 with failing check detail when not all ready
- Pre-existing TS7026 regression: 0 errors (lint clean)
- Python compile: learning.py OK, autopilot.py OK
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(source-slicers): real CLI verifiers for slicers (H3D-CLAUDE-SOURCE-SLICERS) (#63)
* feat(design): real CAD template gallery + provider health checks (H3D-CLAUDE-DESIGN) (#65)
- backend: add GET /api/design/templates — discovers templates from real
importable executor modules (hermes3d.core.design.*), reports
executor_available + missing_deps from live importlib checks
- backend: add GET /api/design/providers — probes OpenSCAD, Blender,
CadQuery, trimesh, manifold3d, FreeCAD via shutil.which + importlib;
no cached stubs, no fake version strings
- UI: Design.tsx pulls templates and providers from real backend endpoints;
template select populated from /api/design/templates (disabled if
executor unavailable); provider health panel shows live probe results;
template gallery shows preview-not-available for all templates (no
renderer wired); no hardcoded "Generated successfully" messages
- tests: add 04_testing/pytest/unit/test_design_providers.py — 18 tests
covering _discover_templates, _probe_providers, _probe_cli_provider,
_probe_python_provider; trimesh/manifold3d tests assert against live
importlib.util.find_spec to prevent divergence from reality
Pre-existing TS7026 errors in other tabs (not Design.tsx): noted in PR, not
fixed in this lane per cross-lane separation rules.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(observe): camera grid + S1 90deg + refresh reliability + V400 status (H3D-CLAUDE-OBSERVE) (#67)
- Backend: add GET /api/observe/status with per-camera health, response_ms, estimated_fps,
and read_only flag (S1 at 192.168.0.12 is flagged read-only; never receives control cmds)
- Backend: refactor _probe_camera into _probe_camera_timed for fps estimation;
update camera_health endpoint to return response_ms + estimated_fps
- Frontend types: add CameraStatus + ObserveStatusResponse interfaces to observe.ts
- Observe.tsx: exponential backoff retry on feed error (1s base → 30s max);
feedState gains 'reconnecting' state with spinner overlay instead of broken image;
auto-refresh interval selector (off / 3s / 5s / 10s / 30s) polls /api/observe/status;
online/offline summary badge in header; Refresh all button triggers both feed + status fetch;
V400 per-card online/offline chip + fps indicator from status API;
S1 defaults to 90deg rotation (backend + defaultViewSettings already enforced)
- ObserveConsole.tsx: replace hardcoded mock camera list with live /api/observe/status polling
every 5s; shows read_only badge on S1, fps estimate per camera, online/offline with ping ms
Camera safety: S1 (192.168.0.12) is camera/read-only throughout; no move/upload/print/test
commands are issued from Observe tab or status endpoint.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(jobs): policy-gated repair/retry/rollback + proof state (H3D-CLAUDE-JOBS) (#68)
- Add _check_printer_policy() to jobs.py enforcing three ordered gates:
1. S1 hard lock (192.168.0.12 / flsun-s1 always rejected, HTTP 423)
2. PRINTER_WRITE_DENIED: printer must be write_enabled or in WRITE_ALLOWED_PRINTERS (HTTP 423)
3. PRINTER_IDLE gate: printer state must be standby/complete/ready/error before retry/repair/rollback (HTTP 409)
- apply_repair, retry_job, rollback_job all call _check_printer_policy() before mutating any state
- propose_repair calls check_s1_lock() (read-only planning step, no printer movement)
- Every policy block records a proof event in proof_events table with printer_id, job_id, reason
- Jobs.tsx already correct: real endpoints, state machine, proof event IDs displayed — no fake messages
- Add 04_testing/pytest/unit/test_jobs_policy.py: 37 tests covering S1 lock, read-only policy, PRINTER_IDLE gate, no-printer pass-through, write-enabled idle pass-through, proof event DB writes
NEVER sends job commands to moving printers. S1 (192.168.0.12) never a job target.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(gen3d): real provider readiness + proof-backed local templates (H3D-CLAUDE-GEN3D) (#70)
- backend: add GET /api/gen3d/providers — reads Lane 04 GEN3D_VERIFY_2026-05-06.json
proof + live port probe for ComfyUI; returns installed/repo_reachable/weights_present
for comfyui, trellis2, hunyuan3d, triposr, bambustudio_bridge; no fake readiness
- backend: add GET /api/gen3d/templates — discovers local templates (calibration_cube via
trimesh, no provider needed) + provider-backed templates from adapter_registry schemas;
schema_present field reflects real file existence
- UI: provider status panel now shows 3D generation provider readiness (from
/api/gen3d/providers) with readiness badges sourced from Lane 04 proof data
- UI: local template gallery (from /api/gen3d/templates) — cards show source, outputs,
required provider; selecting provider-backed template with unavailable provider shows
"Provider not available" on Generate with a proof event emitted
- tests: add test_gen3d_routes.py with 14 unit tests covering both new endpoints
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(source-ui): SourceOS CLI readiness + proof panel + no-cutoff layout (H3D-CLAUDE-SOURCE-UI) (#66)
- Add CliReadinessPanel component: collapsible section showing CLI readiness
for all 5 tool categories (slicers, modelers, print_farm, firmware, gen3d)
with per-key-tool status badges (Verified CLI / Detected / Source Ready /
Not Installed / Unavailable). Data comes from /api/sources/readiness.
- Add ProofArtifactPanel component: collapsible section with links to
/api/artifacts and per-category artifact queries, plus proof file listing.
- CliReadinessPanel and ProofArtifactPanel use overflow-y: auto with maxHeight
to ensure no content cutoff — all content is scrollable.
- Create 03_implementation/src/hermes3d/api/routes/source_os.py:
GET /api/sources/readiness reads proof JSON files (LOCAL_TOOLING_AUDIT,
SOURCE_APP_CLI_AGENT_READINESS_AUDIT, SOURCE_APP_CLI_SURFACE_AUDIT) and
returns aggregated readiness per category with key tool details.
- Wire source_os router into hermes3d/api/app.py.
- No hardcoded readiness states — all from proof JSON files.
- tsc --noEmit: PASS (zero errors in owned files; pre-existing TS7026 regression
in other src/*.tsx files predates this contract).
- py_compile source_os.py: PASS.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(settings-plugins): update center + provider health + failsafe rollback (H3D-CLAUDE-SETTINGS-PLUGINS) (#69)
- Add GET /api/settings/update-center: real component versions, Velopack readiness, live provider probes, rollback availability
- Add POST /api/settings/update-center/rollback/{component}: surfaces rollback for proof-gated flow
- Register update_center router in app.py
- New UpdateCenterSubtab.tsx: live update center with failsafe rollback cards
- New PluginRollbackPanel.tsx: per-plugin health + deactivate/rollback action
- SettingsPage.tsx: add Update Center subtab wired to UpdateCenterSubtab
- AboutSubtab.tsx: fetch real versions from backend, removed hardcoded VERSION constant
Pre-existing TS errors in other files not introduced here. tsc passes clean for all touched files.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(voice): transcript history + playback controls + proof review (H3D-CLAUDE-VOICE) (#64)
- Backend: add GET /api/voice/transcripts, GET /api/voice/recordings/{id},
GET /api/voice/proof-events to voice.py; recordings served as binary
audio from proof_events table; no API key in any URL
- Types: add VoiceTranscript and VoiceProofEvent to voice.ts
- Adapters: add getVoiceTranscripts, getVoiceProofEvents, getVoiceRecordingUrl
to AdapterAPI interface + live implementations + parse helpers
- UI: Voice.tsx gains three-tab layout (Voice Browser / Transcript History /
Proof Review); playback routed through backend only (new Audio(backendUrl)),
no device access from frontend; honest empty states when no data yet
Gates: python -m py_compile OK; tsc --noEmit 0 errors
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(printers): onboarding wizard + Moonraker probe + S1 camera-only lock (H3D-CLAUDE-PRINTERS) (#71)
- Add 5-step printer onboarding wizard to PrintersTab:
Step 1: Enter IP + connection type (Moonraker/OctoPrint/direct)
Step 2: Auto-probe via GET /api/printers/probe (read-only, shows version/firmware/bed size)
Step 3: Set camera URL with MJPEG validation
Step 4: Confirm + save profile with write-enable toggle
Step 5: Done / refresh fleet
- S1 (192.168.0.12) is LOCKED in the wizard: shows 'Camera only — cannot add as
print target' before any network call is made; frontend enforces CAMERA_ONLY_IPS set
- Add GET /api/printers/probe backend endpoint:
Read-only: calls only GET /server/info and optional /printer/objects/query
Never sends GCode, commands, or mutations
Returns: Moonraker version, klippy_state, bed size from fleet profile
- Add POST /api/printers/validate-camera backend endpoint:
Read-only: HEAD request only, checks Content-Type for multipart/x-mixed-replace
Returns: {ok, content_type, is_mjpeg, http_status}
- Add CAMERA_ONLY_IPS frozenset constant in printers.py (single source of truth):
Any attempt to add 192.168.0.12 as a print target returns 403 CAMERA_ONLY_IP
Covers: probe endpoint, onboard URL validation, printer ID validation
- Add test_printer_policy.py (16 tests, all passing):
- S1 IP blocked in onboard URL validation (403 CAMERA_ONLY_IP)
- S1 aliases blocked in printer ID validation (423)
- Probe endpoint returns 403 for S1 IP
- Probe is read-only: send_gcode/upload_gcode/start_print never called
- Camera validate uses HEAD request only
- MJPEG detection verified
- TestClient route integration tests
- TypeScript: tsc --noEmit passes cleanly (0 errors in owned files)
- Python: py_compile passes for printers.py and test_printer_policy.py
- Pre-existing TS7026 errors in other src/*.tsx files are unrelated to this lane
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* docs(integration): 20-agent completion integration report (H3D-CLAUDE-FINAL-INTEGRATOR) (#72)
All 19 lane PRs (#53-#71) are OPEN/MERGEABLE with CodeRabbit SUCCESS and
Hermes evidence chain PASS. Two cross-lane file conflicts identified:
- app.py: PRs #66 + #69 both add a router (additive, UNION merge)
- adapters.ts / adapters.live.ts: PRs #64 + #71 both add methods (additive, UNION merge)
Merge order: Tier-1 (15 PRs in parallel) → Tier-2 (#66→#69) → Tier-3 (#64→#71).
Pre-existing JSX TS7026/TS7006 regression (~57 files) flagged as HIGH-priority fix-PR
needed before release.
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* audit(runtime): proof files + verifier scripts + route truth verification (#74)
Verifies all 6 proof JSON files are real (not hand-crafted), all 4 verifier
scripts use genuine subprocess/filesystem probes, and all 7 API routes have
real implementations. All syntax checks pass. No blockers found.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* audit(merge): PR base + conflict cluster + silent drop verification (H3D-CLAUDE-POLISH-MERGE-2026-05-06) (#75)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* audit(security): secret scan + path traversal + shell audit (H3D-CLAUDE-POLISH-AGENT-MCP-PROOF-2026-05-06) (#76)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* audit(safety): S1 lock + printer policy + GCode scan verification (#77)
53/53 policy tests pass. S1 (192.168.0.12) blocked before every network call.
Zero GCode keywords in probe/read routes. Zero bypass paths found. Camera controls
are CSS-only display transforms with no hardware commands.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* audit(docs): PR body completeness + ROADMAP truth + merge plan verification (H3D-CLAUDE-POLISH-RELEASE-DOCS-2026-05-06) (#78)
- Audited all 20 PR bodies (#53-#72): all have evidence chain, task ID, and gates
- PR #53 missing formal files table (prose description present); PR #64 minimal body
- TS7026 blocker documented in PR #72; absent from ROADMAP.md (codex-master locked)
- README "77 of 79" claim is stale relative to feature branch (update post-merge)
- Merge Tier 1/2/3 structure is correct; PR #72 needs explicit Tier 4 slot in plan
- No PRs accidentally merged; all 20 lane PRs remain open
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* audit(nofake-ui): 0 violations — no-fake scan + 33 buttons wired + 0 lane TS errors (H3D-CLAUDE-POLISH-NOFAKE-UI-2026-05-06) (#79)
* docs(handoff): final Codex takeover bundle — 9 audit/merge/lock files (#81)
Closes the Claude 20-agent + 6-audit-agent run. Contains:
00_EXECUTIVE_TAKEOVER_SUMMARY.md — 1-page status for Codex
01_PR_MERGE_MATRIX.md — exact tier merge order for #53-#80
02_OPEN_BLOCKERS_AND_FIX_QUEUE.md — 0 code blockers, 4 low/info doc gaps
03_LOCKS_WORKTREES_AND_BRANCHES.md — 28 Claude locks released, 28 worktrees
04_RUNTIME_TRUTH_AND_NO_FAKE_AUDIT.md — Audit 2+3: 0 fake violations
05_PRINTER_SAFETY_AND_PHYSICAL_IO_AUDIT.md — Audit 4: S1 camera-only PASS
06_SECURITY_MCP_AND_AGENT_ACCESS_AUDIT.md — Audit 5: no traversal/secret leaks
07_ARCHITECTURE_AND_FLOW_DIAGRAMS.md — Mermaid diagrams for all flows
08_FINAL_CLAUDE_RELEASE_NOTE.md — final PR list + lock state + Codex next steps
All 28 Claude-owned Hermes locks released.
All 20 lane PRs (#53-#72) and 6 audit PRs (#74-#79) open CLEAN.
TS7026 fix PR #80 open (CI running).
Hermes task: a2a_1778115796454_685e7b14
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(ui): clear post-merge npm audit vulnerabilities (#82)
* fix(ui): clear npm audit vulnerabilities
* fix(ui): clean post-merge browser gates
* fix: align observe refresh button contract
* [codex] add MCP-locked Hermes Agent code operator (#73)
* feat(agents): add MCP-locked code operator lane
* docs(handoff): add Claude final audit takeover contract
* fix(agents): harden code operator lane
* docs(handoff): Hermes3D OS folder index 2026-05-07 — 86 markdowns w/ inline SVG (#86)
Comprehensive index of every Hermes3D OS folder in G:\Github\ modified
between 2026-04-27 and 2026-05-07. Authored by 13 parallel sub-agents
under task a2a_1778147261453_661b606f.
Structure (12 categories, 60 included folders, 7 excluded):
00_INDEX.md -- master nav + topology SVG
01_TAXONOMY.md -- classification rules
02_EXCLUSIONS.md -- 7 folders intentionally excluded + reasons
apps-vendored/ -- 7 vendored apps (~1.08 GB) + README
core-repos/ -- 5 core H3D repos + README
agent-infra/ -- 5 hermes-agent / MCP infra + README
hp-protocol/ -- 9 HP P0/P1 hardening folders + README
hermesproof/ -- 6 HermesProof component sandboxes + README
source-os-60-apps/ -- canonical 60-app registry + treemap SVG
h3dos-wire-tasks/ -- 18 single-button UI wire lanes + README
h3dos-codex-tasks/ -- 5 Codex app integration lanes + README
merge-prs/ -- 4 cascade-merge worktrees + README
h3d-enhancements/ -- 7 H3D enhancement branches + README
worktree-collections/ -- 3 umbrellas (49 sub-worktrees) + README
research/ -- _research scratchpad + README
Each per-folder markdown includes: H1 title, purpose, status,
branch+commit, key files, relationships, and inline hand-written
SVG (400-900 px). Category READMEs add master inventory tables and
larger SVGs (700-900 px).
Excluded (7): kilocode-Azure2, contract-kit-v17 (3 variants),
TRELLIS.2, Agentic-Modeler, _repo_rescue_evidence -- documented
in 02_EXCLUSIONS.md with reasoning.
Hermes evidence chain: PASS
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(queue): recover closed stacked PR work (#105)
* feat(agents): add MCP-locked code operator lane
* docs(handoff): add Claude final audit takeover contract
* fix(agents): harden code operator lane
* feat(agents): add proof-gated git shipping lane
* feat(agents): add provider team assignment lane
* feat(agents): add provider execution artifacts
* feat(source-os): add runner contract matrix
* feat(source-os): register python cad verifier family
* feat(source-os): correct slicer runner truth
* feat(source-os): add print farm health verifiers
* feat(source-os): add service web health verifiers
* feat(source-os): add safe service start-runner preflights
* feat(source-os): supervise service runner starts
* test(unit): remove live fleet timeout from offline tests
* feat(source-os): add firmware source inventory verifiers
* feat(accel): add rust metadata proof worker
* feat(source): add read-only runner smoke contracts
* feat(source): add executable path runner smoke
* feat(source): add python import repair preflights
* feat(source): add slicer cli config preflights
* feat(source): add npm package metadata preflight
* docs(agents): define e2e proof plan
* feat(agents): add e2e workbench
* feat(agents): add provider smoke and reviewed ship lane (#104)
* feat(agents): add provider smoke and reviewed ship lane
* fix(agents): prove live runtime freshness
* feat(agents): add cli runner contracts
* fix(agents): require live provider smoke proof
* docs(handoff): Claude 20+ agent E2E completion intelligence bundle 2026-05-08 (#106)
Read-only intelligence sweep produced per PR 104's Claude 20+ Agent E2E
Completion Intelligence Contract. 12 markdown deliverables under
03_implementation/docs/handoffs/claude-e2e-intelligence-2026-05-08/
covering: executive map, G:/Github folder ecosystem audit, stale
code/branch map, Hermes Agent runtime gap map, Source OS 60-app
completion map, tab-by-tab UI no-fake audit, env-key/runtime config map,
test gates + proof matrix, PR + merge queue, Codex next 50 tasks, 6
Mermaid diagrams, and final Claude note.
Live truth captured at 2026-05-08 17:25Z from API on branch
codex/provider-smoke-workbench commit 43d8205: 220 routes, all 10 Agent
Workbench routes present, 60 Source OS apps (7 agent_cli_ready, 24
runner_gaps), 81 active UI files clean (no-fake scan PASS), 25 open PRs
all CLEAN/CodeRabbit-SUCCESS. Hard blocker: MiniMax + DeepSeek HTTP 401
on G:/private/.env keys (Tier 0 user action; Codex chain not blocked).
No source code edited. No PRs merged. No Codex-owned locks released. 12
hermes3d-locks acquired by claude-e2e-intel-aggregator (taskId
claude-e2e-intel-2026-05-08) for the markdown bundle; released after PR
open per contract.
Hermes evidence chain: kickoff ev_b6e233d4ac466056
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(agents): prove provider env aliases (#107)
* docs(handoff): prepare Claude 24-agent completion contract (#108)
* proof(I14): update no-fake sweep 2026-05-08 — 81 files, PASS (#116)
Active UI no-fake scan re-run on 2026-05-08:
- 81 production files walked from App.tsx entry point
- 0 findings (no mock/fake/simulated markers in string literals)
- No data/mock imports in active graph
- 15 orphaned/unwalked files separately verified clean
- scan_active_ui_no_fake.py requires no changes
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* test(I8): printer safety — S1 camera-lock tests, T1/V400 policy gates (#111)
Adds 25 new test cases to test_printer_policy.py closing the critical safety
gap where S1 (192.168.0.12) action endpoints (move, test, upload, upload-gcode)
had no direct hard-lock assertions. New TestS1ActionHardLock class proves 423
PRINTER_LOCKED fires before any MoonrakerClient I/O for all four action routes,
across all S1 aliases. TestT1V400PolicyGates confirms write-allowed printers are
not misclassified as S1 and pass the lock gate. 78/78 tests pass.
Task: H3D-CLAUDE24-I8-PRINTER-SAFETY
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(I4): add runner_family to all 60 runner-contracts + blocked_reason for BLOCKED rows (#119)
- Add _contract_runner_family() mapping runner_status → valid family string
- Add runner_family field to module_runner_contract() return dict (was absent,
causing all 60 /runner-contracts rows to have FIELD_MISSING)
- Fix blocked_reason for slic3r and superslicer (runner_status=blocked):
previously suppressed by cli_install_config_available=True condition; now
always set when runner_status==blocked regardless of preflight runner
- Valid families emitted: agent_cli_ready, read_only_runner, executable_path,
python_import_repair, cli_install_config, npm_package_preflight,
desktop_app_runner_gap, gpu_worker_runner_gap, runtime_repair_required,
source_reference_only, blocked, metadata_ready_needs_runner
- 113 pytest tests pass; only locked file modified
Task: H3D-CLAUDE24-I4-SOURCEOS-CORE
Hermes evidence chain: PASS
Gates run: python -m py_compile (both files), pytest 113 passed
Rows fixed (null→known runner_family): 60
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(I1): provider endpoint/model config audit — MiniMax+DeepSeek smoke (#112)
Audit confirmed both providers have correct code configuration:
- MiniMax: /v1/chat/completions, Bearer auth, MiniMax-M2.7 — all correct
- DeepSeek: /chat/completions, Bearer auth, deepseek-v4-pro — all correct
HTTP 401 on both is a pure API key issue (invalid/expired keys in G:\private\.env).
Added inline comments to PROVIDER_DEFAULT_BASE_URLS documenting the verified
endpoint/auth/model contract and the exact user action needed to resolve 401s.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(I2): wire E2E code loop — patch-apply, gate-run, branch-commit-pr chain (#118)
- audit confirmed: apply_reviewed_patch_proposal, run_mcp_gate,
git_commit_owned_files, git_push_current_branch, git_open_pull_request,
restore_snapshot all fully implemented (no stubs)
- wiring gap found and fixed: no GET /e2e/jobs endpoint existed to list
job states — added list_e2e_jobs() to code_history.py and the
GET /api/code-operator/e2e/jobs route to code_operator.py
- new GET route queries proof_events for code_e2e/code_patch/code_git
event types and returns job state legend for E2E loop operators
- expanded test_code_operator_routes_are_registered to assert all 7
E2E chain routes are wired: apply-reviewed, gates/run, git/branch,
git/commit-owned, git/push, git/pr, e2e/jobs GET
- added test_list_e2e_jobs_returns_proof_events and
test_list_e2e_jobs_route_returns_200 — 92 tests pass (was 90)
- py_compile passes on both locked files
- provider 401 remains user-action only: I1 audit confirmed HTTP 401
is a pure invalid API key issue; no provider HTTP code touched
Task: H3D-CLAUDE24-I2-E2E-CODE-LOOP
Hermes evidence chain: PASS
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(I3): OpenCode/OpenHands sandbox readiness + GET preflight route (#121)
* feat(I3): OpenCode/OpenHands sandbox readiness + GET preflight route
- Add opencode_openhands_sandbox_readiness() in code_history.py returning
the I3-spec shape: opencode_detected, opencode_version, openhands_detected,
openhands_image, sandbox_network_mode (always "none"), denied_paths, ready
- Add preflight_code_cli_runner_get() for non-mutating --version dry-run
(GET variant, no task claim required); returns stdout, exit_code, elapsed_ms
- Wire GET /api/code-operator/sandbox/readiness to new function (replaces
Docker-based response with OpenCode/OpenHands detection schema)
- Add GET /api/code-operator/cli-runners/preflight?runner_id=opencode|openhands
- Add SandboxReadiness panel to Agents.tsx with real detected/not-detected
badges (data-testid=sandbox-readiness-panel), Refresh button, network mode
and denied-paths display — no fake states
- Evidence: ev_040fad5fbd843c38 (opencode v1.4.3-hermes3d detected, exit_code=0)
- 38 unit tests green; task H3D-CLAUDE24-I3-OPENCODE-OPENHANDS released
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(I3): wire setSandboxBusy into Refresh onClick — resolve TS6133
Layer D2 UI-Final failed because setSandboxBusy was declared but its
setter was never invoked (TS6133). Wire it correctly: setSandboxBusy(true)
before the fetch, .finally(() => setSandboxBusy(false)) after, so the
Refresh button correctly shows "checking" during load and CI passes.
Evidence: ev_ffa9a8c3e3bd4a40 | Task: H3D-A1-PR121-FIX
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(I7): firmware source inventory probes — read-only git describe, source_reference_only contract (#120)
- Add FIRMWARE_SOURCE_PATHS registry mapping all 6 firmware module IDs to
their actual source checkouts under Hermes3D-OS/source-lab/sources/
- Add _git_describe(): read-only subprocess.run(git describe --tags --always)
with timeout=5s; returns None on any error — no flash/compile/serial
- Add probe_firmware_source_inventory(module_id): returns source_found,
version_tag, runner_status=source_reference_only, agent_executable=False
- Add probe_all_firmware_sources(): aggregates all 6 modules in one call
- Update BUILTIN_RUNTIME_PROBES firmware entries: path fields now point to
confirmed source checkouts; kind changed to firmware_source_inventory
- Add 04_testing/pytest/unit/test_firmware_farm_probes.py — 49 tests:
registry coverage, contract template, _git_describe (mocked), per-module
parametrized happy/absent paths, safety constraint enforcement tests
- Live probe result (evidence ev_842d77f8663ea2ee):
firmware_klipper=293e1e9, marlin=03cc75f, prusa_firmware=f3e0dfd,
reprapfirmware=f4297ad, repetier_firmware=7cb3741, smoothieware=620e162
- ABSOLUTE CONSTRAINTS: no avrdude/dfu-util/openocd/esptool, no serial port,
no make/cmake/platformio, S1 not probed, T1/V400 source-only
Hermes evidence chain: PASS
Task ID: H3D-CLAUDE24-I7-FIRMWARE-FARM
Evidence ID: ev_842d77f8663ea2ee
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(I6): service/web-app health probes + service_web_health_runner status (#122)
Add seven named read-only HTTP probe functions (probe_fluidd, probe_mainsail,
probe_octoprint, probe_fdm_monster, probe_octofarm, probe_manyfold,
probe_comfyui) plus a probe_service_web_health dispatcher. Each probe uses
GET with a 3-second timeout, never POSTs, never mutates, and is blocked with
reason=no_configured_url when the env var is absent.
Update _runner_status to return service_web_health_runner (replacing the
generic readonly_api_ready) for local_http_health verifier kind, and add
service_web_health_runner_contract to _required_verifier_family.
Add 74-test suite in test_module_runtime.py covering: dispatcher routing,
blocked-when-no-url, non-local-URL guard, HTTP 200 happy path (mocked),
connection-error handling, 4xx handling, runner-contract status assertions,
and GET-only method verification. Update pre-existing test in
test_source_runtime_contracts.py to reflect the new runner_status value.
All 226 unit tests pass (74 new, 116 combined with existing module tests).
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(I5): slicer/modeler CLI probes — PATH detection, --version proof, exact blocked reasons (#123)
* fix(I4): add runner_family to all 60 runner-contracts + blocked_reason for BLOCKED rows
- Add _contract_runner_family() mapping runner_status → valid family string
- Add runner_family field to module_runner_contract() return dict (was absent,
causing all 60 /runner-contracts rows to have FIELD_MISSING)
- Fix blocked_reason for slic3r and superslicer (runner_status=blocked):
previously suppressed by cli_install_config_available=True condition; now
always set when runner_status==blocked regardless of preflight runner
- Valid families emitted: agent_cli_ready, read_only_runner, executable_path,
python_import_repair, cli_install_config, npm_package_preflight,
desktop_app_runner_gap, gpu_worker_runner_gap, runtime_repair_required,
source_reference_only, blocked, metadata_ready_needs_runner
- 113 pytest tests pass; only locked file modified
Task: H3D-CLAUDE24-I4-SOURCEOS-CORE
Hermes evidence chain: PASS
Gates run: python -m py_compile (both files), pytest 113 passed
Rows fixed (null→known runner_family): 60
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(I5): slicer/modeler CLI probes — PATH detection, --version proof, exact blocked reasons
Adds probe_slicer_cli() and probe_modeler_import() to module_runtime.py.
Non-mutating: --version/help only, no STL sent, no firmware flashed.
Detected (on this machine):
Slicers: PrusaSlicer 2.9.5, OrcaSlicer, FLSUN Slicer 2.0.4, CuraEngine 5.12.1, BambuStudio
Modelers: Blender 5.1.1, OpenSCAD 2021.01, trimesh 4.12.1, pymeshlab
Blocked (exact path tried recorded):
Slicers: SuperSlicer (not at C:/Program Files/SuperSlicer/), Slic3r (not installed)
Modelers: FreeCAD (FreeCADCmd not at standard paths), cadquery/build123d/numpy-stl/open3d (not importable), truck (source-inventory only)
Adds SLICER_MODULE_IDS, MODELER_PYTHON_IMPORT_IDS, MODELER_SOURCE_INVENTORY_IDS constants.
Adds _find_slicer_executable() with canonical + alt + PATH search.
Handles PrusaSlicer/OrcaSlicer/BambuStudio/FLSUN nonzero --version exit codes.
Tests: 43 new slicer/modeler probe tests + 42 existing contract tests = 85 total, all green.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(I10): reduce polling lag, fix sidebar overflow, layout fixes (#110)
- AppShell: remove lg:overflow-hidden on main in dashboard mode to prevent panel cutoff on large viewports (overflow-auto retained throughout)
- Sidebar: wrap AgentChatMirror in min-h-0 shrink container so tall chat panel no longer displaces nav items off-screen
- TopBar: fix stale data — was fetch-on-mount only; add 10 000 ms setInterval refresh for system snapshot, notifications, and proof bundle (non-critical display data)
- globals.css: no changes needed (font-size 13px and dashboard-grid overflow-hidden are intentional)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(I11): SourceOS 60-row rendering, real API wiring, panel overflow (#114)
- Fetch /api/modules/runtime/runner-contracts on mount + after Verify All / Setup Queue actions
- Map runner_status (runner_family) per module_id into a lookup dict
- ModuleList: display runner_family badge for each of the 60 rows using real runner_status from contracts endpoint
- AppDetailPanel: add runner_family header pill + RunnerContract InfoBox showing runner_status, required_verifier_family, safe_actions, acceptance_gate, and blocked_reason
- Pass runnerContract down to AppDetailPanel and refresh it in onRefresh callback
- All 60 rows rendered without slice/limit (confirmed via /api/modules count:60)
- Controls (Verify, Setup Plan, Backup, Rollback) already wired to real API — confirmed no fake handlers
- Panel overflow: AppDetailPanel section has overflow-auto in flex container with min-h-0
scan_active_ui_no_fake: 81 production files scanned, 0 findings
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(I13): print workflow — remove fake job states, policy-gate print actions (#113)
Dashboard: rename PIPELINE_STAGES to PIPELINE_STAGE_ICONS and remove the
hardcoded status:'complete'/'active' fields from the lookup table. Those
fields were dead code (PipelinePanel always derives status from live API
stage data); keeping them risked a developer treating them as truth.
Autopilot: remove EXPECTED_READINESS_CHECKS=16 magic constant. The gate
'allReady' was permanently blocked unless the backend returned exactly 16
checks — even if every returned check passed. Now allReady is true when
checks.length > 0 && all returned checks are ready (API is source of
truth). Added a "loading…" label and empty-state message while the API
response is pending so the UI never shows 0/0 as a misleading ready count.
Jobs: remove the 'counts' useMemo that injected 0 into every non-active
filter tab badge. Showing "Queued 0 | Done 0 | Failed 0" without fetching
those counts is a fake/misleading value. Now only the active filter shows
a live count; inactive filter tabs show no count badge.
Printers: no fake states found — all print actions await real API
confirmation before updating UI, and S1 policy block is correctly enforced.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(observe): real health probing in /cameras, remove fake events, fix initial feed state (#115)
- observe.py /api/observe/cameras: replaced static _configured_camera_state()
(always "configured") with a real _probe_camera_timed() call per camera so
health reflects actual connectivity, not just URL presence.
- Observe.tsx initialFeedState: cameras with health="unreachable" now start in
"error" state instead of "loading", preventing endless "CONNECTING" badge on
known-dead feeds.
- ObserveConsole.tsx: removed hardcoded fake EVENTS strings; events panel now
derives per-camera status lines from the real /api/observe/status response.
Polling interval documented (STATUS_POLL_INTERVAL_MS = 5000ms >= 3000ms).
Task: H3D-CLAUDE24-I9-OBSERVE-CAMERA
Hermes evidence chain: PASS
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(I12): agent chat blocked state, voice text+audio+mute, learning real states (#117)
- AgentChatMirror: extract real blocked reason from response body (HTTP 401
from MiniMax/DeepSeek now shows the provider error text, not just status code)
- AgentChatMirror: add explicit 'Providers blocked' banner in chat history
when agent roster is empty, with action text for G:\private\.env config
- Voice.tsx: add mute button to TTS preview (Voice Browser fine-tuning panel)
and transcript playback — muting suppresses audio but ALWAYS shows text
- Voice.tsx: text transcript displayed in all states; muted state explicitly
shown with amber indicator so user knows audio is off but text remains visible
Voice API probe: GET /api/voice/status → 404 (route not registered in backend);
GET /api/voice/providers → Azure Speech READY (configured, region=westus).
TTS routes through backend /api/voice/preview (confirmed base64 response).
Learning: real API calls only, blockers shown with real reasons (confirmed live).
No-fake scan: PASS (81 production files, no mock/fake/simulated UX markers).
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(provider): align MiniMax and DeepSeek runtime adapters (#124)
* docs(handoff): tighten Hermes runtime finish contract
* docs(sweep): PR #125 control sweep handoff + runtime finish report
- HERMES_RUNTIME_FINISH_REPORT.md: 10-agent audit results, merge
matrix, provider BLOCKED verdict (HTTP 401 both providers)
- PR125_CONTROL_SWEEP_HANDOFF_2026-05-09.md: full PR #125 sweep —
A1-A10 audit results, zombie lock recovery, secret safety PASS,
printer safety PASS, exact env key fixes required, next actions
Task: H3D-PR125-SWEEP-DOCS | Evidence: ev_dbf23c31c04af4ca, ev_a736131a4b0d8c6e
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(provider): align MiniMax and DeepSeek runtime adapters
- prefer MiniMax highspeed token-plan aliases and keep Max-Highspeed model routing explicit
- update MiniMax gateway to use MiniMax-M2.7-highspeed and max_completion_tokens
- update DeepSeek gateway/tests to use deepseek-v4-pro reasoning payload
- allow minimax/deepseek in llm policy and refresh provider rescue handoff docs
- keep provider smoke redacted; MiniMax now selects token-plan env and returns 429 insufficient_balance, DeepSeek remains 401
* docs(rescue): provider rescue blocker proof — adapters correct, blockers user-side
PR #124 provider completion sweep. Wave 1-3 audit:
- MiniMax adapter (gateways/providers/minimax.py): CORRECT per official docs.
Reaches api.minimax.io. HTTP 429 insufficient_balance (1008) is
provider-side billing/quota, NOT code, NOT auth.
- DeepSeek adapter (gateways/providers/deepseek.py): CORRECT per official
docs. Posts to api.deepseek.com/chat/completions with thinking +
reasoning_effort for v4-pro. HTTP 401 = "wrong API key" per
api-docs.deepseek.com/quick_start/error_codes (single documented cause).
No code fix needed. Both blockers are out-of-repo user actions:
1. MiniMax: top up Token Plan balance / OAuth portal auth at platform.minimax.io
2. DeepSeek: rotate DEEPSEEK_API_KEY in G:/private/.env
Hermes Agent loop remains BLOCKED until both providers return accepted:true.
Evidence: ev_cffabca307652c21 (minimax), ev_bdec2f02c01c17ec (deepseek),
ev_491fe9d07426cab4 (adapter audit).
Task: H3D-CLAUDE-PROVIDER-COMPLETION.
No private values exposed.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(code-operator): expose redacted CLI provider env contract
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* docs(agent): tighten control gates (#125)
* docs(rescue): mark blocker proof SUPERSEDED — providers now PASS (#132)
First proof-gated Hermes Agent coding loop. The full chain ran end-to-end
including a real recovery cycle:
MiniMax build (artifact 08c8dce66b3a4a589572cee225f2b428)
-> DeepSeek review v1 BLOCKED_ON_INSUFFICIENT_EVIDENCE
-> v1 proposal 8365f7833f10... DeepSeek APPROVE ev_675dcddbd474c55d
-> apply -> git-diff-check FAIL on trailing whitespace from ` ` line breaks
-> rollback to snapshot 6f478adcf452 (proof 245d7fd376fc)
-> v2 proposal f07e6af14f5f authored without trailing whitespace
-> DeepSeek APPROVE v2 ev_59947bb44bf1715a
-> apply -> git-diff-check PASS gate_git-diff-check_1778295564288
Provider smoke evidence baked into the SUPERSEDED block text:
minimax ev_4a52d9b1336ca9f2 HTTP 200 MiniMax-M2.7-highspeed
deepseek ev_e708071cb269f170 HTTP 200 deepseek-v4-pro
No private values exposed. Same-owner MCP locks throughout.
Task: H3D-FIRSTLOOP-001-SUPERSEDE
Hermes evidence: f07e6af14f5f4db3972fdc1bb336bd35, ev_59947bb44bf1715a, ev_675dcddbd474c55d, ev_4a52d9b1336ca9f2, ev_e708071cb269f170, ev_a2780d9832e5567a, ev_95e16427ce056505, ev_69e00f87178d6f9c
* feat(recovery): Hermes Agent Recovery Controller v1 (lean ledger) (#133)
First lean v1 of the Hermes Agent Recovery Controller, born from the
recovery cycles in PR #126. Backend ledger ONLY: no UI, no autonomous
apply, no file mutation by the controller. Future-proof v1.5 schema
fields included so the upcoming Hermes Agent Task Monitor UI can read
rich state without backend refactor.
What ships:
- code_history.py: RECOVERY_FAILURE_CLASSES (9), RECOVERY_OUTCOME_STATUSES
(3), RECOVERY_FAILED_STEP_TYPES (10), RECOVERY_RECOMMENDED_ACTIONS (8),
RECOVERY_REDACTION_STATUSES (3), RECOVERY_WORKER_OUTPUT_STATUSES (6),
RECOVERY_AGENT_STACK_VALUES (8), _RECOVERY_LEDGER_PATH, plus
record_step_failure(), mark_recovery_outcome(), list_recovery_attempts().
Adds `import secrets` and `from hermes3d.gateways.redaction import
redact_text` to imports.
- code_operator.py: RecoveryRecordFailureRequest, RecoveryMarkOutcomeRequest
StrictBody models + 3 routes: POST /recovery/record-failure, POST
/recovery/mark-outcome, GET /recovery/state.
- test_code_operator.py: 7 lean v1 tests covering record/reject/redact/
mark/state via TestClient with unique uuid4 task_ids.
- docs/handoffs/REVIEW_PACKET_*.md: 4 proof artifacts (full diff +
contract per file) used in DeepSeek per-file review.
Provenance chain (each step proof-anchored):
- MiniMax artifacts 2130e9e1d12d4686ac4d788bfd136673 (build pass 1) +
459bc9c00d6049dd949fa84e61f09c7a (build pass 2). BOTH truncated by
completion-token budget. Manual fixes preserved chain-of-custody:
(a) merge_conflict -> merge_git_fail (test class typo)
(b) test_state_route_returns_attempts re-authored from truncation
(c) `import secrets` added (MiniMax used secrets.token_hex without
adding the import)
(d) v1.5 future-proof fields added per user spec
- Per-file DeepSeek review APPROVE:
code_history.py proposal b63cd8b665bf4c2488591f8350b91cf5
review ev_5635d54ac7fdcec7
code_operator.py proposal 7b76f0eae91a4f0d8c80850fcef0b4f0
review ev_d9225ed939f77eb2
test_code_operator proposal 33d7dbc691b146f7a495c6c23fa148b0
review ev_4d1ca4217e6b226c
- Recovery cycle (gate failure -> targeted fix):
pytest NameError: redact_text -> follow-up proposal
fe2371073c3d4267b5e0e049df13e5b7 -> DeepSeek APPROVE
ev_5586c466df5d59aa -> applied evidence ev_647bfc4e38e0738f.
Gates after final apply:
- python -m py_compile (code_history.py + code_operator.py): exit 0
- python -m pytest test_code_operator.py: 50 passed
- scan_active_ui_no_fake.py: 81 files, 0 markers
- git diff --check: exit 0
- hermes_run_gate git-diff-check: PASS gate_git-diff-check_1778298845085
Provider smoke evidence still PASS: minimax ev_4a52d9b1336ca9f2,
deepseek ev_e708071cb269f170. No private values exposed.
Next slice (separate PRs): autonomous repair dispatch (v2), Hermes Agent
Task Monitor UI (v3). v0.13.0 upstream Hermes Agent update is its own
proof-gated lane.
Task: H3D-RECOVERY-CTL-V1
Hermes evidence: b63cd8b665bf4c2488591f8350b91cf5, 7b76f0eae91a4f0d8c80850fcef0b4f0, 33d7dbc691b146f7a495c6c23fa148b0, fe2371073c3d4267b5e0e049df13e5b7, ev_5635d54ac7fdcec7, ev_d9225ed939f77eb2, ev_4d1ca4217e6b226c, ev_5586c466df5d59aa, ev_788974be0aa90ccd, ev_cbdcc4bca447d895, ev_e1ba5ddf993149bb, ev_647bfc4e38e0738f, ev_4a52d9b1336ca9f2, ev_e708071cb269f170
* docs(gui): add Hermes3D OS visual reference pack (#134)
* fix(agent-updates): harden staged-update pytest gate (Audit PR #135 follow-up) (#136)
Mirrors upstream NousResearch/hermes-agent tests.yml flags so the staged
update gate cannot fake-pass while v0.13.0 is formally deferred. Closes
the CICD-SEC-1 / Codecov-2021-style fake-pass surface in
_run_update_checks.
Patch
- Path ignores: --ignore=tests/integration --ignore=tests/e2e match
upstream tests.yml. Marker-only -m "not integration" cannot block
tests/e2e/conftest.py from polluting sys.modules at collection time
(sys.modules["discord"] = MagicMock leak proven during Cplus-py311
Phase 4 bisection).
- Workers env: HERMES_AGENT_PYTEST_WORKERS (default "4", mirrors GHA
4-vCPU runner). Production rejects <2 with HTTPException(400);
HERMES_AGENT_DIAGNOSTIC=1 overrides for triage. "auto" sentinel
accepted. Garbage strings raise 400.
- maxfail: 1 in production (matches upstream tests.yml), 5 in
diagnostic mode for triage-friendly multi-failure output.
- Skip path now fail-closed: missing HERMES_AGENT_RUN_PYTEST surfaces
as status="fail" with "REQUIRES_CONFIRMATION:" output, never
status="skipped" or 200/OK. Removes the fake-pass path that let
pytest=skipped roll up as gate=verified.
- Timeout 300s -> 600s. Larger collected set under upstream-aligned
--ignore needs the longer budget.
Tests
- 04_testing/pytest/unit/test_agent_updates_meta.py (3 tests):
upstream tests.yml still has both --ignore= flags (network test,
skip-on-offline), local source mirrors them, diagnostic+workers
guard names + default value present.
- 04_testing/pytest/unit/test_agent_updates_skip_path.py (11 tests):
skip-path fail-closed when env unset/zero, workers 0/1 rejected in
production, workers 0 allowed in diagnostic mode, garbage raises
400, default workers="4", path-ignores in pytest args, diagnostic
uses --maxfail=5, "auto" sentinel accepted.
Result: 14/14 pass on 04_testing/pytest/unit.
Scope
- v0.13.0 update remains formally deferred (Cplus-defer-formal).
- This PR fixes the gate only; no runtime update was installed.
- Sources: PR #135 / commit 5ecd8ff (Batch 2 Agent 6 + Agent 10).
Follow-ups (separate PRs)
- Bonus 12: recovery ledger file lock, mark_recovery_outcome
idempotency, agent_updates.py:115 HTTPException auto-repair gap,
apply_patch_proposal TOCTOU.
- Bonus 13: 60-app audit doc errata (loader-real registry path,
42 SPDX-invalid licenses).
- Upstream Agent 11 tickets (firmware archive-dir validator deferred
here; YAML schema lacks the field today).
References
- https://raw.githubusercontent.com/NousResearch/hermes-agent/main/.github/workflows/tests.yml
- https://docs.pytest.org/en/stable/example/pythoncollection.html#ignore-paths-during-test-collection
- https://owasp.org/www-project-top-10-ci-cd-security-risks/
- https://about.codecov.io/apr-2021-post-mortem/
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(recovery): close Bonus 12 ledger races + auto-repair escape (PR #135) (#137)
Three findings from the Bonus 12 audit (PR #135 / bonus12-bug-finder.md):
Finding #1 (blocker, services/code_history.py recovery ledger)
- Append-without-lock allowed concurrent record_step_failure /
mark_recovery_outcome calls to interleave partial JSONL lines on
Windows. mark_recovery_outcome would silently json.JSONDecodeError-
skip the corrupted entries and report "attempt_id not found".
- Fix: new _RecoveryLedgerLock context manager that combines a
process-local threading.Lock with an OS-level advisory lock on a
sidecar lockfile. Uses fcntl.flock on POSIX and msvcrt.locking on
Windows; both stdlib, no new deps. flush()+os.fsync() on every
append.
Finding #2 (major, mark_recovery_outcome)
- No idempotency check: a retry could append a SECOND outcome row,
producing ambiguous state for list_recovery_attempts consumers.
- Fix: read scan now happens inside the same lock as the append.
If any outcome row for attempt_id already exists, raise
ValueError("already has a recorded outcome") atomically.
Finding #3 (major, agent_updates.py:115)
- _run_git raises HTTPException(502) on non-zero exit. A failed
mid-step "git checkout --detach <tag>" escaped the for-tag loop
without reaching _auto_repair_to_backup, leaving the Hermes Agent
checkout on the previous (still-unverified) tag and surfacing 502
to the caller instead of structured rollback.
- Fix: wrap the per-tag checkout + _run_update_checks in
try/except HTTPException; record a synthetic step failure with the
redacted detail and pivot to _auto_repair_to_backup. Also catches
the HERMES_AGENT_PYTEST_WORKERS validation 400 added in PR #136.
Tests added (11 total, all green)
- 04_testing/pytest/unit/test_recovery_ledger_locking.py (8 tests)
* lock helper exposes a backend (fcntl/msvcrt/thread-only)
* 12-thread x 25-write concurrency test: every line round-trips
through json.loads (no torn writes)
* record_step_failure writes complete JSONL line + creates parent
directory + lockfile sidecar
* mark_recovery_outcome first call succeeds; second call raises
ValueError with "already has a recorded outcome"
* unknown attempt_id still raises "not found in recovery ledger"
* race test: two threads finalize same attempt_id; exactly one
succeeds, one raises idempotency error
- 04_testing/pytest/unit/test_agent_updates_auto_repair.py (3 tests)
* failed checkout pivots to _auto_repair_to_backup (no 502 escape)
* failed _run_update_checks (workers env 400) also pivots
* all-pass path unchanged (smoke regression guard)
Verification
- py_compile: OK on all 4 files
- Focused tests: 25/25 pass (11 new + 14 from PR #136)
- Pre-existing failures in test_source_runtime_contracts.py (5
firmware tests blocked instead of ready) confirmed pre-existing
on base; out of scope for this PR.
Scope
- Recovery Controller v2 (RC v2) commits 2-5 stay paused per user
instruction; RC v2 depends on the recovery correctness this PR
restores.
- Hermes Agent v0.13.0 update remains formally deferred.
- Bonus 13 audit doc errata is out of scope (separate PR).
References
- https://docs.python.org/3/library/fcntl.html#fcntl.flock
- https://docs.python.org/3/library/msvcrt.html#msvcrt.locking
- https://about.codecov.io/apr-2021-post-mortem/
- https://owasp.org/www-project-top-10-ci-cd-security-risks/
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(agent-updates): harden _zip_dirty_entries (Bonus 12 #4 / PR #135) (#138)
Defense-in-depth on the dirty-files backup zip in
api/routes/agent_updates.py:_zip_dirty_entries.
Pre-fix issues
- Opened the zip without allowZip64=True, so >4 GiB dirty backups
silently truncate on Python builds that default to no-zip64.
- Used path.relative_to(repo) against an un-resolved repo path,
raising ValueError and aborting the whole backup whenever the repo
path is itself a symlink.
- A symlink in the dirty tree could resolve to a target outside the
repo and still produce an arcname inside the archive, surfacing
CWE-22 path traversal on extract.
Post-fix
- allowZip64=True passed to ZipFile.
- path.is_symlink() check skips symlinks defensively (even though
_dirty_entries usually pre-resolves; tests / future callers may not).
- Arcname computed against repo.resolve() so symlinked checkouts
(e.g. /tmp/repo -> /var/checkout) work cleanly.
- Arcname asserted to be a pure relative path (no absolute,
drive-letter, parent-traversal, or empty components).
- Resolved-target paths that fall outside the repo are silently
dropped instead of leaking into the archive.
Tests added (8, all green)
- 04_testing/pytest/unit/test_agent_updates_zip_dirty.py
* normal files round-trip with relative arcnames
* empty paths list short-circuits without creating an archive
* symlinks (in-repo target) skipped — CWE-22 guard
* symlinks (out-of-repo target) skipped — exfiltration guard
* symlinked repo root produces correct arcname (no ValueError)
* out-of-repo path silently dropped
* allowZip64=True passed (probe via ZipFile subclass)
* pathological absolute Path components silently dropped
Verification
- py_compile: OK
- 25/25 agent_updates-keyed unit tests pass
- Secret-leak scan on touched files: only descriptive test fixture
string "outside-secret" (not a real secret)
- Pre-push hook: passed
Scope
- Bonus 12 finding #4 only (continuing the controlled-batch pattern
from PR #137).
- v0.13.0 update remains formally deferred.
- RC v2 commits 2-5 remain paused per user instruction.
References
- https://docs.python.org/3/library/zipfile.html#zipfile.ZipFile
- https://cwe.mitre.org/data/definitions/22.html
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* docs(audit): 60-App Update Readiness Audit (docs-only, no runtime change) (#135)
* docs(audit): 60-App Update Readiness Audit + Phase 4 v2 patch proposal
Audit/planning lane only. No app updates. No GUI changes. No source mutation
beyond this doc. Hermes Agent v0.13.0 stays formally deferred per the
2026-05-09 user decision in handoffs/HERMES_AGENT_V013_UPDATE_LANE_CPLUS_PY311_DOCKER_FORMAL_DEFER.
What's in the audit:
- Per-app profile matrix: 60 rows across 11 sections (slicers 11 / modelers 13
/ 3D-gen 6 / print-farm 10 / firmware 6 / agent-cli 7 / library 1 / materials
1 / hardware 3 / utilities 1 / research 1). Each row: update method, proof
command, runtime env, deps, rollback method, blockers, recommended lane,
auto-upd…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: H3D-CLAUDE24-I14-PROOF-GATES, Hermes evidence chain: PASS, scan result: 81 active production UI files, 0 fake markers, PASS, date updated: 2026-05-08. Only locked file touched: 03_implementation/proof/ACTIVE_UI_NO_FAKE_SWEEP.md
Summary by CodeRabbit
Documentation
Configuration
Infrastructure