-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
myFriendDevices should use 'following', not 'followers' #16
Comments
Pull request submitted (3 lines, not 2 :-) ) |
Hi Can you follow without being a follower - I thought is was both ways or nothing? You can stop sharing location with individuals, but not sure can follow but not be a following - if follow?!? |
Yes, it can be one way. If you add a person (for example the special Indigo iCloud account you’ve created) in the Find Friends app on a person’s iOS device, the Indigo iCloud account becomes a follower and gets a notification to this effect. If you explicitly do not share the Indigo iCloud account’s location in return, it never becomes a follower. Thus, it is following, but not a follower. |
Thanks |
Thanks!! |
Currently in the
myFriendDevices
method inplugin.py
, we iterate over the 'followers' data in friends.data. This means that if you set up an iCloud account to use with FindFriendsMini, and then have it follow other accounts that do not in turn follow back, then the 'followers' list will be empty! As a result, you won't find any friends in the targetFriend drop down list when configuring the settings for a new FindFriends DeviceInstead, we should iterate over the 'following' data, and pull out the 'invitationAcceptedByEmail' for the human readable label ('id' is still the correct thing to pull from 'following' data).
This way the iCloud account only has to follow the other accounts we are interested in the location of, and not vice versa.
I will create a pull request with the two line patch to fix this issue.
The text was updated successfully, but these errors were encountered: