Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

myFriendDevices should use 'following', not 'followers' #16

Closed
ZachBenz opened this issue Feb 5, 2018 · 5 comments
Closed

myFriendDevices should use 'following', not 'followers' #16

ZachBenz opened this issue Feb 5, 2018 · 5 comments

Comments

@ZachBenz
Copy link
Contributor

ZachBenz commented Feb 5, 2018

Currently in the myFriendDevices method in plugin.py, we iterate over the 'followers' data in friends.data. This means that if you set up an iCloud account to use with FindFriendsMini, and then have it follow other accounts that do not in turn follow back, then the 'followers' list will be empty! As a result, you won't find any friends in the targetFriend drop down list when configuring the settings for a new FindFriends Device

Instead, we should iterate over the 'following' data, and pull out the 'invitationAcceptedByEmail' for the human readable label ('id' is still the correct thing to pull from 'following' data).

This way the iCloud account only has to follow the other accounts we are interested in the location of, and not vice versa.

I will create a pull request with the two line patch to fix this issue.

ZachBenz added a commit to ZachBenz/IndigoPlugin-iFindFriendMini that referenced this issue Feb 5, 2018
@ZachBenz
Copy link
Contributor Author

ZachBenz commented Feb 5, 2018

Pull request submitted (3 lines, not 2 :-) )

@Ghawken
Copy link
Owner

Ghawken commented Feb 5, 2018

Hi
Do follow - and should just pull

Can you follow without being a follower - I thought is was both ways or nothing?

You can stop sharing location with individuals, but not sure can follow but not be a following - if follow?!?

Ghawken pushed a commit that referenced this issue Feb 5, 2018
@ZachBenz
Copy link
Contributor Author

ZachBenz commented Feb 5, 2018

Yes, it can be one way. If you add a person (for example the special Indigo iCloud account you’ve created) in the Find Friends app on a person’s iOS device, the Indigo iCloud account becomes a follower and gets a notification to this effect. If you explicitly do not share the Indigo iCloud account’s location in return, it never becomes a follower. Thus, it is following, but not a follower.

@Ghawken
Copy link
Owner

Ghawken commented Feb 5, 2018

Thanks
Merged. Still not sure iFriendsApp lets you follow one way?. But regardless if the data the same from both followers and following - you are correct this is the way to do it.
Just seen your reply
Thanks
G

@ZachBenz
Copy link
Contributor Author

ZachBenz commented Feb 5, 2018

Thanks!!

Ghawken pushed a commit that referenced this issue Feb 5, 2018
Adds ZachBenz fix for 'followers versus following'
Code was using followers, but should have used those we were following.
In case a someone we were following isn't a follower!
See github issue #16
@Ghawken Ghawken closed this as completed Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants