Move reusable methods to a separate helper class #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we allow other apps such as Geyser LocalSession to use these currently private methods without needing to copy over the code.
AlexProgrammerDE
force-pushed
the
feature/shared-netty-helper
branch
from
1dac349 to
f49b668
Compare
onebeastchris
added a commit
that referenced
this pull request
Dec 5, 2024
* Move reusable methods to a separate helper class (#863) * Move reusable methods to a separate helper class This way we allow other apps such as Geyser LocalSession to use these currently private methods without needing to copy over the code. * Remove unused field * Improve MCPL ticking data and behaviour (#865) * Move packets to proper packages & implement game thread metadata for every packet * Add new ticking info for 1.21.3 Notable info: ServerboundSelectBundleItemPacket is not ticked, it's instant ClientboundSetHeldSlotPacket is already ticked as it is just renamed ClientboundSetCarriedItemPacket * Expose packet handler executor * Do not tick delimiter packet * Allow server to define packet handler executor factory * Update protocol/src/main/java/org/geysermc/mcprotocollib/network/packet/Packet.java Co-authored-by: chris <[email protected]> --------- Co-authored-by: chris <[email protected]> * Implement missing ticking --------- Co-authored-by: chris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we allow other apps such as Geyser LocalSession to use these currently private methods without needing to copy over the code.