Static sizer and timeout handlers in the pipeline #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies all pipeline code and ensures some listeners like the sizer are always present. The code already assumed that the sizer is always there and thus causes issues. The sizer can be deactivated still now and has pretty much no performance losses from this. The profit from this PR is that there is less logic with modifying the PR and thus developers interacting with the channel can assume specific things about the order and placements of elements in the pipeline. This will be useful once ViaVersion is supported, and it is expected that certain elements always are in the pipeline and don't change. My plan is to also always have an encryption and compression handler in the pipeline that is controlled via AttributeKeys from netty, but for that first GeyserMC#828 needs to be merged. So this PR only completes the goal partially, but that's fine. PR is ready for review like it is right now.
Konicai
requested changes
Jul 12, 2024
protocol/src/main/java/org/geysermc/mcprotocollib/network/BuiltinFlags.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/network/BuiltinFlags.java
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/network/tcp/TcpClientSession.java
Outdated
Show resolved
Hide resolved
# Conflicts: # protocol/src/main/java/org/geysermc/mcprotocollib/network/tcp/TcpSession.java
Konicai
approved these changes
Jul 28, 2024
protocol/src/main/java/org/geysermc/mcprotocollib/network/BuiltinFlags.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/network/BuiltinFlags.java
Show resolved
Hide resolved
…tinFlags.java Co-authored-by: Konicai <[email protected]>
…tinFlags.java Co-authored-by: Konicai <[email protected]>
Konicai
changed the title
Redned235
approved these changes
Sep 8, 2024
onebeastchris
approved these changes
Sep 8, 2024
protocol/src/main/java/org/geysermc/mcprotocollib/network/BuiltinFlags.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/network/BuiltinFlags.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/network/BuiltinFlags.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/network/tcp/TcpServer.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/network/tcp/TcpServer.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/network/tcp/TcpServer.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/network/tcp/TcpServer.java
Outdated
Show resolved
Hide resolved
…tinFlags.java Co-authored-by: chris <[email protected]>
…TcpServer.java Co-authored-by: chris <[email protected]>
…tinFlags.java Co-authored-by: chris <[email protected]>
…tinFlags.java Co-authored-by: chris <[email protected]>
…TcpServer.java Co-authored-by: chris <[email protected]>
…TcpServer.java Co-authored-by: chris <[email protected]>
…TcpServer.java Co-authored-by: chris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies all pipeline code and ensures some listeners like the sizer are always present. The code already assumed that the sizer is always there and thus causes issues. The sizer can be deactivated still now and has pretty much no performance losses from this. The profit from this PR is that there is less logic with modifying the pipeline and thus developers interacting with the channel can assume specific things about the order and placements of elements in the pipeline. This will be useful once ViaVersion is supported, and it is expected that certain elements always are in the pipeline and don't change. My plan is to also always have an encryption and compression handler in the pipeline that is controlled via AttributeKeys from netty, but for that first #828 needs to be merged. So this PR only completes the goal partially, but that's fine. PR is ready for review like it is right now.