Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a way for "geyser_custom" blocks to be recognized by the reader. #5300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OmeWillem
Copy link

Title says it all.

@duranaaron
Copy link

+1, I would really like this to be implemented as well

@OmeWillem
Copy link
Author

Any news on this being merged maybe?

@onebeastchris
Copy link
Member

I'm unsure whether this is, right now, a good API addition. Few issues:

  • This PR is currently wholly undocumented, which for API is generally terrible

  • This PR makes use of code - mainly the NonVanilaCustomBlockData class - that has an initially different purpose, hence there's some behaviour that wouldn't be triggered for it (which would be for CustomBlockData itself).
    That's not necessarily a blocker, but this PR lacks any description of e.g. an example mapping/usage that's possible with this change that isn't possible without it.

  • As mentioned above - it would be ideal if there would be a provided mapping example, with a clear description of what this PR enables (and what isn't possible without it). That way, we can properly test and review it, and account for this behaviour when we eventually refactor code. As an example, see Fix: Allow adding custom items to the creative item list to allow custom recipes to show up in the recipe book #4484 :)

In short - we're open to add features and are thankful for PRs. However, we'll need more details on what this enables doing that's not possible without it, so we can properly account for it when reviewing / when refactoring code in the future / when considering API design in a potential V2 :)

(final note - what's that collision check for? Does that issue still occur with the latest version of Geyser that registers collisions for custom blocks?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants