Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map colors #5239

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Fix map colors #5239

merged 2 commits into from
Dec 27, 2024

Conversation

rtm516
Copy link
Member

@rtm516 rtm516 commented Dec 22, 2024

This is revert and re-fix of #5238

This keeps the enum values stored in the file as RGB while correctly sending them as BGR over the network for the client.

Not required but makes it clearer when working with that part of the code.

@rtm516 rtm516 added PR: Optimization When a PR doesn't necessarily add anything new or fix anything, but improves upon the code PR: Cosmetic When a PR adds something that is purely cosmetic, like changing the README labels Dec 22, 2024
@onebeastchris onebeastchris merged commit 623ec2b into GeyserMC:master Dec 27, 2024
2 checks passed
@rtm516 rtm516 deleted the fix/map-colors branch December 27, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Cosmetic When a PR adds something that is purely cosmetic, like changing the README PR: Optimization When a PR doesn't necessarily add anything new or fix anything, but improves upon the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants