Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5089 and don't auto-load Registries #5093

Merged
merged 4 commits into from
Oct 27, 2024
Merged

Fix #5089 and don't auto-load Registries #5093

merged 4 commits into from
Oct 27, 2024

Conversation

Tim203
Copy link
Member

@Tim203 Tim203 commented Oct 21, 2024 •
edited
Loading

Also fixes #5080

@Tim203 Tim203 requested review from Camotoy and Redned235 October 21, 2024 12:50
@rtm516 rtm516 linked an issue Oct 21, 2024 that may be closed by this pull request
NPC does not display the correct name #5089
Closed
@rtm516 rtm516 added PR: Bugfix When a PR contains a bugfix PR: Optimization When a PR doesn't necessarily add anything new or fix anything, but improves upon the code labels Oct 21, 2024
onebeastchris
onebeastchris reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@onebeastchris onebeastchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the java imports would also probably be better suited for a different PR, otherwise future Pars touching these classes will create unnecessary diff

@Tim203 Tim203 changed the title Fix #5089 and made Registries instance based Fix #5089 and don't auto-load Registries Oct 25, 2024
onebeastchris
onebeastchris approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@onebeastchris onebeastchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than these, looks good

core/src/main/java/org/geysermc/geyser/entity/type/living/ArmorStandEntity.java Outdated Show resolved Hide resolved
...g/geysermc/geyser/translator/protocol/java/entity/player/JavaPlayerInfoUpdateTranslator.java Outdated Show resolved Hide resolved
core/src/test/java/org/geysermc/geyser/scoreboard/network/ScoreboardIssueTests.java Outdated Show resolved Hide resolved
core/src/test/java/org/geysermc/geyser/scoreboard/network/ScoreboardIssueTests.java Outdated Show resolved Hide resolved
core/src/main/java/org/geysermc/geyser/registry/loader/RegistryLoaderHolder.java Show resolved Hide resolved
@Tim203 Tim203 mentioned this pull request Oct 27, 2024
Open
@Tim203 Tim203 merged commit d6d19b0 into master Oct 27, 2024
3 checks passed
@Tim203 Tim203 deleted the fix/5089 branch October 27, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onebeastchris onebeastchris onebeastchris approved these changes

@Camotoy Camotoy Camotoy approved these changes

@Redned235 Redned235 Awaiting requested review from Redned235

Assignees
No one assigned
Labels
PR: Bugfix When a PR contains a bugfix PR: Optimization When a PR doesn't necessarily add anything new or fix anything, but improves upon the code
Projects
None yet
Milestone
No milestone
4 participants
@Tim203 @Camotoy @onebeastchris @rtm516