Packet cooldowns and content validation #4782
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I do not know why they saved it if it is not used anywhere If they decide it is necessary, only one UUID is sent when changing emotions, with a limit of 50 I think that is sufficient, and the outdated ones can simply be deleted
Fix from qrvprox
check if the code is working correctly
Вроде все работает нет времени в данный момент
core/src/main/java/org/geysermc/geyser/network/UpstreamPacketHandler.java
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/translator/protocol/bedrock/BedrockTextTranslator.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/translator/protocol/bedrock/BedrockTextTranslator.java
Outdated
Show resolved
Hide resolved
Comment on lines
43
to
48
| if (command.length() > 512) { | ||
| // A legitimate player cannot send more than 512 characters | ||
| // This is necessary so that the conversion to plain text is not clogged | ||
| session.sendMessage(GeyserLocale.getPlayerLocaleString("geyser.chat.too_long", session.locale(), command.length())); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Also, if the game does not allow you to submit more than 512 characters from a player, I think here you can already get into the protocol
core/src/main/java/org/geysermc/geyser/network/CodecProcessor.java
Outdated
Show resolved
Hide resolved
|
I hope this limit will make in CloudburstMC/Protocol, I have no desire to go there |
Kas-tle
requested changes
Jun 24, 2024
core/src/main/java/org/geysermc/geyser/network/CodecProcessor.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/translator/protocol/bedrock/BedrockTextTranslator.java
Outdated
Show resolved
Hide resolved
| @@ -136,6 +105,87 @@ public void deserialize(ByteBuf buffer, BedrockCodecHelper helper, InventorySlot | |||
| } | |||
| }; | |||
|
|
|||
|
|
|||
| /** | |||
| * The player can cause a packet error themselves, which hackers can exploit to spam legitimate errors | |||
There was a problem hiding this comment.
I don't understand this comment. We now disconnect on the first error for any packet. Regardless, this seems like it should be a change in protocol, not Geyser. Changes in here should only be things we can do as a result of fields we do not need in Geyser.
core/src/main/java/org/geysermc/geyser/network/CodecProcessor.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/network/PacketCooldownManager.java
Outdated
Show resolved
Hide resolved
| import java.util.Map; | ||
|
|
||
| public class PacketCooldownManager { | ||
| private final Map<String, CooldownSettings> packetCooldownSettings = new HashMap<>(); |
core/src/main/java/org/geysermc/geyser/network/PacketCooldownManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/network/PacketCooldownManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/network/UpstreamPacketHandler.java
Outdated
Show resolved
Hide resolved
|
The pull request is ready, please check |
|
Unfortunately, it's not. Please address the notes in kastle's review, such as the imports. Further, some of Kastle's questions haven't been answered. |
|
please check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.