Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preferences system and api #3958

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Preferences system and api #3958

wants to merge 4 commits into from
+647 −107

Conversation

Konicai
Copy link
Member

@Konicai Konicai commented Jul 10, 2023 •
edited by onebeastchris
Loading

  • actually expose the system to the api
  • fix onUpdate
  • allow not providing a cumulus Component (don't show in settings form)
  • player leave event
  • testing
  • javadoc
  • i'll write more here later when this is more filled in

@Konicai Konicai marked this pull request as ready for review July 12, 2023 08:39
Camotoy
Camotoy reviewed Aug 6, 2023
View reviewed changes
api/src/main/java/org/geysermc/geyser/api/connection/GeyserConnection.java
@@ -95,4 +98,12 @@ public interface GeyserConnection extends Connection, CommandSource {
*/
@NonNull
Set<String> fogEffects();

<T> void storePreference(@NonNull PreferenceKey<T> key, @NonNull Preference<T> preference);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javadocs here please. We should emphasize this system is Geyser and not Bedrock.

Camotoy
Camotoy reviewed Aug 6, 2023
View reviewed changes
api/src/main/java/org/geysermc/geyser/api/preference/Preference.java

import java.util.Objects;

public abstract class Preference<T> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javadoc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the structure is finalized :p

This was referenced Aug 15, 2023
Open
Merged
@Konicai Konicai added the PR: On hold When a PR is on hold like if it requires a dependency to be updated first label Sep 2, 2023
@Konicai Konicai added the API The issue/feature request relates to the Geyser API label Oct 8, 2023
@onebeastchris onebeastchris marked this pull request as draft August 20, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camotoy Camotoy Camotoy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
API The issue/feature request relates to the Geyser API PR: On hold When a PR is on hold like if it requires a dependency to be updated first
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Konicai @Camotoy