137.5 to main #64
Merged
137.5 to main #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: None Change-Id: Ie17600e64fb5054ed3baa0f424bdd3adfa728c37 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/370440 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Fredrik Solenberg <[email protected]> Cr-Commit-Position: refs/heads/main@{#44272}
Bug: None Change-Id: I311de0a6c889bba216cdb2e7b7f1f96abbb9fad7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383760 Commit-Queue: [email protected] <[email protected]> Bot-Commit: [email protected] <[email protected]> Cr-Commit-Position: refs/heads/main@{#44273}
Files moved, - boringssl_certificate.h - buffer_queue.h - byte_buffer.h - data_rate_limiter.h - recursive_critical_section.h - dscp.h - file_rotating_stream.h - ifaddrs_converter.h - log_sinks.h - fifo_buffer.h - memory_stream.h - message_digest.h - win32.h - rate_tracker.h - openssl_digest.h - openssl_key_pair.h - memory_usage.h - ssl_certificate.h - ssl_adapter.h - platform_thread_types.h - ssl_fingerprint.h - cpu_time.h - proxy_server.h - boringssl_identity.h - string_utils.h - default_socket_server.h - openssl_session_cache.h - net_helpers.h - network.h - network_monitor_factory.h - network_route.h - sent_packet.h - openssl_adapter.h - openssl_stream_adapter.h - operations_chain.h - net_helper.h No-Iwyu: ssl and socket related files don't play well it include cleaner Bug: webrtc:42232595 Change-Id: I949cf4e8be6dab99ce170d8c7388c84fdcdd6447 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/382520 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Evan Shrubsole <[email protected]> Cr-Commit-Position: refs/heads/main@{#44274}
Bug: webrtc:42226242 Change-Id: Iba74c0eb4038950243de71ec695923f1b4913eac Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383401 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Jeremy Leconte <[email protected]> Cr-Commit-Position: refs/heads/main@{#44275}
The testcase name is set differently when uploading the metrics to CPD based on the presence of the isolated_script_test_perf_output flag. Change-Id: I9eae262383c9492b97703794b291050a602fb54b Bug: webrtc:14757 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383720 Reviewed-by: Artem Titov <[email protected]> Commit-Queue: Jeremy Leconte <[email protected]> Cr-Commit-Position: refs/heads/main@{#44276}
This avoids waiting for encoding when fetching the stats, which is currently done on the worker thread. Bug: None Change-Id: I08e853a2edc403b545920d154ae9604aab7a32a0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383820 Reviewed-by: Henrik Lundin <[email protected]> Commit-Queue: Jakob Ivarsson <[email protected]> Cr-Commit-Position: refs/heads/main@{#44277}
Chromium change: https://chromium-review.googlesource.com/c/chromium/src/+/6415653 CL is to unblock the Chromium roll into WebRTC (https://ci.chromium.org/ui/p/webrtc/builders/cron/Auto-roll%20-%20WebRTC%20DEPS). Change-Id: Iaf7813f6e85fb411bf263cf0f4eeaa3e250833c8 Bug: None Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383860 Commit-Queue: Jeremy Leconte <[email protected]> Reviewed-by: Ilya Nikolaevskiy <[email protected]> Cr-Commit-Position: refs/heads/main@{#44278}
which allows testing DTLS-in-STUN for forward-compatibility and evaluate the general readyness. This change is guarded under the field trial WebRTC-EnableDtlsPqc The code is modelled after Chromiums ssl_client_socket_impl: https://source.chromium.org/chromium/chromium/src/+/main:net/socket/ssl_client_socket_impl.cc;l=646 See also w3c/webrtc-extensions#207 BUG=webrtc:404763475 Change-Id: Ibede93045cafd42b6304b1c040fbf3bd74fa601e No-Iwyu: IWYU gets confused by defines Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/381681 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Jonas Oreland <[email protected]> Reviewed-by: Jonas Oreland <[email protected]> Cr-Commit-Position: refs/heads/main@{#44279}
- video_sink_interface.h - video_source_interface.h - video_source_base.h - packet_transport_internal.h - transport_description_factory.h - rolling_accumulator.h - video_broadcaster.h - ssl_identity.h - adapted_video_track_source.h - string_encode.h No-Iwyu: Too many errors due to tool never being run before (3p libraries like openssl and perfetto confuse the tool too much). Bug: webrtc:42232595 Change-Id: Id2e4ab137515e5d3c9bd7ac0daa5fd39d84e0e10 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383781 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Evan Shrubsole <[email protected]> Cr-Commit-Position: refs/heads/main@{#44280}
Bug: webrtc:405883462 Change-Id: Ib42c52f76a1fbdf480608897bdad1306c3709314 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383024 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Danil Chapovalov <[email protected]> Cr-Commit-Position: refs/heads/main@{#44281}
Change log: https://chromium.googlesource.com/chromium/src/+log/43e4a99fb3..c87b2ac78e Full diff: https://chromium.googlesource.com/chromium/src/+/43e4a99fb3..c87b2ac78e Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/1d80e43078..e62aa1e0a8 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/52d62707ea..7f64565e57 * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/6f359296da..299cb62c60 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/510fadd1e0..a049c89748 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/f46b86c7f1..66a91bf619 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/10064104c1..ee428b2cc3 * src/third_party/android_build_tools/error_prone/cipd: 2cQ2nbgV3geU7-RincCggMgIe4NuUB_eW5Rm58CgMY8C..muHOjW6H-gb8j6gY4sUylWC1paxyWPRMAeYZ1Ok8KkwC * src/third_party/android_build_tools/lint/cipd: hwubetoXxz5wxh6e9dQGVJl1Ih69nM8m0tFi5cUGujIC..cpi5krkjlhoCfjDOZ3fIdPXDOqnCGMBVzm_yHg1WnWUC * src/third_party/android_build_tools/manifest_merger/cipd: Gv6-zTnY5Cj7i1ck5bS92diwCClFq1HHoTCf4kWr4SsC..CsU9U9KptiCc6Y9kUTfQfM4CWrRw4W_SxhOt6SNdf7MC * src/third_party/androidx/cipd: OHTk-Zj-BcsXRtP5QWpR0SIoInMBgiClQfxw-BTV9pQC..Kb6Mt4bV5tZJ1VC8FHtfDaC3bwHfmdUovz5JfHFzVHgC * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/a9993612fa..c86127e656 * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5bda0fdab9..8010a1b2f5 * src/third_party/fuzztest/src: https://chromium.googlesource.com/external/github.com/google/fuzztest.git/+log/3c7bc855a4..998cda318c * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/d8ce421830..c8811240b9 * src/third_party/kotlin_stdlib/cipd: Ek4qdlAGvswwQ1AaKLNPnDUMCYHw4uWRL63Yek0nMwkC..CsG9Cc73IOfO01Pq9amuURppP5Ef9TPp9RgOElj4T5EC * src/third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/449310fe2e..35a5aaad4a * src/third_party/libunwindstack: https://chromium.googlesource.com/chromium/src/third_party/libunwindstack.git/+log/e5061bbda4..0d758dd57f * src/third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/188329a7f2..23bef80461 * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/40b5299235..29152c0585 * src/third_party/r8/d8/cipd: f-Ka2tsB3j_I6-Av4qE9ftl6KddtjV-pRVcUUc9cgYQC..wvbyt_Mr06Bl4Rcv4zoX-sTk_keiEYxfspOMUufh5nIC * src/third_party/rust-toolchain_version: Linux_x64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac_arm64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Win/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz..Linux_x64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Mac/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Mac_arm64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Win/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz * src/third_party/turbine/cipd: lnlrbUuImYl1BaRqVclTMOqA0KVYDYdym4ujLkPurbMC..scfGptWnO9bwzbg-jr0mcnVO3NG5KQJvlAQd_JSD5QUC * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/3460fbcdee..1b9b9ace3d DEPS diff: https://chromium.googlesource.com/chromium/src/+/43e4a99fb3..c87b2ac78e/DEPS No update to Clang. BUG=None Change-Id: I336610954009676b5741a624293ade960a08e410 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383880 Bot-Commit: Autoroller <[email protected]> Commit-Queue: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#44282}
No-Iwyu: Same issue as parent, too many unlrelated errors from 3p libs Bug: webrtc:42232595, webrtc:397348340 Change-Id: I11ecb0a43b2a17798304953279cbb102af353d73 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383800 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Evan Shrubsole <[email protected]> Cr-Commit-Position: refs/heads/main@{#44283}
This uses the PayloadTypeSuggester for PT disambiguation, ensuring that conficts are managed across the transport. Bug: webrtc:360058654 Change-Id: Ic8f0569d0d96d97c13765169903929ec8a110104 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383400 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Evan Shrubsole <[email protected]> Reviewed-by: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#44284}
This reverts commit c92fc76. Reason for revert: Gerritt submitted patch set #10 not #12 - this broke Original change's description: > Assign supported codecs per section, not globally. > > This uses the PayloadTypeSuggester for PT disambiguation, > ensuring that conficts are managed across the transport. > > Bug: webrtc:360058654 > Change-Id: Ic8f0569d0d96d97c13765169903929ec8a110104 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383400 > Commit-Queue: Harald Alvestrand <[email protected]> > Reviewed-by: Evan Shrubsole <[email protected]> > Reviewed-by: Henrik Boström <[email protected]> > Cr-Commit-Position: refs/heads/main@{#44284} Bug: webrtc:360058654 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I16d0d92fb9a1ecc65eda060f81d41faefcca1e4c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384000 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Danil Chapovalov <[email protected]> Bot-Commit: [email protected] <[email protected]> Reviewed-by: Mirko Bonadei <[email protected]> Cr-Commit-Position: refs/heads/main@{#44285}
Before we are "ready to send", there is a short period of time where substream stats are not present and this method returns early. This code path must also remember to set encodingIndex for the one and only outbound-rtp stats object that gets created as a result. Tested: - Necessary to pass WPTs added in https://chromium-review.googlesource.com/c/chromium/src/+/6425421 Bug: chromium:406922375 Change-Id: I05e2e55eac0cc2744987d12dfe9c9c1e4e0e2034 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383901 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#44286}
Change log: https://chromium.googlesource.com/chromium/src/+log/c87b2ac78e..080be11409 Full diff: https://chromium.googlesource.com/chromium/src/+/c87b2ac78e..080be11409 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/e62aa1e0a8..f2ba5fd49b * src/build: https://chromium.googlesource.com/chromium/src/build/+log/7f64565e57..56ec42ee91 * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/299cb62c60..4b3b2242db * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/a049c89748..f58634676e * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/66a91bf619..60d01c1030 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/ee428b2cc3..4f26618a64 * src/third_party/breakpad/breakpad: https://chromium.googlesource.com/breakpad/breakpad.git/+log/657a441e5c..884742b238 * src/third_party/fuzztest/src: https://chromium.googlesource.com/external/github.com/google/fuzztest.git/+log/998cda318c..33bb3d2040 * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/c8811240b9..71d303d18f * src/third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/35a5aaad4a..723abbda20 * src/third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/23bef80461..4b760d9a76 * src/third_party/rust-toolchain_version: Linux_x64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac_arm64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Win/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz..Linux_x64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Mac/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Mac_arm64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Win/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/1b9b9ace3d..a4368045f0 * src/tools/luci-go: git_revision:7a44078a668bc9f75dd6e40a332450e76f2f7399..git_revision:eef34c694bdab861ded59a7e34ddf4d97e013c90 * src/tools/luci-go: git_revision:7a44078a668bc9f75dd6e40a332450e76f2f7399..git_revision:eef34c694bdab861ded59a7e34ddf4d97e013c90 * src/tools/luci-go: git_revision:7a44078a668bc9f75dd6e40a332450e76f2f7399..git_revision:eef34c694bdab861ded59a7e34ddf4d97e013c90 DEPS diff: https://chromium.googlesource.com/chromium/src/+/c87b2ac78e..080be11409/DEPS No update to Clang. BUG=None Change-Id: Ied31df2989a13521d064a84bdeabe24b212120a7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383962 Commit-Queue: Autoroller <[email protected]> Bot-Commit: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#44287}
This reverts commit 374b892. Reason for revert: Racing CLs sorted out Original change's description: > Revert "Assign supported codecs per section, not globally." > > This reverts commit c92fc76. > > Reason for revert: Gerritt submitted patch set #10 not #12 - this broke > > Original change's description: > > Assign supported codecs per section, not globally. > > > > This uses the PayloadTypeSuggester for PT disambiguation, > > ensuring that conficts are managed across the transport. > > > > Bug: webrtc:360058654 > > Change-Id: Ic8f0569d0d96d97c13765169903929ec8a110104 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383400 > > Commit-Queue: Harald Alvestrand <[email protected]> > > Reviewed-by: Evan Shrubsole <[email protected]> > > Reviewed-by: Henrik Boström <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#44284} > > Bug: webrtc:360058654 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I16d0d92fb9a1ecc65eda060f81d41faefcca1e4c > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384000 > Commit-Queue: Harald Alvestrand <[email protected]> > Reviewed-by: Danil Chapovalov <[email protected]> > Bot-Commit: [email protected] <[email protected]> > Reviewed-by: Mirko Bonadei <[email protected]> > Cr-Commit-Position: refs/heads/main@{#44285} Bug: webrtc:360058654 Change-Id: I80b59aab396abbc0afa60dab3516f2a22e822a5d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383981 Reviewed-by: Mirko Bonadei <[email protected]> Commit-Queue: Mirko Bonadei <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Danil Chapovalov <[email protected]> Cr-Commit-Position: refs/heads/main@{#44288}
Change log: https://chromium.googlesource.com/chromium/src/+log/080be11409..479c058ca2 Full diff: https://chromium.googlesource.com/chromium/src/+/080be11409..479c058ca2 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/f2ba5fd49b..b0ecf00319 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/56ec42ee91..2950487dcd * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/f58634676e..9b26cef2c0 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/60d01c1030..31101839b3 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/4f26618a64..61b45617a8 * src/third_party/android_deps/autorolled/cipd: -kw2ioUuVwgaTHjBYvcyYBT3SZ24bRuwH_rIhsiZ24IC..TFiDa5VbziMUligPbDLeDXpPmLBgBdhqIj5CslOiRLMC * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/c86127e656..f0ab91129d * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/71d303d18f..2b149599d9 * src/third_party/rust-toolchain_version: Linux_x64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac_arm64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Win/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz..Linux_x64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Mac/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Mac_arm64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Win/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/a4368045f0..252128f6c3 * src/tools/luci-go: git_revision:eef34c694bdab861ded59a7e34ddf4d97e013c90..git_revision:cd0142e4e2f376bb0bd1b34a3b91167aff5226bf * src/tools/luci-go: git_revision:eef34c694bdab861ded59a7e34ddf4d97e013c90..git_revision:cd0142e4e2f376bb0bd1b34a3b91167aff5226bf * src/tools/luci-go: git_revision:eef34c694bdab861ded59a7e34ddf4d97e013c90..git_revision:cd0142e4e2f376bb0bd1b34a3b91167aff5226bf DEPS diff: https://chromium.googlesource.com/chromium/src/+/080be11409..479c058ca2/DEPS No update to Clang. BUG=None Change-Id: I45a6a1c3a82f42257a97a996e1f5bd8cf5a401e2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384020 Commit-Queue: Autoroller <[email protected]> Bot-Commit: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#44289}
Bug: None Change-Id: I2672842051e85a0e62b1f5d837832caf60750664 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384040 Bot-Commit: [email protected] <[email protected]> Commit-Queue: [email protected] <[email protected]> Cr-Commit-Position: refs/heads/main@{#44290}
This would ensure fields trials are always provided and thus Port will be able to remove fallback to the global field trials. Bug: webrtc:405883462 Change-Id: I18c1ede4324a86078477be42d38abcf6f2a53361 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383801 Commit-Queue: Danil Chapovalov <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#44291}
Change log: https://chromium.googlesource.com/chromium/src/+log/479c058ca2..f2812e793c Full diff: https://chromium.googlesource.com/chromium/src/+/479c058ca2..f2812e793c Changed dependencies * fuchsia_version: version:27.20250326.5.1..version:27.20250402.5.1 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/2950487dcd..26ff83f048 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/31101839b3..576e7554b9 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/61b45617a8..c22170aab3 * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/2b149599d9..4eacaf78be * src/third_party/rust-toolchain_version: Linux_x64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac_arm64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Win/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz..Linux_x64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Mac/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Mac_arm64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Win/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/252128f6c3..a3c5fe0e54 DEPS diff: https://chromium.googlesource.com/chromium/src/+/479c058ca2..f2812e793c/DEPS No update to Clang. BUG=None Change-Id: I78ffec8bb9aad0407e210ef299212195f722f3d6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384061 Commit-Queue: Autoroller <[email protected]> Bot-Commit: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#44292}
Bug: None Change-Id: I6fd76786d040c1c591ce4c7d437ec634c2f09271 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383920 Commit-Queue: Evan Shrubsole <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Auto-Submit: Evan Shrubsole <[email protected]> Cr-Commit-Position: refs/heads/main@{#44293}
Change log: https://chromium.googlesource.com/chromium/src/+log/f2812e793c..c6ae2d7757 Full diff: https://chromium.googlesource.com/chromium/src/+/f2812e793c..c6ae2d7757 Changed dependencies * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/9b26cef2c0..579ee5ef12 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/576e7554b9..3854c0d55c * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/c22170aab3..e85daf0384 * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8010a1b2f5..7236fd6c03 * src/third_party/harfbuzz-ng/src: https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/8efd2d85c7..9f83bbbe64 * src/third_party/rust-toolchain_version: Linux_x64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac_arm64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Win/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz..Linux_x64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz,Mac/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz,Mac_arm64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz,Win/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/a3c5fe0e54..30615716ef DEPS diff: https://chromium.googlesource.com/chromium/src/+/f2812e793c..c6ae2d7757/DEPS Clang version changed llvmorg-21-init-5118-g52cd27e6:llvmorg-21-init-6681-g5b36835d Details: https://chromium.googlesource.com/chromium/src/+/f2812e793c..c6ae2d7757/tools/clang/scripts/update.py BUG=None Change-Id: I0fb77f183dd0a426f0ef68b06c1ba4dbbb1464ae Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384063 Commit-Queue: Autoroller <[email protected]> Bot-Commit: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#44294}
We're moving all references to exec_script_whitelist in GN to use exec_script_allowlist instead. Bug: chromium:389986807 Change-Id: Ie354a267b98072b83d8df30a5d6cb78496960d29 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383965 Reviewed-by: Harald Alvestrand <[email protected]> Reviewed-by: Henrik Andreassson <[email protected]> Commit-Queue: Dirk Pranke <[email protected]> Cr-Commit-Position: refs/heads/main@{#44295}
The test_case_name is based on the flag isolated_script_test_perf_output instead which is only set when uploading the metrics to CPD. Change-Id: Ic8a92c548a2683ab5083eedb5e6b159aa072db2e Bug: webrtc:42225051 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384081 Reviewed-by: Mirko Bonadei <[email protected]> Commit-Queue: Jeremy Leconte <[email protected]> Cr-Commit-Position: refs/heads/main@{#44296}
Bug: b:402019802 Change-Id: I15ff3cbaae84e0c7d40f452fd105dd3efab0b5be Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384140 Commit-Queue: Sergey Silkin <[email protected]> Reviewed-by: Åsa Persson <[email protected]> Cr-Commit-Position: refs/heads/main@{#44297}
This will be used to compare new implementations of Base64 (abseil and Rust). Current on my machine results look like. ❯ out/Release/base64_benchmark --------------------------------------------------------------------------- Benchmark Time CPU Iterations --------------------------------------------------------------------------- BM_Base64Encode/64 123 ns 123 ns 5689290 BM_Base64Encode/512 750 ns 750 ns 941209 BM_Base64Encode/4096 5973 ns 5972 ns 122699 BM_Base64Encode/32768 45960 ns 45944 ns 14989 BM_Base64Encode/262144 372323 ns 372158 ns 1899 BM_Base64Encode/2097152 2984810 ns 2983847 ns 237 BM_Base64Encode/8388608 12073887 ns 12067914 ns 58 BM_Base64Decode/64 275 ns 275 ns 2543692 BM_Base64Decode/512 1897 ns 1897 ns 371668 BM_Base64Decode/4096 14875 ns 14871 ns 47373 BM_Base64Decode/32768 118947 ns 118904 ns 5904 BM_Base64Decode/262144 946780 ns 946229 ns 743 BM_Base64Decode/2097152 7587559 ns 7585678 ns 93 BM_Base64Decode/8388608 30476757 ns 30464404 ns 23 BM_Base64DecodeForgiving/64 271 ns 271 ns 2575094 BM_Base64DecodeForgiving/512 1991 ns 1990 ns 350958 BM_Base64DecodeForgiving/4096 15746 ns 15742 ns 44414 BM_Base64DecodeForgiving/32768 125640 ns 125550 ns 5598 BM_Base64DecodeForgiving/262144 1006027 ns 1005577 ns 701 BM_Base64DecodeForgiving/2097152 8041495 ns 8037190 ns 87 BM_Base64DecodeForgiving/8388608 32310820 ns 32292374 ns 22 Bug: webrtc:406686729 Change-Id: I213ff84575352704b87f14ba50802a0617f9ddd9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384101 Commit-Queue: Tomas Gunnarsson <[email protected]> Reviewed-by: Mirko Bonadei <[email protected]> Reviewed-by: Tomas Gunnarsson <[email protected]> Auto-Submit: Evan Shrubsole <[email protected]> Cr-Commit-Position: refs/heads/main@{#44298}
Bug: webrtc:42225151 Change-Id: I2be14871583a7777ce967aca0454820f5acb6e96 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384180 Reviewed-by: Mirko Bonadei <[email protected]> Auto-Submit: Sergey Silkin <[email protected]> Reviewed-by: Erik Språng <[email protected]> Commit-Queue: Mirko Bonadei <[email protected]> Cr-Commit-Position: refs/heads/main@{#44299}
Since abseil/abseil-cpp@03a179c attribute-like annotation are preferred over type-like annotation No-Try: true Bug: webrtc:407433459 Change-Id: Iebe6dd270f9c73aeeafc1d4bda1885d4a72aa5cb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384401 Reviewed-by: Mirko Bonadei <[email protected]> Auto-Submit: Danil Chapovalov <[email protected]> Commit-Queue: Mirko Bonadei <[email protected]> Cr-Commit-Position: refs/heads/main@{#44300}
absl::Nonnull -> absl_nonnull, absl::Nullable -> absl_nullable, and absl::NullabilityUnknown -> absl_nullability_unknown. The new macros are positioned as a qualifier on the affected type, similar to const, rather than as a templated type wrapping the affected type. Bug: webrtc:407433459 No-Iwyu: No regressions introduced by this CL Change-Id: Id6b1a58296d52c86db3ae44e90849affc904d335 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384220 Commit-Queue: Mirko Bonadei <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Auto-Submit: Mirko Bonadei <[email protected]> Reviewed-by: Danil Chapovalov <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#44301}
* fix simulcast_video_encoder * fix SimulcastVideoEncoder.java * fix simulcast_video_encoder_factory.cc * fix HardwareVideoEncoderWrapper.java
* Update to m125. (#119) Use M125 as the latest version and migrate historical patches to m125 Patches Group: ## 1. Update README.md webrtc-sdk/webrtc@b6c65fc * Add Apache-2.0 license and some note to README.md. (#9) * Updated readme detailing changes from original (#42) * Adding membrane framework (#51) * Updated readme (#83) ## 2. Audio Device Optimization webrtc-sdk/webrtc@7454824 * allow listen-only mode in AudioUnit, adjust when category changes (webrtc-sdk/webrtc#2) * release mic when category changes (webrtc-sdk/webrtc#5) * Change defaults to iOS defaults (webrtc-sdk/webrtc#7) * Sync audio session config (webrtc-sdk/webrtc#8) * feat: support bypass voice processing for iOS. (webrtc-sdk/webrtc#15) * Remove MacBookPro audio pan right code (webrtc-sdk/webrtc#22) * fix: Fix can't open mic alone when built-in AEC is enabled. (webrtc-sdk/webrtc#29) * feat: add audio device changes detect for windows. (webrtc-sdk/webrtc#41) * fix Linux compile (webrtc-sdk/webrtc#47) * AudioUnit: Don't rely on category switch for mic indicator to turn off (webrtc-sdk/webrtc#52) * Stop recording on mute (turn off mic indicator) (webrtc-sdk/webrtc#55) * Cherry pick audio selection from m97 release (webrtc-sdk/webrtc#35) * [Mac] Allow audio device selection (webrtc-sdk/webrtc#21) * RTCAudioDeviceModule.outputDevice / inputDevice getter and setter (webrtc-sdk/webrtc#80) * Allow custom audio processing by exposing AudioProcessingModule (webrtc-sdk/webrtc#85) * Expose audio sample buffers for Android (webrtc-sdk/webrtc#89) * feat: add external audio processor for android. (webrtc-sdk/webrtc#103) * android: make audio output attributes modifiable (webrtc-sdk/webrtc#118) * Fix external audio processor sample rate calculation (webrtc-sdk/webrtc#108) * Expose remote audio sample buffers on RTCAudioTrack (webrtc-sdk/webrtc#84) * Fix memory leak when creating audio CMSampleBuffer webrtc-sdk/webrtc#86 ## 3. Simulcast/SVC support for iOS/Android. webrtc-sdk/webrtc@b0b9fe9 - Simulcast support for iOS SDK (#4) - Support for simulcast in Android SDK (#3) - include simulcast headers for mac also (#10) - Fix simulcast using hardware encoder on Android (#48) - Add scalabilityMode support for AV1/VP9. (#90) ## 4. Android improvements. webrtc-sdk/webrtc@9aaaab5 - Start/Stop receiving stream method for VideoTrack (#25) - Properly remove observer upon deconstruction (#26) - feat: Expose setCodecPreferences/getCapabilities for android. (#61) - fix: add WrappedVideoDecoderFactory.java. (#74) ## 5. Darwin improvements webrtc-sdk/webrtc@a13ea17 - [Mac/iOS] feat: Add RTCYUVHelper for darwin. (#28) - Cross-platform `RTCMTLVideoView` for both iOS / macOS (#40) - rotationOverride should not be assign (#44) - [ObjC] Expose properties / methods required for AV1 codec support (#60) - Workaround: Render PixelBuffer in RTCMTLVideoView (#58) - Improve iOS/macOS H264 encoder (#70) - fix: fix video encoder not resuming correctly upon foregrounding (#75). - add PrivacyInfo.xcprivacy to darwin frameworks. (#112) - Add NSPrivacyCollectedDataTypes key to xcprivacy file (#114) - Thread-safe `RTCInitFieldTrialDictionary` (#116) - Set RTCCameraVideoCapturer initial zoom factor (#121) - Unlock configuration before starting capture session (#122) ## 6. Desktop Capture for macOS. webrtc-sdk/webrtc@841d78f - [Mac] feat: Support screen capture for macOS. (#24) (#36) - fix: Get thumbnails asynchronously. (#37) - fix: Use CVPixelBuffer to build DesktopCapture Frame, fix the crash caused by non-CVPixelBuffer frame in RTCVideoEncoderH264 that cannot be cropped. (#63) - Fix the crash when setting the fps of the virtual camera. (#62) ## 7. Frame Cryptor Support. webrtc-sdk/webrtc@fc08745 - feat: Frame Cryptor (aes gcm/cbc). (#54) - feat: key ratchet/derive. (#66) - fix: skip invalid key when decryption failed. (#81) - Improve e2ee, add setSharedKey to KeyProvider. (#88) - add failure tolerance for framecryptor. (#91) - fix h264 freeze. (#93) - Fix/send frame cryptor events from signaling thread (#95) - more improvements for E2EE. (#96) - remove too verbose logs (#107) - Add key ring size to keyProviderOptions. (#109) ## 8. Other improvements. webrtc-sdk/webrtc@eed6c8a - Added yuv_helper (#57) - ABGRToI420, ARGBToI420 & ARGBToRGB24 (#65) - more yuv wrappers (#87) - Fix naming for yuv helper (#113) - Fix missing `RTC_OBJC_TYPE` macros (#100) --------- Co-authored-by: Hiroshi Horie <[email protected]> Co-authored-by: David Zhao <[email protected]> Co-authored-by: davidliu <[email protected]> Co-authored-by: Angelika Serwa <[email protected]> Co-authored-by: Théo Monnom <[email protected]> # Conflicts: # README.md # media/engine/webrtc_video_engine.cc # media/engine/webrtc_video_engine.h # modules/audio_device/audio_device_impl.cc # sdk/BUILD.gn # sdk/android/BUILD.gn # sdk/android/api/org/webrtc/RtpParameters.java # sdk/android/api/org/webrtc/SimulcastVideoEncoder.java # sdk/android/api/org/webrtc/SimulcastVideoEncoderFactory.java # sdk/android/api/org/webrtc/VideoCodecInfo.java # sdk/android/src/jni/pc/rtp_parameters.cc # sdk/android/src/jni/simulcast_video_encoder.cc # sdk/android/src/jni/simulcast_video_encoder.h # sdk/android/src/jni/video_codec_info.cc # sdk/objc/api/peerconnection/RTCAudioDeviceModule+Private.h # sdk/objc/api/peerconnection/RTCAudioDeviceModule.h # sdk/objc/api/peerconnection/RTCAudioDeviceModule.mm # sdk/objc/api/peerconnection/RTCAudioTrack.mm # sdk/objc/api/peerconnection/RTCIODevice+Private.h # sdk/objc/api/peerconnection/RTCIODevice.mm # sdk/objc/api/peerconnection/RTCPeerConnectionFactory.h # sdk/objc/api/peerconnection/RTCPeerConnectionFactory.mm # sdk/objc/api/video_codec/RTCVideoEncoderSimulcast.h # sdk/objc/api/video_codec/RTCVideoEncoderSimulcast.mm # sdk/objc/base/RTCAudioRenderer.h # sdk/objc/components/video_codec/RTCVideoEncoderFactorySimulcast.h # sdk/objc/components/video_codec/RTCVideoEncoderFactorySimulcast.mm * fix: duplicate simulcast entries * remove duplicate declaration * remove duplicate audioDeviceModule * fix: removed livekit's external audio processor * fix: add back simulcast factories * Fix missing RTC_OBJC_TYPE macros * Fix missing headers and Metal linking # Conflicts: # sdk/BUILD.gn * Fix Mac Catalyst `RTCCameraVideoCapturer` rotation (#126) * Fix set frame transformer (#125) * Fix webrtc_voice_engine not notifying mute change (#128) Looks like this line was missed during the m125 update. webrtc-sdk/webrtc@272127d#diff-56f5e0c459b287281ef3b0431d3f4129e8e4be4c6955d845bcb22210f08b7ba5R2289 Adding it back in so that mic is properly released when muted. # Conflicts: # media/engine/webrtc_voice_engine.cc * android: Allow for skipping checking the audio playstate if needed (#129) Pausing/stopping the audio track can lead to a race condition against the AudioTrackThread due to this assert. Normally this is fine since directly pausing/stopping isn't possible, but user is using reflection to workaround another audio issue (muted participants still have a sending audio stream which keeps the audio alive, affecting global sound if in the background). Not a full fix, as would like to manually control the audio track directly (needs a bigger fix to handle proper synchronization before allowing public access), but this will work through reflection (user takes responsibility for usage). * Allow to pass in capture session to RTCCameraVideoCapturer (#132) Expose initializers to pass in capture session to RTCCameraVideoCapturer so we can use AVCaptureMultiCamSession etc to capture front and back simultaneously for iOS. * Fix NetworkMonitor race condition when dispatching native observers (#135) There is a race condition in NetworkMonitor where native observers may be removed concurrently with a notification being dispatched, leading to a dangling pointer dereference (trying to dispatch an observer that was already removed and destroyed), and from there a crash with access violation. By ensuring dispatching to native observers is done within the synchronization lock that guards additions/removals of native observers protects against this race condition. Since native observers callbacks are posted to the networking thread in the C++ side anyway, there should be no risk of deadlock/starvation due to long-running observers. Bug: webrtc:15837 Change-Id: Id2b788f102dbd25de76ceed434c4cd68aa9a569e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/338643 Reviewed-by: Taylor Brandstetter <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#42256} Co-authored-by: Guy Hershenbaum <[email protected]> * Support for Vision Pro (#131) TODO: - [x] fix compile for RTCCameraVideoCapturer - [ ] fix RTCMTLRenderer ? --------- Co-authored-by: Hiroshi Horie <[email protected]> * Multicam support (#137) TODO: - [x] Return `.systemPreferredCamera` for devices (visionOS only). - [x] Use `AVCaptureMultiCamSession` only if `isMultiCamSupported` is true. - [x] Silence statusBarOrientation warning. --------- Co-authored-by: [email protected] <[email protected]> * tvOS support (#139) 17.0+ only atm --------- Co-authored-by: cloudwebrtc <[email protected]> * Add isDisposed to MediaStreamTrack (#140) * chore: handle invalid cipher from key size. (#142) * Allow software AEC for Simulator (#143) ~Allow to use "googEchoCancellation" constraint for software AEC. For devices "googEchoCancellation" should be false to use VoiceProcessingIO.~ * Fix AudioRenderer crash & expose AVAudioPCMBuffer (#144) * fix: Fix bug for bypass voice processing. (#147) * chore: remove aes cbc for framecryptor. (#145) * Change audio renderer output format (#149) Instead of converting to Float, output original Int data without conversion. Output the raw format and convert when required. * Fixed issue with missing network interfaces on iOS (#151) Related issue: webrtc-sdk/webrtc#148 Cherry-pick : https://webrtc.googlesource.com/src/+/fea60ef8e72fb17b4f8a5363aff7e63ab8027b4f Fixed issue with network interfaces due to a missing return value in the "nw_path_enumerate_interfaces(...)" block. Exposed in iOS 18, RTCNetworkMonitor::initWithObserver will only enumerate the first interface, instead of all device interfaces Bug: webrtc:359245764 Change-Id: Ifb9f28c33306c0096476a4afb0cdb4d734e87b2c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359541 Auto-Submit: Corby <[email protected]> Commit-Queue: Jonas Oreland <[email protected]> Reviewed-by: Kári Helgason <[email protected]> Reviewed-by: Jonas Oreland <[email protected]> Cr-Commit-Position: refs/heads/main@{#42818} Co-authored-by: Corby Hoback <[email protected]> * Custom audio input for Android (#154) # Conflicts: # sdk/android/api/org/webrtc/audio/JavaAudioDeviceModule.java # sdk/android/src/java/org/webrtc/audio/WebRtcAudioRecord.java --------- Co-authored-by: CloudWebRTC <[email protected]> Co-authored-by: Hiroshi Horie <[email protected]> Co-authored-by: davidliu <[email protected]> Co-authored-by: Guy Hershenbaum <[email protected]> Co-authored-by: Corby Hoback <[email protected]>
* [AND-179] rename ExternalAudioProcessingFactory * Return java's ExternalAudioProcessingFactory
…/m137.5 # Conflicts: # extensions/android-external-audio-processing/BUILD.gn # sdk/android/BUILD.gn # sdk/objc/components/audio/RTCAudioCustomProcessingAdapter.mm
… audioBuffers of what was recorded
…amespace 'webrtc'
…ert_no_deps entry:
This reverts commit c522445.
…yback (#63) * Exposed method in JavaaudioDeviceModule to switch between Stereo and Mono playout * Removed call to native layer to get the bufbufferSizeFactor. Use default of bufferSizeFactor = 1.0 while switching b/w mono and stereo * Make setChannelConfigurationAndUsage thread safe by calling a thread safe method initPlayoutThreadSafe which does not have any thread checking logic * Make setChannelConfigurationAndUsage thread safe by calling a thread safe method initPlayoutThreadSafe which does not have any thread checking logic * If playout is currently active, it will be stopped and automatically restarted with the new configuration. * Remove unnecessary check in WebRtcAudioTrack which was preventing audioAttribute to be updated. * Refactored to change only the usage and contentType of AudioTrack Audio Attribute when it is changed from the app * Avoids unnecessary work when usage hasn't changed -no-op if usage is the same * Removed un-necessary null checks and improved comments
ipavlidakis
added a commit
that referenced
this pull request
Nov 28, 2025
* 137.5 to main (#64) * Fix : update the audioAttribute if `updateAudioTrackUsage` called before `AudioTrack` is created (#66) * Fix : If audioTrack is null, store the usage in audioAttributes, so that same will be picked up when creating the audioTrack. --------- Co-authored-by: Pratim Mallick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.