Skip to content

Conversation

@tao1
Copy link

@tao1 tao1 commented Oct 18, 2023

🎯 Goal

Add support for H264 hardware decoding on Bouygues Telecom's AndroidTV boxes relying on Marvell chips.

🛠 Implementation details

Describe the implementation details for this Pull Request.

  • Add MediaCodecInfo.CodecCapabilities.COLOR_FormatYUV420Flexible to MediaCodecUtils.DECODER_COLOR_FORMATS
  • Claim MediaCodecVideoDecoderFactory.isH264HighProfileSupported() returns true for Marvell chips

✍️ Explain examples

Sorry, example code is proprietary.

Preparing a pull request for review

spotlessApply is OK

@tao1 tao1 requested a review from skydoves as a code owner October 18, 2023 21:53
@tao1
Copy link
Author

tao1 commented Oct 18, 2023

I didn't want my second commit to be part of this pull request. My mistake.

@alxlion
Copy link

alxlion commented Oct 19, 2023

Support of Marvell chips is a must-have ! Thanks for the PR

@skydoves
Copy link
Contributor

skydoves commented Oct 19, 2023

Hey @tao1, thanks for creating this PR. The Stream team is working on webrtc core on a separated repository for the source of truth, would you create a PR for this here? Thank you!

https://github.com/GetStream/webrtc/blob/b33e7bdf77a950dd5e94a442bc9ddb518aec0cda/sdk/android/src/java/org/webrtc/MediaCodecUtils.java#L1

@tao1
Copy link
Author

tao1 commented Oct 20, 2023

GetStream/webrtc#23

@tao1 tao1 closed this Oct 20, 2023
@tao1
Copy link
Author

tao1 commented Dec 1, 2023

GetStream/webrtc#23 is merged now.
I hoped your last release 1.1.1 would contain this PR.
I reopen this issue so you don't forget it.
KR

@tao1 tao1 reopened this Dec 1, 2023
@skydoves
Copy link
Contributor

This issue has been contained in the latest release, so I'm closing this issue now. Thank you for your contribution, @tao1!

@skydoves skydoves closed this Dec 21, 2023
@tao1
Copy link
Author

tao1 commented Dec 27, 2023

@skydoves
AFAIK it is not contained in latest release.
I guess because GetStream/webrtc#23 was merged into https://github.com/GetStream/webrtc/tree/patch/m114 branch but it is still not merged into main.
You can verify Marvell chips are not checked in 1.1.1 release at https://github.com/GetStream/webrtc-android/blob/1.1.1/stream-webrtc-android/src/main/java/org/webrtc/MediaCodecVideoDecoderFactory.java#L131

KR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants