-
Notifications
You must be signed in to change notification settings - Fork 45
feat(ios): improved frame rendering #2133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,7 @@ | |
| "@react-navigation/native": "^7.1.18", | ||
| "@react-navigation/native-stack": "^7.3.27", | ||
| "@stream-io/noise-cancellation-react-native": "workspace:^", | ||
| "@stream-io/react-native-webrtc": "137.1.0", | ||
| "@stream-io/react-native-webrtc": "137.1.3-alpha.1", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pre-release alpha — confirm The latest stable release on npm is One operational note: the 🤖 Prompt for AI Agents |
||
| "@stream-io/video-filters-react-native": "workspace:^", | ||
| "@stream-io/video-react-native-sdk": "workspace:^", | ||
| "axios": "^1.12.2", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: GetStream/stream-video-js
Length of output: 239
🏁 Script executed:
Repository: GetStream/stream-video-js
Length of output: 239
🏁 Script executed:
Repository: GetStream/stream-video-js
Length of output: 241
🏁 Script executed:
Repository: GetStream/stream-video-js
Length of output: 115
🏁 Script executed:
Repository: GetStream/stream-video-js
Length of output: 398
🏁 Script executed:
Repository: GetStream/stream-video-js
Length of output: 2025
🏁 Script executed:
Repository: GetStream/stream-video-js
Length of output: 1570
🏁 Script executed:
# Check the react-native-sdk podspec cat -n packages/react-native-sdk/stream-video-react-native.podspecRepository: GetStream/stream-video-js
Length of output: 2174
🏁 Script executed:
Repository: GetStream/stream-video-js
Length of output: 51
🏁 Script executed:
Repository: GetStream/stream-video-js
Length of output: 51
🏁 Script executed:
Repository: GetStream/stream-video-js
Length of output: 6515
🏁 Script executed:
Repository: GetStream/stream-video-js
Length of output: 3171
🏁 Script executed:
Repository: GetStream/stream-video-js
Length of output: 2856
Move the StreamWebRTC pod inside the target block for clarity.
The
StreamWebRTCpod is declared at the root scope (line 13), beforeplatform :iosand outside thetarget 'StreamReactNativeVideoSDKSample'block. While CocoaPods' implicit abstract target mechanism allows this to work, placing it alongsideuse_frameworks! :linkage => :static(line 36) inside the target block makes the intent clearer and is idiomatic.Version alignment is already correct: The
Podfile.lockconfirms thatstream-react-native-webrtc@137.1.3-alpha.1declaresStreamWebRTC (~> 137.0.62), and the manually specified137.0.62satisfies this constraint. No version conflict exists.♻️ Suggested placement
📝 Committable suggestion
🤖 Prompt for AI Agents