Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PBE-1127]add ExternalRankingVars #143

Merged
merged 2 commits into from
Jan 9, 2024
Merged

[PBE-1127]add ExternalRankingVars #143

merged 2 commits into from
Jan 9, 2024

Conversation

itsmeadi
Copy link
Contributor

@itsmeadi itsmeadi commented Jan 5, 2024

No description provided.

@itsmeadi itsmeadi requested a review from JcMinarro as a code owner January 5, 2024 16:55
@itsmeadi itsmeadi changed the title add ExternalRankingVars [PBE-1127]add ExternalRankingVars Jan 5, 2024
@itsmeadi itsmeadi force-pushed the external_ranking_vars branch from 1d20d61 to 33816ce Compare January 8, 2024 09:29
@JimmyPettersson85 JimmyPettersson85 requested review from xernobyl and removed request for JcMinarro January 8, 2024 12:33
xernobyl
xernobyl approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@xernobyl xernobyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀👍2me

@itsmeadi itsmeadi merged commit 81f1b14 into main Jan 9, 2024
1 check passed
@itsmeadi itsmeadi deleted the external_ranking_vars branch January 9, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xernobyl xernobyl xernobyl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsmeadi @xernobyl