Fix composer not showing images in the composer when editing signed attachments

[nuno-vieira]

🔗 Issue Links

IOS-1014
IOS-817

🎯 Goal

• Fix composer not showing images in the composer when editing signed attachments
• Fix replacing an image while editing a message not showing the new image in the message list
• Removes dead code

🧪 Manual Testing Notes

Fix composer not showing images in the composer when editing signed attachments:
N/A

Fix replacing an image while editing a message not showing the new image in the message list:

1. Send a message with an image
2. Long tap the message
3. Edit the message
4. Remove the existing image and upload a new one
5. Send the message
6. The new message should appear while uploading and also when finished

☑️ Contributor Checklist

• I have signed the Stream CLA (required)
• This change should be manually QAed
• Changelog is updated with client-facing changes
• Changelog is updated with new localization keys
• New code is covered by unit tests
• Documentation has been updated in the docs-content repo

[github-actions]

Public Interface

- public struct MediaAttachment: Identifiable  
+ public struct MediaAttachment: Identifiable, Equatable  
+   
+ 
+   public static func ==(lhs: MediaAttachment,rhs: MediaAttachment)-> Bool

[Stream-SDK-Bot]

SDK Size

title	develop	branch	diff	status
StreamChatSwiftUI	9.38 MB	9.38 MB	+1 KB	🟢

[martinmitrevski]

few issues:

• seems like both the keyboard and the image attachments are shown at the same time, leading to this UI:

- if I start editing, leave the screen, it treats it as a draft which if I send it - it sends it as a new message. Probably, we should disable saving a draft when it's an edited message?

[martinmitrevski]

this is a bit unsafe if we decide to provide a new implementation

[nuno-vieira]

I can just always use the CDN, I initially I did this because of the tests, but will change it. It will simplify the code as well

[nuno-vieira]

Fixed ✅

[nuno-vieira]

few issues:

• seems like both the keyboard and the image attachments are shown at the same time, leading to this UI:

- if I start editing, leave the screen, it treats it as a draft which if I send it - it sends it as a new message. Probably, we should disable saving a draft when it's an edited message?

Yeah, that UI is a known issue that is in the backlog. Discarding the draft when editing is questionable 🤔 On UIKit at the moment we have this behaviour. In one way, if you are editing a long message and accidentally leave the channel, it is kinda nice that we save the edit. At the moment, the reference of the edited message is not saved, so the user would need to tap on edit again. So yeah at the moment even if we wanted to save the draft edited message, it is incomplete 🤔

Update:
For now, I removed the draft when editing a message

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
81.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud