-
Notifications
You must be signed in to change notification settings - Fork 111
Add support for customizing AddUsersView #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Public Interface+ public struct AddUsersOptions
+
+ public let loadedUsers: [ChatUser]
+
+
+ public init(loadedUsers: [ChatUser])
extension ViewFactory
+ public func makeAddUsersView(options: AddUsersOptions,onUserTap: @escaping (ChatUser) -> Void)-> some View |
SDK Size
|
Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/AddUsersView.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, only question is if AddUsersViewOptions should have ChatUser instead of just the ID, so that it can be more flexible in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅
@martinmitrevski Make sure to fix the tests first before merging 👍 |
@testableapple what happened with the snapshot tests, didn't we fix this already? |
🔗 Issue Links
Resolves https://linear.app/stream/issue/IOS-1061/expose-addusersview-factory-method.
🎯 Goal
Ability to customize the AddUsersView.
📝 Summary
Provide bullet points with the most important changes in the codebase.
🛠 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
docs-content
repo