Skip to content

Conversation

martinmitrevski
Copy link
Contributor

🔗 Issue Links

Resolves https://linear.app/stream/issue/IOS-1061/expose-addusersview-factory-method.

🎯 Goal

Ability to customize the AddUsersView.

📝 Summary

Provide bullet points with the most important changes in the codebase.

🛠 Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@martinmitrevski martinmitrevski requested a review from a team as a code owner August 11, 2025 20:29
Copy link

github-actions bot commented Aug 11, 2025

Public Interface

+ public struct AddUsersOptions  
+ 
+   public let loadedUsers: [ChatUser]
+   
+ 
+   public init(loadedUsers: [ChatUser])



 extension ViewFactory  
+   public func makeAddUsersView(options: AddUsersOptions,onUserTap: @escaping (ChatUser) -> Void)-> some View

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Aug 11, 2025

SDK Size

title develop branch diff status
StreamChatSwiftUI 9.22 MB 9.22 MB +1 KB 🟢

Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, only question is if AddUsersViewOptions should have ChatUser instead of just the ID, so that it can be more flexible in the future.

Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@nuno-vieira
Copy link
Member

@martinmitrevski Make sure to fix the tests first before merging 👍

@martinmitrevski
Copy link
Contributor Author

@testableapple what happened with the snapshot tests, didn't we fix this already?

@martinmitrevski martinmitrevski merged commit 4b960cd into develop Aug 12, 2025
9 of 10 checks passed
@martinmitrevski martinmitrevski deleted the addusers-view branch August 12, 2025 16:00
This was referenced Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants