Skip to content

Fix WebView error handling to enable mp3 attachments loading #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 1, 2025
Merged

Fix WebView error handling to enable mp3 attachments loading #904

merged 4 commits into from
Aug 1, 2025

Conversation

testableapple
Copy link
Contributor

🔗 Issue Links

Resolve https://linear.app/stream/issue/IOS-1052

🎯 Goal

Fix WebView error handling to enable mp3 attachments loading

🎨 Showcase

Before After
before after

🧪 Manual Testing Notes

  1. Send any mp3 file (e.g.: from the internal ticket)
  2. Open it in the DemoApp

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@testableapple testableapple requested a review from a team as a code owner August 1, 2025 14:59
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Aug 1, 2025 •
edited
Loading

SDK Size

title develop branch diff status
StreamChatSwiftUI 9.22 MB 9.22 MB 0 KB 🟢

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2025

Public Interface

🚀 No changes affecting the public interface.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2025

Public Interface

🚀 No changes affecting the public interface.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2025

Public Interface

🚀 No changes affecting the public interface.

@testableapple testableapple enabled auto-merge (squash) August 1, 2025 15:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2025

Public Interface

🚀 No changes affecting the public interface.

@testableapple testableapple disabled auto-merge August 1, 2025 17:10
@testableapple testableapple merged commit 9ddaf7c into develop Aug 1, 2025
9 of 10 checks passed
@testableapple testableapple deleted the fix/webview-player branch August 1, 2025 17:10
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Aug 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@testableapple @Stream-SDK-Bot @martinmitrevski