Skip to content

Fix message Actions overlay view not dismissed when opening thread #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

Fix message Actions overlay view not dismissed when opening thread #873

merged 2 commits into from
Jul 3, 2025

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Jul 2, 2025 •
edited
Loading

🔗 Issue Links

https://linear.app/stream/issue/IOS-841

🎯 Goal

Fix message Actions overlay view not dismissed when opening thread

🧪 Manual Testing Notes

  1. Long tap a message
  2. Tap on "Thread reply"
  3. Go back to the channel
  4. The overlay view should not be shown

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@nuno-vieira nuno-vieira requested a review from a team as a code owner July 2, 2025 20:19
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Jul 2, 2025 •
edited
Loading

SDK Size

title develop branch diff status
StreamChatSwiftUI 8.63 MB 8.63 MB 0 KB 🟢

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
42.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@nuno-vieira nuno-vieira merged commit b073808 into develop Jul 3, 2025
10 of 11 checks passed
@nuno-vieira nuno-vieira deleted the fix/reactions-overlay-not-dismissed-when-opening-thread branch July 3, 2025 09:01
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Jul 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nuno-vieira @Stream-SDK-Bot @martinmitrevski