Fix double error indicator when attachment fails + Fix message message sending state indicator #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
|
martinmitrevski
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
https://linear.app/stream/issue/IOS-573/[swiftui]-sending-image-while-offline-shows-double-error-indicator
🎯 Goal
Fixes the double error indicator when the attachment fails.
Fixes the pending state icon when sending a message.
🛠 Implementation
Fix the double error indicator when the attachment fails
This issue would be mostly noticable when the message text was empty, and only one attachment was sent. So the easiest fix for now is to not show the error indicator in the message in case the text is empty. Other solutions would require breaking changes, and so this one is a good middle ground.
Fix the pending state icon when sending a message
While fixing this issue, I noticed that even when sending the message offline, the error indicator would show, but the "Read indicator" would also show, which is incorrect. Besides that, now pending icon was shown because the ".sending" state was being ignored. So now we have the correct states:
🧪 Manual Testing Notes
Fix the double error indicator when the attachment fails:
Fix the pending state icon when sending a message:
☑️ Contributor Checklist
docs-contentrepo