Fix draft not deleted when attachments are removed from the composer #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
nuno-vieira
force-pushed
the
fix/draft-not-deleted-when-attachments-are-deleted-from-composer
branch
from
4f02ad7 to
294ab79
Compare
SDK Size
|
martinmitrevski
approved these changes
Mar 27, 2025
…e-deleted-from-composer
nuno-vieira
deleted the
fix/draft-not-deleted-when-attachments-are-deleted-from-composer
branch
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
https://linear.app/stream/issue/IOS-764/fix-draft-not-deleted-when-attachments-are-removed-from-the-composer
🎯 Goal
Fix draft not deleted when attachments are removed from the composer.
🛠 Implementation
Previously, we were deleting the draft only when the text was erased from the composer. Now we check whenever the attachments change to empty as well.
🧪 Manual Testing Notes
1- Open a Channel
2- Write text and an attachment
3- Leave the channel
4- Open the channel again
5- Delete the text first
6- Delete the attachment
7- Leave the channel
8- The draft should be deleted
☑️ Contributor Checklist
docs-contentrepo