Move ChangeBarsVisibilityModifier into ViewFactory for better customization
#774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laevandus
reviewed
Mar 6, 2025
| /// Creates a view modifier that changes the visibility of bars. | ||
| /// - Parameter shouldShow: A Boolean value indicating whether the bars should be shown. | ||
| /// - Returns: A view modifier that changes the visibility of bars. | ||
| func changeBarsVisibility(shouldShow: Bool) -> ChangeBarsVisibilityModifier |
There was a problem hiding this comment.
Please use the same naming pattern e.g. makeChannelBarsVisibilityViewModifier
There was a problem hiding this comment.
Sure, I've pushed a new commit to fix this, pls check it out
sheep-q
force-pushed
the
chat/change_bar_visibility
branch
from
03b8925 to
03a8a7d
Compare
|
@sheep-q Thank you for your contribution. We'll run CI checks manually and will merge it then. |
|
CI checks were all good. Merging |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
ChangeBarsVisibilityModifierintoViewFactoryfor better customization🔗 Issue Link
N/A
🎯 Goal
The current code work well with SwiftUI only, but if the UITabbar is implemented using UIKit, it won't function correctly.
Therefore, I'm requesting a feature to allow customizing the
ChangeBarsVisibilityModifierthroughViewFactory🛠 Implementation
Move
ChangeBarsVisibilityModifierlogic intoViewFactoryfor better customization🧪 Testing
Describe the steps how this change can be tested (or why it can't be tested).
🎨 Changes
Add relevant screenshots or videos showcasing the changes.
☑️ Checklist