Skip to content

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Mar 3, 2025

🔗 Issue Link

Regression introduced here: #767

🎯 Goal

I did not realise that onImageTap was also for video assets. So it was also trying to convert videos into jpg. So it broke the composer.

🧪 Testing

It should be possible to add video assets to the composer.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@nuno-vieira nuno-vieira requested a review from a team as a code owner March 3, 2025 19:35
@github-actions
Copy link

github-actions bot commented Mar 3, 2025

1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChatSwiftUI 8.17 MB 8.17 MB 0 KB 🟢

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2025

@nuno-vieira nuno-vieira merged commit b287254 into develop Mar 3, 2025
12 checks passed
@nuno-vieira nuno-vieira deleted the fix/composer-video-previews branch March 3, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants