Improve voice over labels and actions #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
laevandus
force-pushed
the
improve-voice-over
branch
from
d12819b to
761737c
Compare
laevandus
force-pushed
the
improve-voice-over
branch
from
761737c to
51e5815
Compare
laevandus
force-pushed
the
improve-voice-over
branch
from
51e5815 to
f72d4ee
Compare
laevandus
changed the title
laevandus
commented
Jan 22, 2025
| .padding(.all, 8) | ||
| Spacer() | ||
| } | ||
| .accessibilityAddTraits(.isHeader) |
There was a problem hiding this comment.
VO reads: "22 Jan, header". Otherwise it would be hard to know what the date is about.
martinmitrevski
approved these changes
Jan 22, 2025
laevandus
changed the title
laevandus
commented
Jan 23, 2025
|
|
||
| static func files(in messageCell: XCUIElement) -> XCUIElementQuery { | ||
| messageCell.images.matching(NSPredicate(format: "identifier LIKE 'FileAttachmentsContainer'")) | ||
| messageCell.buttons.matching(NSPredicate(format: "identifier LIKE 'FileAttachmentsContainer'")) |
There was a problem hiding this comment.
Added accessibilityAction which changes elements to buttons
Element subtree:
→Other, 0x106509d10, {{4.0, 670.8}, {294.2, 89.0}}, identifier: 'MessageContainerView'
Other, 0x106509e30, {{4.0, 723.7}, {36.0, 36.0}}, identifier: 'MessageAvatarView'
Image, 0x106509f50, {{4.0, 723.7}, {36.0, 36.0}}
Other, 0x10650a070, {{47.5, 670.8}, {250.7, 69.0}}, identifier: 'MessageView'
Button, 0x10650a190, {{47.5, 670.8}, {250.7, 69.0}}, identifier: 'FileAttachmentsContainer', label: 'file_1, 123 KB'
Image, 0x10650a2b0, {{60.0, 685.3}, {34.0, 40.0}}
StaticText, 0x10650a3d0, {{102.0, 683.3}, {40.3, 20.3}}, label: 'file_1'
StaticText, 0x10650a4f0, {{102.0, 711.7}, {42.3, 15.7}}, label: '123 KB'
StaticText, 0x10650a610, {{48.0, 744.1}, {98.0, 15.7}}, identifier: 'MessageAuthorAndDateView', label: 'Han Solo, Sent at 10:07'
StaticText, 0x10650a730, {{48.0, 744.1}, {56.7, 15.7}}, identifier: 'MessageAuthorView', label: 'Han Solo'
StaticText, 0x10650a850, {{112.7, 744.1}, {33.3, 15.7}}, identifier: 'MessageDateView', label: 'Sent at 10:07'
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
Resolves IOS-641
🎯 Goal
Improve voice over by hiding decorative images, adding missing labels, and accessibility actions
🛠 Implementation
Reviewed common views with a focus on decorative images, confusing or missing labels, and adding accessibility actions for cases we have used tap gestures only. This PR just focused on before mentioned areas for making the basic usage better.
🧪 Testing
🎨 Changes
Add relevant screenshots or videos showcasing the changes.
☑️ Checklist