Skip to content

Make VoiceRecordingButton public #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 20, 2024
Merged

Make VoiceRecordingButton public #658

merged 5 commits into from
Nov 20, 2024

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Nov 20, 2024 •
edited
Loading

🔗 Issue Link

Resolves IOS-552
Resolves https://linear.app/stream/issue/IOS-552/make-voicerecordingbutton-public

🎯 Goal

Make VoiceRecordingButton public

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@nuno-vieira nuno-vieira requested a review from a team as a code owner November 20, 2024 11:56
martinmitrevski
martinmitrevski reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing a public init.

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Nov 20, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.99 MB 7.99 MB +1 KB 🟢

@nuno-vieira nuno-vieira enabled auto-merge (squash) November 20, 2024 12:40
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nuno-vieira nuno-vieira merged commit b2d67a9 into develop Nov 20, 2024
11 checks passed
@nuno-vieira nuno-vieira deleted the add/expose-voice-recording-button branch November 20, 2024 14:35
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nuno-vieira @Stream-SDK-Bot @martinmitrevski