Fix message long press taking too much time to show actions #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
martinmitrevski
approved these changes
Nov 11, 2024
|
nuno-vieira
deleted the
fix/long-pressing-message-takes-too-much-time
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
https://linear.app/stream/issue/IOS-15
🎯 Goal
Fix message long press taking too much time to show actions or not show at all for certain messages.
🛠 Implementation
Adds high priority gesture to the message long press.
I tried to improve the overall performance, but with the current architecture of the overlay it is difficult. In the future we need to change how we generate the snapshot. The snapshot should be generated for the message, and not for the background.
🧪 Testing
☑️ Checklist