-
Notifications
You must be signed in to change notification settings - Fork 110
Add support for Channel Search in the Channel List #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SDK Size
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one question - also relates to the UIKit search. At the moment, this only works with channel names, wonder if we can extend it to channel member names?
(But this is out of scope for this PR)
Yes this is also possible, is just a question of changing the autocomplete from |
Hi, could we release this version soon? I need this feature so that my app can be released soon. Thanks! |
The ETA is most likely next week. |
Hi @nuno-vieira , I’m sorry to ask this here, but could we also make this value public in the next version? |
Hi @nuno-vieira
![]() ![]() |
If that is a DM channel, then it won't work, because the channel search, at the moment only searches for Channel Names. DM Channels do not have channel names |
@nuno-vieira Do you have another way to customize the DM channel search? |
@spartan-tinhnguyen Can you create an issue here on the Repo? So that we can discuss it there? |
🔗 Issue Link
Resolves https://stream-io.atlassian.net/browse/PBE-6220
🎯 Goal
Adds support for Channel Search in the Channel List.
Usage:
Provide a
searchType
of.channels
when creating theChatChannelListView:
Docs PR: GetStream/stream-chat-swift#3471
🛠 Implementation
A new
searchType
is introduced when creating a Channel List. The channel list view model will use this property to decide to perform a search by channels or by messages.Another alternative approach was to introduce some kind of
ChatChannelListSearchResultsProvider
, which would abstract how the search implementation is done. However, the implementation was a bit more extensive and complex, so for now, this simple switch-case approach works fine and is easy to understand. In case we need a more scalable implementation in the future, we can consider this approach again. Here is the WIP implementation: b4ac2df🧪 Testing
Change the
DemoAppSwiftUIApp.channelListSearchType
to.channels
in the code.Since there is no Configuration Screen in the SwiftUI app to test this, it needs to be done using Xcode.
☑️ Checklist