Skip to content

[CI] Improvements #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2024
Merged

[CI] Improvements #613

merged 2 commits into from
Sep 30, 2024

Conversation

testableapple
Copy link
Contributor

@testableapple testableapple commented Sep 30, 2024 •
edited
Loading

  • Extract merge_main_to_develop to an indie lane to be able to run it locally
  • Trigger release_publish.yml workflow via gh instead of push event that did not work

@testableapple testableapple added the 🤖 CI/CD Any work related to CI/CD label Sep 30, 2024
@testableapple testableapple requested a review from a team as a code owner September 30, 2024 10:22
@testableapple testableapple changed the title [CI] Extract merge_main to an indie lane to be able to run it locally [CI] Improvements Sep 30, 2024
martinmitrevski
martinmitrevski approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you also update the release notion and the JIRA ticket?

@testableapple
Copy link
Contributor Author

testableapple commented Sep 30, 2024 •
edited
Loading

Did you also update the release notion and the JIRA ticket?

Nothing changed yet. I still hope that granting Admin rights to bot will solve the issue. If not, I'll update the docs and remove this step from the pipeline.

@testableapple testableapple merged commit 4a84d28 into develop Sep 30, 2024
10 checks passed
@testableapple testableapple deleted the ci/merge-main-to-develop branch September 30, 2024 14:08
@martinmitrevski
Copy link
Contributor

Did you also update the release notion and the JIRA ticket?

Nothing changed yet. I still hope that granting Admin rights to bot will solve the issue. If not, I'll update the docs and remove this step from the pipeline.

Adding admin rights to a bot could be risky - I would prefer if we stick to this step.

@testableapple
Copy link
Contributor Author

Ok, let's revert it back to write permissions and manual step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

No one assigned

Labels

🤖 CI/CD Any work related to CI/CD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@testableapple @martinmitrevski