ChatChannelListView navigation did not trigger when using a custom container #609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
Resolves: PBE-6081
🎯 Goal
ChatChannelListView
breaks its navigation after the embedded view reloads its bodyChatChannelListView.init
🛠 Implementation
The default
onTapHandler
captures the view model instance created within the view, not the one stored in the @StateObject property. When view reloads,onTapHandler
captures the incorrect instance.🧪 Testing
DemoAppSwiftUIApp.swift
case .loggedIn:
implementation with:and add
@State private var isBroken = false
to the
DemoAppSwiftUIApp
type3. Launch the demo app
4. Tap on any of the items and verify that the tapped channel is opened
5. Navigate back to the channel list, tap on the "Break" button and verify that navigation is still possible.
☑️ Checklist