Jump to first unread message button in the message list was not possible to close in some cases #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinmitrevski
approved these changes
Sep 9, 2024
…ble to close in some cases
laevandus
force-pushed
the
fix/closing-jump-to-unread
branch
from
d487aaf to
e600a4e
Compare
SDK Size
|
|
Will fix the broken tests from the third-party PR directly |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
Resolves: PBE-5957
🎯 Goal
Always close the jump to unread message button when tapping on the x button on it.
🛠 Implementation
Closing the jump to unread message button relies on an API call which marks all the messages as read. API call can timeout or take a long time depending on the internet connection. This change will hide the button as soon as it is tapped.
🧪 Testing
🎨 Changes
☑️ Checklist