Add custom hook types #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicnicius
force-pushed
the
feat/add-custom-hook-types
branch
from
09bb134
to
316cf29
Compare
|
Size Change: -1.51 kB (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
mahboubii
approved these changes
Nov 4, 2020
Upgrading typescript to the 4.1 release candidate as 4.0.x contains a bug that prevents us from adding new types to our definition file.
Signed-off-by: Vini Andrade <[email protected]>
Signed-off-by: Vini Andrade <[email protected]>
Signed-off-by: Vini Andrade <[email protected]>
Signed-off-by: Vini Andrade <[email protected]>
vicnicius
force-pushed
the
feat/add-custom-hook-types
branch
from
9f66bcb
to
590b32d
Compare
Signed-off-by: Vini Andrade <[email protected]>
mahboubii
approved these changes
Nov 4, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request
Moving some custom hook type definitions to
.d.ts. Due to microsoft/TypeScript#38691 it wasn't possible to do so on the version of TS we were using, so I upgraded TS and locked it to their current release candidate.closes #481