fix: determine audio recording format with MediaRecorder.isTypeSupported not userAgent #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted not userAgent
MartinCupela
requested review from
oliverlaz,
myandrienko and
arnautov-anton
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2639 +/- ##
==========================================
+ Coverage 80.76% 80.84% +0.08%
==========================================
Files 450 450
Lines 9653 9652 -1
Branches 2303 2303
==========================================
+ Hits 7796 7803 +7
+ Misses 1737 1730 -7
+ Partials 120 119 -1 ☔ View full report in Codecov by Sentry. |
|
Size Change: +2 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Feb 11, 2025
MartinCupela
deleted the
fix/audio-recording-format-mediarecorder-istypesupported
branch
github-actions bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
## [12.12.0](v12.11.1...v12.12.0) (2025-02-12) ### Bug Fixes * determine audio recording format with MediaRecorder.isTypeSupported not userAgent ([#2639](#2639)) ([1c445de](1c445de)) ### Features * add general purpose search components ([#2588](#2588)) ([d545207](d545207)) ### Chores * **deps:** upgrade react-markdown to v9 ([#2643](#2643)) ([07812fe](07812fe))
|
🎉 This PR is included in version 12.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Introduce a more reliable way to determine, what audio recording format should be used as navigator.userAgent is not reliable.