feat: add general purpose search components #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… components and types
…earchSourceResultListEnd
MartinCupela
requested review from
oliverlaz,
myandrienko and
arnautov-anton
…cusedMessage value
|
Size Change: +146 kB (+12.11%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
MartinCupela
force-pushed
the
feat/search-channel-by-message-text
branch
from
fc2a860 to
ed3f7da
Compare
| @@ -380,18 +398,29 @@ const UnMemoizedChannelList = < | |||
| }, | |||
| ); | |||
|
|
|||
| const showChannelList = !searchActive || additionalChannelSearchProps?.popupResults; | |||
| const showChannelList = | |||
| (!searchActive && !searchIsActive) || additionalChannelSearchProps?.popupResults; | |||
There was a problem hiding this comment.
Not sure what the difference between searchActive and searchIsActive is at first glance.
There was a problem hiding this comment.
One is a label to display the old ChannelSearch and the other is derived from the state of searchController to display the new Search component.
oliverlaz
approved these changes
Feb 12, 2025
# Conflicts: # package.json # yarn.lock
github-actions bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
## [12.12.0](v12.11.1...v12.12.0) (2025-02-12) ### Bug Fixes * determine audio recording format with MediaRecorder.isTypeSupported not userAgent ([#2639](#2639)) ([1c445de](1c445de)) ### Features * add general purpose search components ([#2588](#2588)) ([d545207](d545207)) ### Chores * **deps:** upgrade react-markdown to v9 ([#2643](#2643)) ([07812fe](07812fe))
|
🎉 This PR is included in version 12.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Provide general purpose search components and controller. Allow for absolute search customization.
Fixes React-24
Closes #1412
Depends on
🛠 Implementation details
Search controller
Coordinates search execution among individual search sources. Allows to combine unknown search sources defined by the integrator. Implements the search state machine.
Base search source
Takes care of common search source task like:
Search source
Class that takes advantage of inheriting from BaseSearchSource. Each search source should defined integrators or the default one is responsible for:
React components
The new components live in
experimental/Searchfolder. This allows for component name duplication compared toChannelSearchcomponents.An important change is the ability to jump from a message search result to that message in the parent channel. Currently the information about the jumped-to-message is stored in the SearchController state, but this should be moved to a future message list controller state.
The searchController instance has been added to the
ChatContext.ChannelListallows to override theChannelSearchcomponent with the experimentalSearchcomponent asAlso
ChannelAvatarhas been added to the component context value as a separate key and is prioritized inChannelHeaderandChannelPreview,Out of scope
🎨 UI Changes
VO0L.webm