fix: change react-native-image-crop-picker to react-native-image-picker and made it optional #2582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and make it optional
oliverlaz
reviewed
Jul 10, 2024
| handleReaction, | ||
| handleRetry, | ||
| handleThreadReply, | ||
| hasCameraPicker = takePhoto !== null, |
Member
There was a problem hiding this comment.
this is a pretty dangerous check takePhoto !== null as it relies on implementation details that may change in the future without us knowing about their side-effects. Can't we just export a new variable isCameraPickerAvailable (or something similar) instead?
Member
There was a problem hiding this comment.
If this is a common pattern for all optional dependencies, I think we should make this change everywhere.
Member
Author
There was a problem hiding this comment.
I have pushed it, though not from the native-package dir, but it's handled in the native.ts file of the core that exposes functions and then within the code the functions are used to check the availability of the package.
oliverlaz
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch