Hotfix/upstream fixes #2380
Closed
Hotfix/upstream fixes #2380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 27cbb03.
…-fork # Conflicts: # packages/stream_chat/CHANGELOG.md # packages/stream_chat_flutter/CHANGELOG.md # packages/stream_chat_flutter/lib/src/attachment/builder/attachment_widget_builder.dart # packages/stream_chat_flutter/pubspec.yaml # packages/stream_chat_flutter_core/pubspec.yaml # packages/stream_chat_localizations/pubspec.yaml # packages/stream_chat_persistence/pubspec.yaml
Sync fork
- Fix Bubble shape if reversed
# Conflicts: # packages/stream_chat_flutter/example/ios/Runner.xcodeproj/project.pbxproj # packages/stream_chat_flutter/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme # packages/stream_chat_flutter/lib/src/message_widget/message_widget.dart # packages/stream_chat_flutter/pubspec.yaml # packages/stream_chat_flutter_core/pubspec.yaml # packages/stream_chat_localizations/pubspec.yaml # packages/stream_chat_persistence/pubspec.yaml
Fix suffix position
Co-authored-by: xsahil03x <[email protected]>
# Conflicts: # packages/stream_chat/CHANGELOG.md # packages/stream_chat_flutter_core/CHANGELOG.md
# Conflicts: # packages/stream_chat_flutter/CHANGELOG.md # packages/stream_chat_flutter/lib/src/message_input/stream_message_input.dart # packages/stream_chat_persistence/CHANGELOG.md
The animation curves and durations for the reaction picker and message modal have been updated for a smoother user experience. - The `reaction_picker_icon_list.dart` animation curve is now `Curves.easeOutBack` and the duration is 335 milliseconds. - The `message_modal.dart` transition duration is now 335 milliseconds, and the scale animation curve is `Curves.easeOutBack`.
# Conflicts: # packages/stream_chat_persistence/CHANGELOG.md # packages/stream_chat_persistence/lib/src/db/drift_chat_database.dart
This method allows for safe access to the `StreamChatConfigurationData` from a `BuildContext`, returning null if no ancestor `StreamChatConfiguration` is found. This is useful for async operations where the context might not be guaranteed to have a `StreamChatConfiguration` above it. The `StreamChatConfiguration.of()` method has been updated to use `maybeOf()` internally and now provides more detailed error messages if a `StreamChatConfiguration` is not found.
# Conflicts: # melos.yaml # packages/stream_chat/CHANGELOG.md # packages/stream_chat/example/pubspec.yaml # packages/stream_chat/lib/version.dart # packages/stream_chat/pubspec.yaml # packages/stream_chat_flutter/CHANGELOG.md # packages/stream_chat_flutter/example/pubspec.yaml # packages/stream_chat_flutter/pubspec.yaml # packages/stream_chat_flutter_core/example/pubspec.yaml # packages/stream_chat_flutter_core/pubspec.yaml # packages/stream_chat_localizations/CHANGELOG.md # packages/stream_chat_localizations/example/pubspec.yaml # packages/stream_chat_localizations/pubspec.yaml # packages/stream_chat_persistence/CHANGELOG.md # packages/stream_chat_persistence/example/pubspec.yaml # packages/stream_chat_persistence/pubspec.yaml # sample_app/pubspec.yaml
# Conflicts: # packages/stream_chat_flutter/CHANGELOG.md # packages/stream_chat_flutter/lib/src/fullscreen_media/full_screen_media_desktop.dart # packages/stream_chat_flutter/lib/src/message_input/stream_message_input.dart # packages/stream_chat_flutter/lib/src/message_widget/message_widget.dart
…age send or update retry (GetStream#2330) Co-authored-by: Sahil Kumar <[email protected]>
This commit addresses the following: - **LLC:** Ensures that the message state is correctly updated to `failed` before attempting to retry in `sendMessage`, `updateMessage`, `partialUpdateMessage`, and `deleteMessage`. Previously, the state was only updated after a successful retry or if the retry failed again. - **LLC:** `retryFailedMessages` now correctly handles the case where there are no failed messages. - **UI:** The `message_actions_builder` now correctly hides actions for messages that are in a `deleted` state, even if they also have a `failed` state. - **UI:** Fixes an issue where deleted messages with a failed state would have incorrect spacing.
# Conflicts: # packages/stream_chat/CHANGELOG.md # packages/stream_chat/test/src/client/channel_test.dart # packages/stream_chat_flutter/test/src/poll/creator/goldens/ci/stream_poll_creator_dialog_dark.png # packages/stream_chat_flutter/test/src/poll/creator/goldens/ci/stream_poll_creator_dialog_light.png # packages/stream_chat_flutter/test/src/poll/creator/goldens/ci/stream_poll_creator_full_screen_dialog_dark.png # packages/stream_chat_flutter/test/src/poll/creator/goldens/ci/stream_poll_creator_full_screen_dialog_light.png # packages/stream_chat_flutter/test/src/poll/goldens/ci/stream_poll_creator_dialog_dark.png # packages/stream_chat_flutter/test/src/poll/goldens/ci/stream_poll_creator_dialog_light.png # packages/stream_chat_flutter/test/src/poll/goldens/ci/stream_poll_creator_full_screen_dialog_dark.png # packages/stream_chat_flutter/test/src/poll/goldens/ci/stream_poll_creator_full_screen_dialog_light.png
# Conflicts: # melos.yaml # packages/stream_chat/example/pubspec.yaml # packages/stream_chat/lib/src/client/channel.dart # packages/stream_chat/lib/src/client/client.dart # packages/stream_chat/lib/src/core/api/responses.dart # packages/stream_chat/lib/src/core/api/responses.g.dart # packages/stream_chat/lib/src/core/models/channel_state.dart # packages/stream_chat/lib/src/core/models/channel_state.g.dart # packages/stream_chat/lib/version.dart # packages/stream_chat/pubspec.yaml # packages/stream_chat/test/src/core/models/channel_state_test.dart # packages/stream_chat_flutter/example/pubspec.yaml # packages/stream_chat_flutter/pubspec.yaml # packages/stream_chat_flutter_core/CHANGELOG.md # packages/stream_chat_flutter_core/example/pubspec.yaml # packages/stream_chat_flutter_core/pubspec.yaml # packages/stream_chat_localizations/CHANGELOG.md # packages/stream_chat_localizations/example/pubspec.yaml # packages/stream_chat_localizations/pubspec.yaml # packages/stream_chat_persistence/CHANGELOG.md # packages/stream_chat_persistence/example/pubspec.yaml # packages/stream_chat_persistence/pubspec.yaml # sample_app/pubspec.yaml
Version upgrade to 10.0.0-beta.5
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughIntroduces v10-beta updates across core and Flutter layers: new live/static location sharing, Reaction model/signature changes, event normalization via resolvers/controller, failure-state payloads, reaction groups, and assorted deprecations/removals (calls, permission type, old voice-recording widgets). Adds docs/migration guide, bumps versions, updates tests/fixtures, and adjusts UI builders, actions, and localization. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant UI as Flutter UI
participant CH as Channel
participant CL as StreamChatClient
participant API as User/Message API
participant S as Server
rect rgb(245,248,255)
note right of UI: New: Live/Static Location Sharing
U->>UI: Share location (static/live)
UI->>CH: sendStaticLocation()/startLiveLocationSharing()
CH->>CL: sendMessage with shared_location payload
CL->>API: POST /channels/.../message
API->>S: Create message with location
S-->>CL: Event message.new (location)
CL->>CH: Emit via EventController (resolved to location.shared)
CH->>CH: Update state.activeLiveLocations
CH-->>UI: Stream update (active locations / message)
end
rect rgb(255,248,245)
note right of UI: Changed: Reaction flow uses Reaction object
U->>UI: React to message
UI->>CH: sendReaction(message, Reaction{type,emojiCode,score})
CH->>CL: sendReaction(messageId, Reaction, {skipPush?,enforceUnique?})
CL->>API: POST /messages/{id}/reaction {reaction, skip_push,...}
API->>S: Persist reaction
S-->>CL: Event reaction.new
CL-->>UI: Event stream (unchanged consumption)
end
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (105)
📒 Files selected for processing (107)
⛔ Files not processed due to max files limit (36)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the missing suffix icon that was overlooked during upstream sync.
Summary by CodeRabbit
New Features
Breaking Changes
Bug Fixes
Documentation