Fix gradient avatar colors for users with same-length IDs #2378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StreamGradientAvatarwidget was generating identical colors for all users with same-length user IDs due to usinguserId.lengthas the random seed. This caused users with IDs like "12133", "12134", and "12135" to all receive the same gradient avatar color, significantly reducing visual diversity in user lists.Problem
The issue occurred in two places within
PolygonGradientPainter:paint()method:Random(userId.length)for gradient selectiontransformPoints()method:Random(userId.length)for polygon transformationSince all users with 5-character IDs would generate
Random(5), they would produce identical random sequences and therefore identical gradient colors.Solution
Changed the random seed from
userId.lengthtouserId.hashCode:This ensures that:
Additional Improvements
Offset4.draw()deterministic using position-based seedsValidation
Testing with users having same-length IDs (12133, 12134, 12135):
Fixes #2369.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)https://storage.googleapis.com/flutter_infra_release/flutter/c29809135135e262a912cf583b2c90deb9ded610/dart-sdk-linux-x64.zipcurl --retry 3 --continue-at - --location --output /tmp/flutter/bin/cache/dart-sdk-linux-x64.zip REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.