chore(repo): use stream bot in golden workflow #2251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsahil03x
force-pushed
the
chore/use-stream-bot-in-golden-workflow
branch
from
efcbda4 to
eff1dbe
Compare
xsahil03x
force-pushed
the
chore/use-stream-bot-in-golden-workflow
branch
from
91d5f61 to
2e4b419
Compare
xsahil03x
force-pushed
the
chore/use-stream-bot-in-golden-workflow
branch
from
55c1691 to
7aa59b1
Compare
xsahil03x
force-pushed
the
chore/use-stream-bot-in-golden-workflow
branch
from
2ca978c to
85a626d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the golden workflow to use the Stream SDK Bot for committing changes.
- Added SSH key injection for secure repository checkout.
- Updated git-auto-commit-action configuration to use Stream SDK Bot and a specific file pattern when committing golden image updates.
Comments suppressed due to low confidence (1)
.github/workflows/update_goldens.yml:36
- Double-check that the file_pattern is comprehensive enough to capture all intended golden images. If golden images exist outside the specified test folder, consider a broader pattern to ensure all are committed.
file_pattern: "**/test/**/goldens/*.png"
renefloor
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the
.github/workflows/update_goldens.ymlworkflow to use the Stream Bot to commit the updated golden files which fixes an issue where the commit was not triggering any workflow checks. Additionally it also improves the workflow by only committing the golden files.