Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add Giphy E2E tests #5557

Merged
merged 2 commits into from
Jan 14, 2025
Merged

[CI] Add Giphy E2E tests #5557

merged 2 commits into from
Jan 14, 2025

Conversation

testableapple
Copy link
Collaborator

@testableapple testableapple commented Jan 14, 2025

Resolve https://linear.app/stream/issue/AND-226

🎯 Goal

Copy-paste all the Giphy E2E tests from iOS to Android

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

gif

Copy link
Contributor

github-actions bot commented Jan 14, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.04 MB 3.04 MB 0.00 MB 🟢
stream-chat-android-offline 3.25 MB 3.25 MB 0.00 MB 🟢
stream-chat-android-ui-components 7.91 MB 7.91 MB 0.00 MB 🟢
stream-chat-android-compose 9.04 MB 9.04 MB 0.00 MB 🟢

@testableapple testableapple force-pushed the ci/add-giphy-e2e-tests branch from 343a493 to a6a9f8e Compare January 14, 2025 14:30
@testableapple testableapple marked this pull request as ready for review January 14, 2025 14:48
@testableapple testableapple requested a review from a team as a code owner January 14, 2025 14:48
@JcMinarro JcMinarro enabled auto-merge (squash) January 14, 2025 16:39
@JcMinarro JcMinarro merged commit ae8d106 into develop Jan 14, 2025
10 checks passed
@JcMinarro JcMinarro deleted the ci/add-giphy-e2e-tests branch January 14, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants